Re: CDI & Class Metadata Parsing

2017-09-18 Thread Sergey Beryozkin
My understanding ClassUnwrapper callback was added to support these scenarios, Romain may've used it. Sergey On 17/09/17 23:27, John D. Ament wrote: On Sun, Sep 17, 2017 at 5:09 PM Sergey Beryozkin wrote: Hi On 17/09/17 15:37, John D. Ament wrote: Hey So I just ran into an issue where Exce

Re: Does SSE + CDI work?

2017-09-18 Thread Sergey Beryozkin
Have a look at the sse cdi demo Andriy added to the distribution, the feature (the one dealing with SSE) is expected to be auto-registered. Re the transport id, by default CXF assumes it is 'plain' HTTP, so it needs a hint. What did you mean with 1) ? Sergey On 18/09/17 00:57, John D. Ament

Re: CDI & Class Metadata Parsing

2017-09-18 Thread John D. Ament
Would you be in favor of having one checked in and used by default if you're using CDI integration? On Mon, Sep 18, 2017 at 4:41 AM Sergey Beryozkin wrote: > My understanding ClassUnwrapper callback was added to support these > scenarios, Romain may've used it. > > Sergey > On 17/09/17 23:27, Jo

Re: Does SSE + CDI work?

2017-09-18 Thread John D. Ament
I'm assuming you mean https://github.com/apache/cxf/blob/master/distribution/src/main/release/samples/jax_rs/sse_cdi/src/main/java/demo/jaxrs/sse/StatsApplication.java#L39 ? That looks manually registered. For my #1 its a CDI 2.0 feature. I think it'll work with this approach though. Any thought

Re: CDI & Class Metadata Parsing

2017-09-18 Thread Sergey Beryozkin
For it to be part of the CXF CDI module ? Sure, if it can help to improve it then yes, I'm not sure if activating it by default will work for Romain, but please create PR and let Andriy and Romain comment Thanks, Sergey On 18/09/17 11:08, John D. Ament wrote: Would you be in favor of having

Re: Does SSE + CDI work?

2017-09-18 Thread Sergey Beryozkin
On 18/09/17 11:14, John D. Ament wrote: I'm assuming you mean https://github.com/apache/cxf/blob/master/distribution/src/main/release/samples/jax_rs/sse_cdi/src/main/java/demo/jaxrs/sse/StatsApplication.java#L39 ? That looks manually registered. It should not be there, we need to add a CXF @Pro

Re: Does SSE + CDI work?

2017-09-18 Thread Sergey Beryozkin
Ok, I added @Provider(value = Type.Feature, scope = Scope.Server) Andriy, will CXF CDI auto-discover it now or will it have to be updated a bit to have CXF features/interceptors picked up, same way we can do it for Spring ? Thanks, Sergey On 18/09/17 11:27, Sergey Beryozkin wrote: On 18/09/1

Re: CDI & Class Metadata Parsing

2017-09-18 Thread John D. Ament
Ok, PR is up - https://github.com/apache/cxf/pull/313 Please feel free to review. This is handling for me both OWB and Weld use cases. From my testing though, getting it registered early seems to work better than later since I rely on the CDI integration to create the bus. John On Mon, Sep 18,

Re: Does SSE + CDI work?

2017-09-18 Thread John D. Ament
On Mon, Sep 18, 2017 at 6:27 AM Sergey Beryozkin wrote: > On 18/09/17 11:14, John D. Ament wrote: > > I'm assuming you mean > > > https://github.com/apache/cxf/blob/master/distribution/src/main/release/samples/jax_rs/sse_cdi/src/main/java/demo/jaxrs/sse/StatsApplication.java#L39 > > ? > > That lo