Re: Exceptions and Async

2016-01-12 Thread Benson Margulies
See https://issues.apache.org/jira/browse/CXF-6744 and commit fa0eea884adf49a0a6f990e15a0e69d17800156e for my test case. On Mon, Jan 11, 2016 at 7:03 AM, Sergey Beryozkin wrote: > Sounds good, the unmapped/escaped exception must not cause blocking the > response, so yeah,

Re: Exceptions and Async

2016-01-11 Thread Sergey Beryozkin
Hi Benson The very first call into this method does not suspend the continuation, so there's no need to resume it if the exception is returned. Do you see a mapped exception response not being returned ? Please clarify Cheers, Sergey On 02/01/16 02:01, Benson Margulies wrote: If I am in a

Re: Exceptions and Async

2016-01-11 Thread Benson Margulies
On Mon, Jan 11, 2016 at 6:49 AM, Sergey Beryozkin wrote: > Hi Benson > On 11/01/16 11:42, Benson Margulies wrote: > >> Sergey, >> >> I annotate @Suspended. So it is suspended on the first call. >> >> It is not, believe me :-) because this is how I implemented it. > The

Re: Exceptions and Async

2016-01-11 Thread Sergey Beryozkin
Sounds good, the unmapped/escaped exception must not cause blocking the response, so yeah, please create a test I see a test testUnmappedAfterTimeout which asserts 500 is returned. This is a case where the current async response is suspended for some time and when it returns the unmapped

Re: Exceptions and Async

2016-01-11 Thread Benson Margulies
Sergey, I annotate @Suspended. So it is suspended on the first call. The quote I read from the spec says that returned values from @Suspended calls are ignored. It did not say what the spec says about exceptions from those calls. If they are also supposed to be ignored, then a big fat WARN log

Re: Exceptions and Async

2016-01-11 Thread Sergey Beryozkin
Hi Benson On 11/01/16 11:42, Benson Margulies wrote: Sergey, I annotate @Suspended. So it is suspended on the first call. It is not, believe me :-) because this is how I implemented it. The runtime does not have to physically suspend a call, given that the method can immediately call

Exceptions and Async

2016-01-01 Thread Benson Margulies
If I am in a method with an @Suspended AsyncResponse, and I neglect to catch an exception, CXF runs mappers but they don't do any good, of course, because nothing resumes the response. How about if CXF instead logged at ERROR about any exception thrown through a suspended resource method? I'm