Re: Marking call() method of generated closures with @Generated?

2020-12-16 Thread Damir Murat
It looks like I managed to create a working solution, but I also have several questions :-) Regarding the solution, it was not too complicated. I modified ClosureWriter and StaticTypesClosureWriter to annotate generated call methods with @Generated. Regarding questions. Modification started to

Re: Marking call() method of generated closures with @Generated?

2020-12-15 Thread Damir Murat
Here is an issue: https://issues.apache.org/jira/browse/GROOVY-9858 I can try to do something about PR, but will need some starting pointers if possible :-) Tnx.

Re: Marking call() method of generated closures with @Generated?

2020-12-12 Thread Paul King
Seems like a good idea to me. Want to create an issue? PR? Cheers, Paul. On Sun, Dec 13, 2020 at 6:11 AM MG wrote: > Hi Damir, > > the question you posed might have been asked before on > d...@groovy.apache.org, not entirely sure, in any case it seems more > suited for the developer ML, so you

Re: Marking call() method of generated closures with @Generated?

2020-12-12 Thread MG
Hi Damir, the question you posed might have been asked before on d...@groovy.apache.org, not entirely sure, in any case it seems more suited for the developer ML, so you might check the archives or try reposting it there. Cheers, mg On 12/12/2020 17:53, Damir Murat wrote: Any thought on

Re: Marking call() method of generated closures with @Generated?

2020-12-12 Thread Damir Murat
Any thought on this? I can see that many false negatives from my code could disappear from a code coverage report. But I might be missing something. Tnx

Marking call() method of generated closures with @Generated?

2020-12-07 Thread Damir Murat
As far as I understand, closures generated by the Groovy compiler contain both doCall() and call() methods, where call() always delegate to doCall(). Typically, users will use a short form of closure invocation, which Groovy translates to direct call of doCall(). This means that in a typical