Re: Got java.util.IllegalFormatConversionException when running MirrorMaker off trunk code

2015-03-08 Thread Jay Kreps
Hey guys, If we checked in obviously broken code on trunk, let's fix it now or revert that change. -Jay On Sat, Mar 7, 2015 at 12:48 AM, Jiangjie Qin j...@linkedin.com.invalid wrote: Hi Tao, Thanks a lot for finding the bug. We are actually rewriting the mirror maker in KAFKA-1997 with a

Re: Got java.util.IllegalFormatConversionException when running MirrorMaker off trunk code

2015-03-08 Thread Jiangjie Qin
Hi Jay, I’ve uploaded patch in KAFKA-2009 for this. It is a pretty small patch and it will be great if you can help review it. Thanks. Jiangjie (Becket) Qin On 3/8/15, 12:31 PM, Jay Kreps jay.kr...@gmail.com wrote: Hey guys, If we checked in obviously broken code on trunk, let's fix it now

Re: Got java.util.IllegalFormatConversionException when running MirrorMaker off trunk code

2015-03-07 Thread Jiangjie Qin
Hi Tao, Thanks a lot for finding the bug. We are actually rewriting the mirror maker in KAFKA-1997 with a much simplified solution using the newly added flush() call in new java producer. Mirror maker in current trunk is also missing one necessary synchronization - the

Re: Got java.util.IllegalFormatConversionException when running MirrorMaker off trunk code

2015-03-07 Thread tao xiao
Actually I was going to report another bug that was exactly caused by UncheckedOffsets.removeOffset issue (remove offsets before it is added) As the current project I am working on heavily relies on the functionalities MM offers it would be good that if you put the fix to trunk or gives me some

Got java.util.IllegalFormatConversionException when running MirrorMaker off trunk code

2015-03-06 Thread tao xiao
Hi team, I am having java.util.IllegalFormatConversionException when running MirrorMaker with log level set to trace. The code is off latest trunk with commit 8f0003f9b694b4da5fbd2f86db872d77a43eb63f The way I bring up is bin/kafka-run-class.sh kafka.tools.MirrorMaker --consumer.config

Re: Got java.util.IllegalFormatConversionException when running MirrorMaker off trunk code

2015-03-06 Thread tao xiao
A bit more context: I turned on async in producer.properties On Sat, Mar 7, 2015 at 2:09 AM, tao xiao xiaotao...@gmail.com wrote: Hi team, I am having java.util.IllegalFormatConversionException when running MirrorMaker with log level set to trace. The code is off latest trunk with commit

Re: Got java.util.IllegalFormatConversionException when running MirrorMaker off trunk code

2015-03-06 Thread tao xiao
I think I worked out the root cause Line 593 in MirrorMaker.scala trace(Updating offset for %s to %d.format(topicPartition, offset)) should be trace(Updating offset for %s to %d.format(topicPartition, offset.element)) On Sat, Mar 7, 2015 at 2:12 AM, tao xiao xiaotao...@gmail.com wrote: A