Re: [IronPython] What's the situation on being able to accept patches?

2008-10-16 Thread Dino Viehland
This is because we're not firing the module changed event. This seems like a bug, we should probably use a special dictionary here. You can call ScopeOps.SetMember() and it'll also deliver the event. -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Dan

Re: [IronPython] What's the situation on being able to accept patches?

2008-10-15 Thread Dan Eloff
Ok, I made the changes, PerformModuleReload is called, SetName is called, but only the builtin compile is called, the one on CompileHelper is never called. Any idea why? Here's my code: http://csharp.pastebin.com/m5a3d08cd Thanks, -Dan ___ Users mailing

Re: [IronPython] What's the situation on being able to accept patches?

2008-10-15 Thread Dan Eloff
I figured it out. It seems that depending on where the compile calls are located, they might call the old or the new compile function. import _ast compile(...) # old compile __builtins__.compile(...) # new compile I'm looking into how to get the new compile without messing up mako's code any

[IronPython] What's the situation on being able to accept patches?

2008-10-13 Thread Dan Eloff
I've completed the _ast module, fully implementing all classes from the CPython module for Python 2.5. In the end the only way to do it was as a patch to IronPython, partly because creating an ast from source is done through the compile() builtin, but also because someone did an optimization on

Re: [IronPython] What's the situation on being able to accept patches?

2008-10-13 Thread Michael Foord
Dan Eloff wrote: I've completed the _ast module, fully implementing all classes from the CPython module for Python 2.5. In the end the only way to do it was as a patch to IronPython, partly because creating an ast from source is done through the compile() builtin, but also because someone did an

Re: [IronPython] What's the situation on being able to accept patches?

2008-10-13 Thread Dan Eloff
The IronPython guys don't yet have permission to accept patches. Permission to contribute to the modules will come before contributions to the core IronPython - and we are unlikely to be ever able to contribute to the DLR. I guess the DLR is moving into the CLR so I can see why Microsoft

Re: [IronPython] What's the situation on being able to accept patches?

2008-10-13 Thread Dino Viehland
Harry's currently pushing on the lawyers to get this through although he's been a little distracted by PDC. I certainly hope we can take this back in 2.1 but I can't promise anything. The good news is that a Michael points out this is the exact sort of thing we want to take back first. In

Re: [IronPython] What's the situation on being able to accept patches?

2008-10-13 Thread Dan Eloff
On Mon, Oct 13, 2008 at 3:50 PM, Dino Viehland [EMAIL PROTECTED] wrote: In the mean time I would assume you just need the FunctionDefinition and Expression exposed off of GeneratorExpression. Is that right or is it something else? I should be able to do that for RC1. That's initially what

Re: [IronPython] What's the situation on being able to accept patches?

2008-10-13 Thread Dino Viehland
I think it should look something like this: delegate object ParamsDelegate(params object[] args); [SpecialName] public static void PerformModuleReload(PythonContext/*!*/ context, IAttributesCollection/*!*/ dict) { object prev;