Re: [OpenSIPS-Users] Registrar - max_contacts and 503 logging

2014-02-12 Thread Adrien Martin
Hello, Ok, thanks. Regards, Adrien Martin ___ Users mailing list Users@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/users

Re: [OpenSIPS-Users] Registrar - max_contacts and 503 logging

2014-02-11 Thread Bogdan-Andrei Iancu
Hello, OK, thanks for testing - I will push the fix I did in the public code. I will also give a bit more thinking to see what should be the best solution to expose the internal error. Regards, Bogdan-Andrei Iancu OpenSIPS Founder and Developer http://www.opensips-solutions.com On

Re: [OpenSIPS-Users] Registrar - max_contacts and 503 logging

2014-02-10 Thread Adrien Martin
Hello, I tested it, and it works. About the save() return codes, there are a lot of cases, so I would have sorted it this way: - no error, - error codes in parsing SIP, - server side errors (like manipulating usrloc), - and service errors (like too many registers). Here is a patch by way of

Re: [OpenSIPS-Users] Registrar - max_contacts and 503 logging

2014-02-09 Thread Bogdan-Andrei Iancu
Hello, Try the attached patch for preventing save() to stop your script. In regards to the error itself, $err is not suitable for that. The idea will be to have save() returning detailed negative codes to reflect the actual internal error. Regards, Bogdan-Andrei Iancu OpenSIPS Founder and

Re: [OpenSIPS-Users] Registrar - max_contacts and 503 logging

2014-02-08 Thread Martin Adrien
Hello, On 07/02/2014 21:00, Bogdan-Andrei Iancu wrote: Hello, Not sure a bug or an undocumented feature, but save() function, in case of internal error, is stopping the script. Assuming we change that (to continue the script execution), you will failure from save() without actually

Re: [OpenSIPS-Users] Registrar - max_contacts and 503 logging

2014-02-07 Thread Bogdan-Andrei Iancu
Hello, Not sure a bug or an undocumented feature, but save() function, in case of internal error, is stopping the script. Assuming we change that (to continue the script execution), you will failure from save() without actually knowing the error itself. I assume you are looking the error