Re: Should I disable maven-compiler-plugin when using aspectj-maven-compiler?

2016-01-13 Thread Alexander Kriegisch
+1 Dagan, I use the AspectJ Maven Plugin a lot, I just did not get around to answering. But you found my (kriegaex) answer on StackOverflow anyway, so you have a working solution. This is what I use all the time, i.e. useIncrementalCompilation=false for Maven Compiler and phase=process-sources

Re: Should I disable maven-compiler-plugin when using aspectj-maven-compiler?

2016-01-13 Thread Dagan Sandler
Sorry if you were offended for some reason, but let's look at it objectively: 1) I ask a question, you post an answer with a link to a website that contains a message that it was migrated to a different location. Since I don't really know what you thought was there, I can't really guess where to f

RE: Maven javadoc plugin's aggregate-jar goal, multi-module project, and code generation

2016-01-13 Thread Robert Patrick
Yeah, but that won't help since the code is not all in a single module. By default, the aggregate-jar goal docs claim it is bound to the package phase and all of my source in the submodules are generated in the generate-sources phase. Now that I analyze the output more carefully, it appears th

Re: Maven javadoc plugin's aggregate-jar goal, multi-module project, and code generation

2016-01-13 Thread Sarath Shasikumar
To execute plugin during certain phase, add to . Plugin should be fired: attach-javadocs install<-- HERE aggregate-jar Regards Sarath Shasikumar Systems Engineer Tata Consultancy Services Cell:- +91 97 46 136153 Mailto: sarath.shasiku...@t

Re: Maven javadoc plugin's aggregate-jar goal, multi-module project, and code generation

2016-01-13 Thread Sarath Shasikumar
To execute plugin during certain phase, add to . Plugin should be fired: attach-javadocs install<-- HERE aggregate-jar Regards Sarath Shasikumar Systems Engineer Tata Consultancy Services Cell:- +91 97 46 136153 Mailto: sarath.shasiku...@tc

Maven javadoc plugin's aggregate-jar goal, multi-module project, and code generation

2016-01-13 Thread Robert Patrick
I am beating my head against the wall on this and surely I am just being stupid so hopefully someone will take pity on me and point me in the right direction. I am trying to add Javadoc generation into my normal build process for my multi-module project. It all works fine if I run "mvn insta

Re: Filtering resources

2016-01-13 Thread Robert Scholte
Hi, What would you expect when start and end delimiters are the same in combination with nested expression. Don't think that'll ever work. I assume that in your case @PoolSize.@ and @@ are evaluated. AFAIK only with different delimiters nested expressions could work. thanks, Robert Op Wed, 1

Re: Maven Checkstyle

2016-01-13 Thread Adrien Rivard
I would try configuring sourceDirectories with the base directory of the project. see https://maven.apache.org/plugins/maven-checkstyle-plugin/check-mojo.html#sourceDirectories Though there may be better ways to check eol than checkstyle which is specific to java. On Wed, Jan 13, 2016 at 6:36 PM

Maven Checkstyle

2016-01-13 Thread John Vines
Usage question for maven checkstyle- Is there a way to have it work at the project root of a module, rather then at the src level? I'm trying to ensure that there are no CRLFs for non-binary files and it works fine for things under src, but I can't get it to detect files outside that dir. Thanks

RE: Should I disable maven-compiler-plugin when using aspectj-maven-compiler?

2016-01-13 Thread Martin Gainty
> Date: Wed, 13 Jan 2016 16:29:03 +0200 > Subject: Re: Should I disable maven-compiler-plugin when using > aspectj-maven-compiler? > From: dagansand...@gmail.com > To: users@maven.apache.org > > First, the link you gave redirects to a page saying CVS repositories have > been migrated and it d

Re: Should I disable maven-compiler-plugin when using aspectj-maven-compiler?

2016-01-13 Thread Dagan Sandler
First, the link you gave redirects to a page saying CVS repositories have been migrated and it doesn't point forward Second, the "proc" flag of the aspectj-maven-plugin is described also on the plugin's website http://www.mojohaus.org/aspectj-maven-plugin/compile-mojo.html#proc Third, I don't see

Re: Filtering resources

2016-01-13 Thread Thomas Sundberg
Hi! Filtering resources that uses @ as delimiters works. This example works as expected: @Environment@ But my use case involves filtering nested resources. An example looks like this: @PoolSize.@Environment@@ There seem to exist a closed bug regarding nested variables. https://issues.apache.o

RE: Should I disable maven-compiler-plugin when using aspectj-maven-compiler?

2016-01-13 Thread Martin Gainty
take a look athttp://dev.eclipse.org/viewcvs/index.cgi/org.aspectj/?root=Tools_Project find your way to this artifact:org.aspectj aspectjtools jar 1.8.5 AspectJ tools Tools from the AspectJ project http://www.aspectj.org take a gander at AjcTask.java and notice the setting of javac arg

Re: Should I disable maven-compiler-plugin when using aspectj-maven-compiler?

2016-01-13 Thread Dagan Sandler
Both, actually. In any case, using aspectj compiler through the maven-compiler-plugin seems to be causing more issues (it depends on an older version of aspectj tools, and raising it causes API errors) so it's definitely not the way for me. I'm guessing my issue comes mainly from the fact that mav

Re: Filtering resources

2016-01-13 Thread James Hutton
You could also look at DefaultMavenResourcesFiltering for an example. I think this is still using plexus so you'll have to have the component.xml iirc that is needed for co

Re: Should I disable maven-compiler-plugin when using aspectj-maven-compiler?

2016-01-13 Thread Anders Hammar
> > Does this act differently though than the aspectj-maven-plugin? Does it > play well with AJDT and eclipse? > I don't know; I don't use aspectj. Couldn't find any pointers on this in the aspact-maven-plugin docs so it might be the wrong path. However, couldn't find any instructions on using you

Re: Should I disable maven-compiler-plugin when using aspectj-maven-compiler?

2016-01-13 Thread Dagan Sandler
hmmm, possibly, never knew that option existed. I will check it. Does this act differently though than the aspectj-maven-plugin? Does it play well with AJDT and eclipse? On Wed, Jan 13, 2016 at 10:59 AM, Anders Hammar wrote: > Can't you just tell maven-compiler-plugin to use the aspectj compil

Re: Should I disable maven-compiler-plugin when using aspectj-maven-compiler?

2016-01-13 Thread Anders Hammar
Can't you just tell maven-compiler-plugin to use the aspectj compiler? https://maven.apache.org/plugins/maven-compiler-plugin/non-javac-compilers.html /Anders On Wed, Jan 13, 2016 at 9:41 AM, Dagan Sandler wrote: > Hi, > > I am in the process of updating my plugin definitions in all of the > pr

Should I disable maven-compiler-plugin when using aspectj-maven-compiler?

2016-01-13 Thread Dagan Sandler
Hi, I am in the process of updating my plugin definitions in all of the projects I manage. Notably, I tried updating maven-compiler-plugin from 2.5.1 to 3.3 but encountered an issue in a project that uses aspectj-maven-plugin. The issue is, it seems, that the maven-compiler-plugin is invoked befo