Re: Regarding config param dependencyReducedPomLocation for maven-shade-plugin

2019-01-13 Thread Matthieu BROUILLARD
Hi, I have faced the same problem recently on jgitver maven core dependency ( https://github.com/jgitver/jgitver-maven-plugin/issues/109). In fact, the problem popped up when a *fork* execution occures after that the pom file has been relocated. When this occures the basedir is computed as the dir

Re: Regarding config param dependencyReducedPomLocation for maven-shade-plugin

2019-01-13 Thread Mikael Åsberg
Hi Hervé, and thanks for your reply! So it sounds like since maven-shade-plugin still has not been updated to use the new API, the problem should still be there. But did you check my test project? I thought it would capture the problem, if it was still there and I understood it correctly, but I gue

Re: Problem with running Spring Integration Tests with mvn verify

2019-01-13 Thread Robert Kleinschmager
Your configuration looks fine for your task, but I’m sorry - I have no hint, why IntelliJ is faster. At first: it depends on, how your 500 Tests are organised. How many test-classes, how many methods do they have? Are you running JUnit4 or already Junit5? Are you using Parallel-Mode in IntelliJ

Re: Is specifying direct dependencies a good practice?

2019-01-13 Thread 林自均
Hi Hervé, Thank you for the review on my PR. I've updated the PR. Please let me know if you have further feedback. Best, John Lin Hervé BOUTEMY 於 2019年1月13日 週日 下午5:23寫道: > Thank you for transforming a learning done on the mailing list into a PR > > We already have some feedback on the PR from

Re: Regarding config param dependencyReducedPomLocation for maven-shade-plugin

2019-01-13 Thread Hervé BOUTEMY
Hi Good question: I did not yet find the official answer, but I can share what I know on this. flatten-maven-plugin has the exact same issue, and this was fixed in the past by adding a new API in Maven core (in 3.2.5) to be called by the plugin: see https://github.com/mojohaus/flatten-maven-plu

Re: Is specifying direct dependencies a good practice?

2019-01-13 Thread Hervé BOUTEMY
Thank you for transforming a learning done on the mailing list into a PR We already have some feedback on the PR from Maven developers, but feedback from users would be awesome also, since it's about making sure the explanations are easy to understand, then the more eyes, the better Regards, H