Re: HTTP/2 support in Maven

2020-11-05 Thread Benjamin Marwell
Well, if central supported h2 push, that would be a benefit! E.g. request shiro-web.jar and all the other dependencies would be pushed: shiro-core.jar/.pom etc. Maven would need to figure out which one it needed, so it doesn't redownload existing artifacts. So, no (or only marginal) gain without

Re: HTTP/2 support in Maven

2020-11-05 Thread Bernd Eckenfels
Hello, I don’t really see where http/2 should have a speed performance compared to http/1.1 as long as both use keepalive. For larger artifacts even the header reduction should be negectible. Having said that, it is of course a good idea to go with the new protocols, but I would not expect much

Re: HTTP/2 support in Maven

2020-11-05 Thread Jakub Bartecek
Hi, I'll look at it tomorrow and try to verify it really downloads the whole content, I did some checks on POM files and it really downloaded it. Thanks for testing it from your machine. It's interesting to see that you have completely different results. Honestly I'm not sure how that is possible,

Re: HTTP/2 support in Maven

2020-11-05 Thread Tamás Cservenák
(short disclaimer: am not a python speaking person, so the change I did above with intent to "consume response body, the artifact bytes" may not did what I wanted :D)

Re: HTTP/2 support in Maven

2020-11-05 Thread Tamás Cservenák
https://gist.github.com/cstamas/f87a12920d3c28e5db024dcd2f1a5d5f Given almost the same times, it seems it did consume :) Still, the factor of 3.8 is not seen by me (plain cable modem) Thanks T On Thu, Nov 5, 2020 at 5:23 PM Tamás Cservenák wrote: > I ran your script _unchanged_ on my mach

Re: HTTP/2 support in Maven

2020-11-05 Thread Tamás Cservenák
I ran your script _unchanged_ on my machine and got this result: https://gist.github.com/cstamas/b70f85ad601e5e2f399596b2e8cec7d1 Interestingly, http1 is quite "stable" -- roughly around 800ms while http2 is quite "jumpy" -- goes from 600 to 920ms Will try to add change to get the response conten

Re: HTTP/2 support in Maven

2020-11-05 Thread Tamás Cservenák
Hi Kuba, Can you clarify what exactly your script does re "download"? It seems it issues HTTP GET, but does it fully consume response? Does it get all the bytes of the artifact, or just the parses response header(s) and throws the rest? Thanks T On Thu, Nov 5, 2020 at 4:49 PM Jakub Bartecek wro

Re: HTTP/2 support in Maven

2020-11-05 Thread Jakub Bartecek
Hi, I did a performance test of HTTP/2 and its comparison with HTTP/1.1 and I would like to share my results with you. I wrote a Python script [1] to download 100 artifacts in parallel using asynchronous HTTP client supporting both HTTP/1.1 and HTTP/2. I chose 100 artifacts [2] from Maven Central,