Re: Maven shade transforming internal strings?

2012-07-23 Thread Jason Rutherglen
Hi Benson, This is the xml for the transform: http://pastebin.com/9nx18WiN Thanks! On Mon, Jul 23, 2012 at 10:21 AM, Benson Margulies bimargul...@gmail.comwrote: On Mon, Jul 23, 2012 at 12:16 AM, Jason Rutherglen jason.rutherg...@gmail.com wrote: I'm shade transforming Apache Solr, which

Re: Maven shade transforming internal strings?

2012-07-23 Thread Jason Rutherglen
that you could come up with a pattern that wouldn't hit things like 'os.name'? On Mon, Jul 23, 2012 at 10:37 AM, Jason Rutherglen jason.rutherg...@gmail.com wrote: Hi Benson, This is the xml for the transform: http://pastebin.com/9nx18WiN Thanks! On Mon, Jul 23, 2012 at 10:21

Re: Maven shade transforming internal strings?

2012-07-23 Thread Jason Rutherglen
Wayne, I agree with your point, however I think the include / exclude it may make sense for them to accept a type such as include type=literaljava.lang.Thread/include. This gives better fine grained control of what is being relocated. On Mon, Jul 23, 2012 at 12:50 PM, Wayne Fay

Re: Maven shade relocating everything not excluding

2012-07-06 Thread Jason Rutherglen
Do you mean a patch to the documentation online? On Tue, Jul 3, 2012 at 7:00 PM, Benson Margulies bimargul...@gmail.comwrote: You're welcome. Please feel free to submit a patch with a better explanation of this in the doc. On Tue, Jul 3, 2012 at 6:55 PM, Jason Rutherglen jason.rutherg

Re: Maven shade relocating everything not excluding

2012-07-03 Thread Jason Rutherglen
Benson, thanks for taking a look. This is probably the relevant XML being used, sorry for clogging up the body, attachments probably do not work. I have tried variants on excludeorg.apache.solr/exclude such as excludeorg.apache.solr.*/exclude and excludeorg/apache/solr/exclude plugin

Re: Maven shade relocating everything not excluding

2012-07-03 Thread Jason Rutherglen
...@gmail.comwrote: On Tue, Jul 3, 2012 at 11:12 AM, Jason Rutherglen jason.rutherg...@gmail.com wrote: relocation !-- pattern*/*/pattern -- shadedPatterncom.custom.solr./shadedPattern excludes

Re: Maven shade relocating everything not excluding

2012-07-03 Thread Jason Rutherglen
Debugged into SelectorUtils, it seems to be working correctly. I downloaded 1.5.5, step through that source. The matchPath methods returns false, however the if statement in isExcluded evaluates to true. Must be looking at the wrong code? On Tue, Jul 3, 2012 at 11:46 AM, Jason Rutherglen

Re: Maven shade relocating everything not excluding

2012-07-03 Thread Jason Rutherglen
: What version of Shade are you trying to use? On Tue, Jul 3, 2012 at 2:26 PM, Jason Rutherglen jason.rutherg...@gmail.com wrote: Debugged into SelectorUtils, it seems to be working correctly. I downloaded 1.5.5, step through that source. The matchPath methods returns false, however

Re: Maven shade relocating everything not excluding

2012-07-03 Thread Jason Rutherglen
Here's where the source for Maven Shade 1.7.1 was obtained: http://svn.apache.org/repos/asf/maven/plugins/tags/maven-shade-plugin-1.7.1 Also not sure how to view the return type inside an if statement using Eclipse. On Tue, Jul 3, 2012 at 2:52 PM, Jason Rutherglen jason.rutherg...@gmail.com

Re: Maven shade relocating everything not excluding

2012-07-03 Thread Jason Rutherglen
I found the issue, the exclude needs to look like this, two asterisks at the end. Thanks for your help. excludeorg.apache.solr.**/exclude On Tue, Jul 3, 2012 at 5:05 PM, Jason Rutherglen jason.rutherg...@gmail.com wrote: Here's where the source for Maven Shade 1.7.1 was obtained: http