Re: Can a plugin change the reactor 'pom'?

2019-08-28 Thread Niels Basjes
Hi, Thanks for the feedback. To me https://issues.apache.org/jira/browse/MSHADE-206 seems very closely related to https://issues.apache.org/jira/browse/MSHADE-36 for which I put up a patch yesterday: https://github.com/apache/maven-shade-plugin/pull/25 I did some experimenting last night and foun

Re: Can a plugin change the reactor 'pom'?

2019-08-27 Thread Kyle Marek
Shade used to modify the POM structure during build, but Maven was changed to disallow this behavior for reasons regarding build consistency. I ran into this issue somewhat recently. My approach for now, similar to your "Solution 3", to exclude the shaded dependencies from the module dependency, a

Can a plugin change the reactor 'pom'?

2019-08-27 Thread Niels Basjes
Hi, Last few days I dove into a dependency problem I had (and documented what I ran into here https://yauaa.basjes.nl/NOTES-shading-dependencies.html ). Along the way I fixed https://issues.apache.org/jira/browse/MSHADE-36 (use the dependency-reduced-pom.xml instead of the original pom.xml) and t