Re: Feedback sought

2023-10-15 Thread Daniel Widdis
Spotless is another great option. spotless/plugin-maven/README.md at main · diffplug/spotlessgithub.comSent from my iPhoneOn Oct 15, 2023, at 7:16 AM, Joseph Kesselman wrote:Hm. Doesn't handle language-semantic formatting (yet?), which in my experience is often a bigger deal than spaces vs tabs.

Re: Feedback sought

2023-10-15 Thread Joseph Kesselman
ntext Ribbon Campaign /\ Stamp out HTML mail! From: Nils Breunese Sent: Sunday, October 15, 2023 3:01:28 AM To: Maven Users List Subject: Re: Feedback sought Joseph Kesselman wrote: > Re "IDE droppings"... My experience is that they can actually be usefu

Re: Feedback sought

2023-10-15 Thread Joseph Kesselman
3:01:28 AM To: Maven Users List Subject: Re: Feedback sought Joseph Kesselman wrote: > Re "IDE droppings"... My experience is that they can actually be useful in > expressing things like preferred code formatting style in > importable/executable form. (I'd rather have

Re: Feedback sought

2023-10-15 Thread Nils Breunese
Joseph Kesselman wrote: > Re "IDE droppings"... My experience is that they can actually be useful in > expressing things like preferred code formatting style in > importable/executable form. (I'd rather have a standard cross-editor way if > representing that, but I don't know of one.) You co

Re: Feedback sought

2023-10-14 Thread Mark Derricutt
Tangential topic - a while ago there was a thread/discussion about adopting something like spotless/palantir-java-format for automated formatting. Whilst a massive change to the code base, which can (potentially) cause horrors for open branches/PRs unless rebased with care and also reformatte

Re: Feedback sought

2023-10-14 Thread Joseph Kesselman
ounds fans: / https://www.amazon.com/dp/B09WJ3H657/ () Plaintext Ribbon Campaign /\ Stamp out HTML mail! From: Joseph Kesselman Sent: Sunday, October 15, 2023 12:48:38 AM To: Maven Users List Subject: Re: Feedback sought Don't worry, we recognized your intent.

Re: Feedback sought

2023-10-14 Thread Joseph Kesselman
ounds fans: / https://www.amazon.com/dp/B09WJ3H657/ () Plaintext Ribbon Campaign /\ Stamp out HTML mail! From: Alexander Kriegisch Sent: Saturday, October 14, 2023 11:40:52 PM To: users@maven.apache.org Subject: Re: Feedback sought Alexander Kriegisch schrieb

Re: Feedback sought

2023-10-14 Thread Alexander Kriegisch
Alexander Kriegisch schrieb am 15.10.2023 10:36 (GMT +07:00): > -- Let us abuse reviews as a tool to micro-manage the contributor to OMG, of course I meant "let us NOT abuse". > change what we would have done differently, until it looks exactly > like a change we w

Re: Feedback sought

2023-10-14 Thread Alexander Kriegisch
I have not even looked at the changeset yet, since last time I tried to help with the taglet problem in the javadoc plugin. I was just following the conversation a bit and want to drop a few general comments about contributions and reviews in the OSS world: If any of us ends up in the role of a re

Re: Feedback sought

2023-10-14 Thread Greg Chabala
On Sat, Oct 14, 2023 at 9:15 PM Joseph Kesselman wrote: > Taking out the META-INF: I'll look at that. ... quibbles like editor > configurations and unnecessary files can be cleaned up in subsequent edits; > they shouldn't be considered blockers now. > Sure. Just an opportunity to remove files an

Re: Feedback sought

2023-10-14 Thread Joseph Kesselman
_ From: Greg Chabala Sent: Saturday, October 14, 2023 1:50:16 PM To: Maven Users List Subject: Re: Feedback sought That's certainly an ambitious changeset, but it takes courage to do great work. I'd generally suggest trying to make smaller steps so it's easier on review

Re: Feedback sought

2023-10-14 Thread Joseph Kesselman
___ From: Greg Chabala Sent: Saturday, October 14, 2023 1:50:16 PM To: Maven Users List Subject: Re: Feedback sought That's certainly an ambitious changeset, but it takes courage to do great work. I'd generally suggest trying to make smaller steps so it's easier on rev

Re: Feedback sought

2023-10-14 Thread Joseph Kesselman
ps://www.amazon.com/dp/B09WJ3H657/ () Plaintext Ribbon Campaign /\ Stamp out HTML mail! From: Greg Chabala Sent: Saturday, October 14, 2023 1:50:16 PM To: Maven Users List Subject: Re: Feedback sought That's certainly an ambitious changeset, but it takes cou

Re: Feedback sought

2023-10-14 Thread Greg Chabala
That's certainly an ambitious changeset, but it takes courage to do great work. I'd generally suggest trying to make smaller steps so it's easier on reviewers. For instance: - Could you make a basic Maven build that delegated most of the work to Ant with maven-antrun-plugin? - If so, th

Feedback sought

2023-10-14 Thread Joseph Kessselman
I've just issued a pull request proposing that the Apache Xalan-Java project cut over from Ant-based to Maven-based build. This is the first time I'm working with Maven, and I'm *sure* I have done things that are bad form. If anyone has time and energy to glance at it and sanity-check that I h