Re: m2] OT checkstyle verse Jalopy sun standards checks...

2007-07-12 Thread Dennis Lundberg
Mick Knutson wrote: It sounds like I should just get Jalopy to follow Checkstyle though Right? On 7/11/07, Dennis Lundberg <[EMAIL PROTECTED]> wrote: The "sun_checks.xml" provided by Checkstyle actually goes further than the Sun Coding Conventions. It also has rules from the Java Languag

Re: m2] OT checkstyle verse Jalopy sun standards checks...

2007-07-12 Thread Dennis Lundberg
Yes, that's what I would do. The extra (non-sun code convetions) checks that Checkstyle has are good, so following them is something that should be encouraged. It would be nice if someone could contribute a jalopy configuration file, to the Jalopy project, that matches Checkstyle's rules. Mi

Re: m2] OT checkstyle verse Jalopy sun standards checks...

2007-07-11 Thread Mick Knutson
It sounds like I should just get Jalopy to follow Checkstyle though Right? On 7/11/07, Dennis Lundberg <[EMAIL PROTECTED]> wrote: The "sun_checks.xml" provided by Checkstyle actually goes further than the Sun Coding Conventions. It also has rules from the Java Language Specification and s

Re: m2] OT checkstyle verse Jalopy sun standards checks...

2007-07-11 Thread Mick Knutson
org.codehaus.mojo jalopy-maven-plugin 1.0-SNAPSHOT jalopy.xml true org.delta.esp-dap.utilities.

Re: m2] OT checkstyle verse Jalopy sun standards checks...

2007-07-11 Thread Nathan Maves
you got way further then me with Jalopy. I was not able to get it to work with maven2. Could you post how you got the jalopy plugin to work? On 7/11/07, Mick Knutson <[EMAIL PROTECTED]> wrote: Has anyone modified the jalopy.xml to match checkstyle then? I can seem to get it right. THe mostly

Re: m2] OT checkstyle verse Jalopy sun standards checks...

2007-07-11 Thread Mick Knutson
Has anyone modified the jalopy.xml to match checkstyle then? I can seem to get it right. THe mostly the braces are not right. On 7/11/07, Dennis Lundberg <[EMAIL PROTECTED]> wrote: The "sun_checks.xml" provided by Checkstyle actually goes further than the Sun Coding Conventions. It also has r

Re: m2] OT checkstyle verse Jalopy sun standards checks...

2007-07-11 Thread Dennis Lundberg
The "sun_checks.xml" provided by Checkstyle actually goes further than the Sun Coding Conventions. It also has rules from the Java Language Specification and some general best practices. I pointed this out to the Checkstyle team earlier and suggested that they would separate these. Mick Knutso

m2] OT checkstyle verse Jalopy sun standards checks...

2007-07-11 Thread Mick Knutson
I just got maven jalopy working, and I got a jalopy.xml of the standard sun standards. I formatted all my code but then checkstyle went from 40 errors to >700 errors. Many of which are related to braces. '(' is followed by whitespace.238[image: error]')' is preceded with whitespace.238[image: e