Re: IoFilter mark() usage, between 2.0 and 2.1

2019-05-04 Thread Emmanuel Lécharny
On 04/05/2019 05:40, David Trott wrote: Hey Jonathan, I am transitively importing version 2.0.19 of mina-core through the sshd-core dependency (as I don't think it is safe to upgrade mina-core to 2.1 as I am using the sshd project). I started with the 2.1 version of the SshFilter as a templat

Re: IoFilter mark() usage, between 2.0 and 2.1

2019-05-03 Thread David Trott
Hey Jonathan, I am transitively importing version 2.0.19 of mina-core through the sshd-core dependency (as I don't think it is safe to upgrade mina-core to 2.1 as I am using the sshd project). I started with the 2.1 version of the SshFilter as a template for the filter I am working on, as such it

Re: IoFilter mark() usage, between 2.0 and 2.1

2019-05-03 Thread Jonathan Valliere
David, The `buf.mark()` and `buf.reset()` calls are dangerous when used in conjunction with a dynamic call stack and are being removed from the MINA Filter system to improve compatibility with the code you write. 1> Some things aren't being back-ported to 2.0.X, the SSL improvements are one. 2> W

IoFilter mark() usage, between 2.0 and 2.1

2019-05-03 Thread David Trott
Hey, I am working on an IoFilter similar in location/function to the SslFilter (but implementing a different protocol). I noted there was a delta between 2.0 and 2.1 code in the SslFilter. Specifically commit 2d08d530961597b9f21dff861725f08e73fb9291 Has removed the call to buf.mark(); //