Re: Issues using View Pooling - ViewScope is missing for static structure views?

2015-03-26 Thread Chris Kulinski
Thanks Leonardo! We confirmed that both your fixes resolved the issues we reported.   We can set oamEnableViewPool="false" on specific views and also we're no longer seeing issues with ViewScope beans in static structure views.  Thanks for the quick resolution to the defects. We've uncovered an

Re: Issues using View Pooling - ViewScope is missing for static structure views?

2015-03-25 Thread Leonardo Uribe
Hi I was able to reproduce the problem. Thanks for the log, it helped a lot to understand what's going on. It looks like the call to restoreState was overriding view scope, so the fix done was add some lines to check that case and avoid it. I added some junit tests and on the way I fixed a small i

Re: Issues using View Pooling - ViewScope is missing for static structure views?

2015-03-24 Thread Chris Kulinski
Leonardo - Thanks for the research and updated cases on the patch. We'll apply your recent changes to our testing and try again. Unfortunately, the additional fixes for this defect didn't fix our other defect with missing View Scope.  I'll create a new issue in the issue tracker to watch this. W

Re: Issues using View Pooling - ViewScope is missing for static structure views?

2015-03-23 Thread Leonardo Uribe
Hi Thanks for your kind words about the view pooling algorithm :-). It looks there are two issues here. - Add null check on pushPartialView(...) : The solution is correct, I'll commit it soon. - View scope not restored correctly on static structure views : I have not been able to reproduce the

Issues using View Pooling - ViewScope is missing for static structure views?

2015-03-22 Thread Chris Kulinski
We're testing the View Pooling features of MyFaces 2.2.x on a large pre-existing JSF site with very complex and heavy views with lots of composite components.   The performance improvement is frankly amazing - we've gone from GC events every few seconds under heavy load to virtually no GC events