Re: Thinking about Jewel Forms refactor

2020-09-09 Thread Carlos Rovira
Hi Right, I know this is normal :). Just saying that is just what I want to avoid for things already in place. At least my objective is to reach 1.0 with the current set working as expected, or IOW, that will be enough consistent and will not cause current users to change their code because APIs

Re: Thinking about Jewel Forms refactor

2020-09-09 Thread Piotr Zarzycki
Carlos, Having working that way is a loong journey. You cannot expect that Royale application which is in production and using beta version of framework - will wait with features to have improvement to component. - There is much more custom extensions which we have made to move forward, cause

Re: Thinking about Jewel Forms refactor

2020-09-09 Thread Carlos Rovira
Ok, that's what I want to avoid, having unofficial extensions for something that we should provide out of the box. We need to provide the flexibility to do all that kind of layouts and then users could extend from that to adapt to some particular less generalistic use cases, but the components

Re: Thinking about Jewel Forms refactor

2020-09-09 Thread Piotr Zarzycki
What's more Hugo is using my extension as well - cause he expressed need of that - I have send him off the list that one. I'm not the only person who uses in their app stacked Form. śr., 9 wrz 2020 o 09:45 Piotr Zarzycki napisał(a): > Yes I have more extension of current Form - I didn't commit

Re: Thinking about Jewel Forms refactor

2020-09-09 Thread Piotr Zarzycki
Yes I have more extension of current Form - I didn't commit this to Royale in the results of our discussion a while ago. I have made significant changes to FormView to improve it and created stacked form layout. Anyway go ahead and do whatever you think - let me know and I will apply your changes

Re: Thinking about Jewel Forms refactor

2020-09-09 Thread Carlos Rovira
Hi Piotr, don't understand all you said. You mean you have a stacked form layout now? that maybe is because you created your own extensions? I think the objective here should be to work on a final implementation that makes the Form/FormItem components behave in the most general way while it's

Re: Thinking about Jewel Forms refactor

2020-09-09 Thread Piotr Zarzycki
Carlos, If you won't do stacked in the first shot - I won't use it - We have a lot of stacked stuff in our app. Without it it will just fail and apart of changing code I will have to change more.. Sure if I have time I will help, but I cannot promise I will get time for this from company.

Re: Thinking about Jewel Forms refactor

2020-09-09 Thread Carlos Rovira
Hi Piotr, (sending this to both user and dev since it affects to current users and we're discussing how to work on it) I prefer your approach to work in a branch over the current Form code, when finished it will require as well do some changes in final user code so in the end changes should be

Re: Thinking about Jewel Forms refactor

2020-09-09 Thread Piotr Zarzycki
Hi Carlos, If you think about changing name of the current component to FormDPCT and write new one with old name - I prefer if you do just the opposite. Name your new component in some way - once you will be ready - we will test it and decide how it's working. IMO it should be done on the branch