Re: MultipleAdditiveTreeModel

2021-08-03 Thread Spyros Kapnissis
Thank you Alessandro! I also created a PR with a test case for the issue and a potential fix, thanks! On Tue, Aug 3, 2021 at 1:27 PM Alessandro Benedetti wrote: > thank you, Spyros! > I take it from there. > > Cheers > -- > Alessandro Benedetti > Apache Lucene/Solr Commit

Re: MultipleAdditiveTreeModel

2021-08-03 Thread Alessandro Benedetti
thank you, Spyros! I take it from there. Cheers -- Alessandro Benedetti Apache Lucene/Solr Committer Director, R&D Software Engineer, Search Consultant www.sease.io On Wed, 28 Jul 2021 at 21:00, Spyros Kapnissis wrote: > Hi Alessandro, Roopa, I created the ticket here:

Re: MultipleAdditiveTreeModel

2021-07-28 Thread Roopa Rao
Thank you, Spyros. Roopa On Wed, Jul 28, 2021 at 3:00 PM Spyros Kapnissis wrote: > Hi Alessandro, Roopa, I created the ticket here: > https://issues.apache.org/jira/browse/SOLR-15569 . I don't think I have > permission to add people though, so please tag whomever you feel is > necessary. > Pls

Re: MultipleAdditiveTreeModel

2021-07-28 Thread Spyros Kapnissis
Hi Alessandro, Roopa, I created the ticket here: https://issues.apache.org/jira/browse/SOLR-15569 . I don't think I have permission to add people though, so please tag whomever you feel is necessary. Pls let me know if you need any more info, thanks! On Tue, Jul 27, 2021 at 1:00 PM Alessandro Bene

Re: MultipleAdditiveTreeModel

2021-07-27 Thread Alessandro Benedetti
Hi Spyros, Roopa, if you can create the Jira ticket with all the details you gathered, that would be much appreciated. If you tag me, Christine Poerschke, and Diego Ceccarelli at least, we'll take over from there! Thanks! -- Alessandro Benedetti Apache Lucene/Solr Committer

Re: MultipleAdditiveTreeModel

2021-07-26 Thread Spyros Kapnissis
Hi Alessandro, Roopa, I also agree that this issue should be further investigated and fixed. Please let me know if you need any help opening the Jira ticket and provide more details. On Mon, Jul 26, 2021, 21:04 Roopa Rao wrote: > Hi Alessandro, > I haven't created JIRA for this, we solved this t

Re: MultipleAdditiveTreeModel

2021-07-26 Thread Roopa Rao
Hi Alessandro, I haven't created JIRA for this, we solved this the similar way that Spyros described, by changing the threshold in the model. Ya it would be good to understand why there is the SLACK added. Thanks, Roopa On Mon, Jul 26, 2021 at 10:52 AM Alessandro Benedetti wrote: > I didn't get

Re: MultipleAdditiveTreeModel

2021-07-26 Thread Alessandro Benedetti
I didn't get any additional notification (or maybe I missed it). Has the Jira been created yet? Boolean features are quite common around Learning To Rank use cases. I do believe this contribution can be useful. If you don't have time to create the Jira or contribute the pull request, no worries, ju

Re: MultipleAdditiveTreeModel

2021-07-16 Thread Roopa Rao
Spyros, thank you for verifying this, we are planning to do something similar. Thanks, Roopa On Fri, Jul 16, 2021 at 12:09 PM Spyros Kapnissis wrote: > Hello, > > Just to verify this, we had come across the exact same issue when > converting an XGBoost model to MUltipleAdditiveTrees. This was a

Re: MultipleAdditiveTreeModel

2021-07-16 Thread Spyros Kapnissis
Hello, Just to verify this, we had come across the exact same issue when converting an XGBoost model to MUltipleAdditiveTrees. This was an issue specifically with the categorical features that take on integer values. We ended up subtracting 0.5 from the threshold value on any such split point on t

Re: MultipleAdditiveTreeModel

2021-07-16 Thread Roopa Rao
Okay, thank you for the input Roopa On Fri, Jul 16, 2021 at 5:55 AM Alessandro Benedetti wrote: > Hi Roopa, > I was not able to find why that slack was added. > I am not sure why we would like to change the threshold. > I would recommend creating a Jira issue and tag at least myself, Christine

Re: MultipleAdditiveTreeModel

2021-07-16 Thread Alessandro Benedetti
Hi Roopa, I was not able to find why that slack was added. I am not sure why we would like to change the threshold. I would recommend creating a Jira issue and tag at least myself, Christine Poerschke and Diego Ceccarelli, so we can discuss and potentially open a pull request. Cheers ---