Henrik,
thanks a lot, can confirm your fix works in my tests :-)
Cheers
tobi
Am 28.11.19 um 11:09 schrieb Henrik K:
>
> Fixed:
> http://svn.apache.org/viewvc?view=revision=1870552
>
> On Thu, Nov 28, 2019 at 11:29:19AM +0200, Henrik K wrote:
>>
>> Trunk has already many revamps and fixes for
I never would have found that. Nice job.
Any chance you can create a regression test for the issue ?
On Thu, Nov 28, 2019, 05:09 Henrik K wrote:
>
> Fixed:
> http://svn.apache.org/viewvc?view=revision=1870552
>
> On Thu, Nov 28, 2019 at 11:29:19AM +0200, Henrik K wrote:
> >
> > Trunk has
Fixed:
http://svn.apache.org/viewvc?view=revision=1870552
On Thu, Nov 28, 2019 at 11:29:19AM +0200, Henrik K wrote:
>
> Trunk has already many revamps and fixes for these codes, works there. It
> seems 3.4 askdns has trouble using those, investigating minimal fix..
>
>
> On Thu, Nov 28,
Trunk has already many revamps and fixes for these codes, works there. It
seems 3.4 askdns has trouble using those, investigating minimal fix..
On Thu, Nov 28, 2019 at 10:20:39AM +0100, Tobi wrote:
> Henrik
>
> But my current testing clearly shows that without the explicit set_tag
>
Henrik
But my current testing clearly shows that without the explicit set_tag
_LASTEXTERNALRDNS_ and _LASTEXTERNALHELO_ won't be set.
I'm testing this using spamassassin in debug mode to scan a testmessage.
As soon as I re-add the set_tag to PerMsgStatus.pm the tags are set and
tests based on
There is nothing missing. All the LASTEXT* tags are already dynamically
returning functions. If anything, that if ($lasthop) set_tag code is
completely redundant and should be removed.
BEGIN {
LASTEXTERNALIP => sub {
my $pms = shift;
my $lasthop =
On Wed, 27 Nov 2019 12:59:47 +0100
Tobi wrote:
> Hi,
>
> is there any specific reason why the two tags mentioned in subject are
> not set in SA? It took me a while to find out why an askdns test was
> not running. The test relies on _LASTEXTERNALRDNS_ but after running
> with --debug I found
On Wed, 27 Nov 2019 17:00:26 +0100
Tobi wrote:
>
> Issue could occur if trusted/internal networks is not set properly and
> the message contains a non-smtp received header with a public IP. Like
> for example could occur if the message is sent via lmtp. Then the
> received header does not
Hi Kevin
sorry for sending offlist the first time :-)
> Have you been using that change in production?
Yes I changed it in my prod perl file today. Works so far for the last
couple of hours.
Issue could occur if trusted/internal networks is not set properly and
the message contains a non-smtp
After a 10 minute or so study of the issue and comparing 3.4 and trunk,
it definitely looks like the code is missing. I am not 100% sure your
fix works but it's better than it currently exists :-)
Have you been using that change in production?
Regards,
KAM
On 11/27/2019 6:59 AM, Tobi wrote:
Hi,
is there any specific reason why the two tags mentioned in subject are
not set in SA? It took me a while to find out why an askdns test was not
running. The test relies on _LASTEXTERNALRDNS_ but after running with
--debug I found that those tags are not set by SA. Although
_LASTEXTERNALIP_ is
11 matches
Mail list logo
