sebb wrote on Thu, 13 May 2021 14:46 +00:00:
> On Thu, 13 May 2021 at 15:03, Daniel Shahaf wrote:
> >
> > sebb wrote on Wed, May 12, 2021 at 10:47:15 +0100:
> > > It looks like svnwcsub.py is not always able to update the workspace
> >
> > Don't use made-up terminology. The terms "repository"
On Thu, 13 May 2021 at 15:03, Daniel Shahaf wrote:
>
> sebb wrote on Wed, May 12, 2021 at 10:47:15 +0100:
> > It looks like svnwcsub.py is not always able to update the workspace
>
> Don't use made-up terminology. The terms "repository" and "working
> copy" have specific meanings. Use those
Furthermore, the method does not actually return a URL.
The method behaves like the following:
https://python.readthedocs.io/en/v2.7.2/library/urllib2.html#urllib2.urlopen
On Thu, 13 May 2021 at 15:16, sebb wrote:
>
> The problem is that it is not clear whether the variable is supposed
> to be
sebb wrote on Wed, May 12, 2021 at 12:25:26 +0100:
> pylint reports quite a few warnings and errors:
>
> svnwcsub.py:55:0: W0311: Bad indentation. Found 2 spaces, expected 4
> (bad-indentation)
Don't hard-wrap program output in your emails.
> svnwcsub.py:57:0: W0311: Bad indentation. Found 2
The problem is that it is not clear whether the variable is supposed
to be used or not.
Is it misspelt?
AIUI the convention for intentionally unused variables is to prefix
the name with an underscore, as this no longer triggers the warning in
PyLint
On Thu, 13 May 2021 at 15:11, Daniel Shahaf
sebb wrote on Wed, May 12, 2021 at 11:49:41 +0100:
> As the subject says
Assuming opener.open() actually returns a URL, I don't see the problem
here. The variable documents the return type for anyone who may want
to extend the function.
sebb wrote on Wed, May 12, 2021 at 11:48:17 +0100:
> As the subject says.
+1 to commit, but the log message should follow the house style, for
example:
[[[
* tools/server-side/svnpubsub/watcher.py
(urlparse): Remove unused import.
Approved by: danielsh
]]]
sebb wrote on Wed, May 12, 2021 at 10:47:15 +0100:
> It looks like svnwcsub.py is not always able to update the workspace
Don't use made-up terminology. The terms "repository" and "working
copy" have specific meanings. Use those terms to refer to what they
mean. Don't use those terms to mean
sebb wrote on Tue, May 11, 2021 at 22:41:38 +0100:
> On Tue, 11 May 2021 at 19:33, Daniel Shahaf wrote:
> >
> > sebb wrote on Tue, 11 May 2021 16:25 +00:00:
> > > As the subject says, the code crashes as below unless --pidfile is
> > > provided
> > >
> > > File "./svnwcsub.py", line 559, in
>
