Bug report -- space in env. var. VISUAL causes commits to fail (needs confirmation)

2010-12-06 Thread David Dyer-Bennet
Subversion 1.6.12 running on Centos 5.5 If the value of the environment variable VISUAL contains a space, subversion fails when attempting to invoke the editor to get the comment. sh-3.2$ export VISUAL="/home/spaces in name/bin/emacs" sh-3.2$ svn commit sh: /home/spaces: No such file or directory

Re: Bug report -- space in env. var. VISUAL causes commits to fail (needs confirmation)

2010-12-06 Thread Daniel Näslund
On Mon, Dec 06, 2010 at 01:44:23PM -0600, David Dyer-Bennet wrote: > Subversion 1.6.12 running on Centos 5.5 > > If the value of the environment variable VISUAL contains a space, > subversion fails when attempting to invoke the editor to get the > comment. > > sh-3.2$ export VISUAL="/home/spaces

Re: Bug report -- space in env. var. VISUAL causes commits to fail (needs confirmation)

2010-12-07 Thread Daniel Shahaf
CC += dev@ Daniel Näslund wrote on Mon, Dec 06, 2010 at 21:32:39 +0100: > On Mon, Dec 06, 2010 at 01:44:23PM -0600, David Dyer-Bennet wrote: > > Subversion 1.6.12 running on Centos 5.5 > > > > If the value of the environment variable VISUAL contains a space, > > subversion fails when attempting t

Re: Bug report -- space in env. var. VISUAL causes commits to fail (needs confirmation)

2010-12-07 Thread Julian Foad
On Tue, 2010-12-07, Daniel Shahaf wrote: > CC += dev@ > > Daniel Näslund wrote on Mon, Dec 06, 2010 at 21:32:39 +0100: > > On Mon, Dec 06, 2010 at 01:44:23PM -0600, David Dyer-Bennet wrote: > > > Subversion 1.6.12 running on Centos 5.5 > > > > > > If the value of the environment variable VISUAL c

Re: Bug report -- space in env. var. VISUAL causes commits to fail (needs confirmation)

2010-12-07 Thread David Dyer-Bennet
On Tue, December 7, 2010 04:18, Julian Foad wrote: > On Tue, 2010-12-07, Daniel Shahaf wrote: > I confirmed that there was a bug in that report, but that was on Windows > and the evidence there was that the arguments were not being parsed > correctly even when the space was escaped with the "^" c

Re: Bug report -- space in env. var. VISUAL causes commits to fail (needs confirmation)

2010-12-07 Thread Daniel Shahaf
David Dyer-Bennet wrote on Tue, Dec 07, 2010 at 08:44:28 -0600: > On Tue, December 7, 2010 04:18, Julian Foad wrote: > > On Tue, 2010-12-07, Daniel Shahaf wrote: > >> I suppose setting VISUAL="\"/path with spaces/to/editor/binary\"" is the > >> easiest solution --- it requires no code changes so it

Re: Bug report -- space in env. var. VISUAL causes commits to fail (needs confirmation)

2010-12-07 Thread Peter Samuelson
[David Dyer-Bennet] > >> I suppose setting VISUAL="\"/path with spaces/to/editor/binary\"" is the > >> easiest solution --- it requires no code changes so it will work with > >> any svn binary out there. > > > > Yes, I think that's the best solution. > > And, in any case, VISUAL is a public inter

Re: Bug report -- space in env. var. VISUAL causes commits to fail (needs confirmation)

2010-12-07 Thread David Dyer-Bennet
On Tue, December 7, 2010 09:03, Daniel Shahaf wrote: > David Dyer-Bennet wrote on Tue, Dec 07, 2010 at 08:44:28 -0600: >> On Tue, December 7, 2010 04:18, Julian Foad wrote: >> > On Tue, 2010-12-07, Daniel Shahaf wrote: >> >> I suppose setting VISUAL="\"/path with spaces/to/editor/binary\"" is >> t

Re: Bug report -- space in env. var. VISUAL causes commits to fail (needs confirmation)

2010-12-07 Thread Daniel Shahaf
David Dyer-Bennet wrote on Tue, Dec 07, 2010 at 09:30:45 -0600: > On Tue, December 7, 2010 09:03, Daniel Shahaf wrote: > > David Dyer-Bennet wrote on Tue, Dec 07, 2010 at 08:44:28 -0600: > >> And, in any case, VISUAL is a public interface, and I wonder how many > >> other applications would break i

Re: Bug report -- space in env. var. VISUAL causes commits to fail (needs confirmation)

2010-12-07 Thread Peter Samuelson
[David Dyer-Bennet] > as I said in my initial post, I first discovered this on Windows > under Cygwin. Avoiding "c:/Program Files" and "c:/Documents and > Settings/david.dyer-bennet/My Documents" involves contortions and > leaves you putting things in unusual places. Well, or calling them C:/PRO

Re: Bug report -- space in env. var. VISUAL causes commits to fail (needs confirmation)

2010-12-07 Thread David Dyer-Bennet
On Tue, December 7, 2010 09:58, Daniel Shahaf wrote: > David Dyer-Bennet wrote on Tue, Dec 07, 2010 at 09:30:45 -0600: >> On Tue, December 7, 2010 09:03, Daniel Shahaf wrote: >> > David Dyer-Bennet wrote on Tue, Dec 07, 2010 at 08:44:28 -0600: >> >> And, in any case, VISUAL is a public interface,