Bug report against SVN 1.6.13

2010-10-13 Thread Paul Maier
Hi there! file b should be read-write here; what do you think: Reproduction script: svn --version svnadmin create xx svn co "file:///C:/[...]/xx" yy cd yy echo a > a svn add a svn propset svn:needs-lock "*" a svn ci -m "" svn up svn cp a b ls -lA Observ

Bug report against SVN 1.6.13

2010-10-19 Thread Paul Maier
Hi Daniel, I just ran into something, that might already be fixed with your r1023571, but I think it is worth testing: # 1. setup "file a" as in previous postings: echo a > a svn add a svn propset svn:needs-lock "*" a svn ci -m "" # 2. local modification to file a: echo blah >> a # 3. renam

Bug report against SVN 1.6.13

2010-10-19 Thread Paul Maier
[Sorry, in my previous posting I forgot to mention the svn lock command. Here the corrected version of my posting.] Hi Daniel, I just ran into something, that might already be fixed with your r1023571, but I think it is worth testing: # 1. setup "file a" as in previous postings: echo a > a svn

Re: Bug report against SVN 1.6.13

2010-10-14 Thread Stefan Sperling
On Thu, Oct 14, 2010 at 01:42:36AM +0200, Paul Maier wrote: > Hi there! > > file b should be read-write here; what do you think: > > > Reproduction script: > > svn --version > svnadmin create xx > svn co "file:///C:/[...]/xx" yy > cd yy > echo a > a > svn add a

AW: Bug report against SVN 1.6.13

2010-10-15 Thread Paul Maier
it? What do you think? Paul > -Ursprüngliche Nachricht- > Von: Stefan Sperling [mailto:s...@elego.de] > Gesendet: Donnerstag, 14. Oktober 2010 12:02 > An: Paul Maier > Cc: users@subversion.apache.org > Betreff: Re: Bug report against SVN 1.6.13 > > On Thu

Re: Bug report against SVN 1.6.13

2010-10-16 Thread Stefan Sperling
On Fri, Oct 15, 2010 at 10:13:48PM +0200, Paul Maier wrote: > Hi Stefan! > > Thank you for having responded. > > Of course, after the commit, the file is read-only. > > Sorry. I don't know how to implement this. But it pains me a lot. You'd need to be able to read and write C code. > So I need

Re: Bug report against SVN 1.6.13

2010-10-16 Thread Daniel Shahaf
Stefan Sperling wrote on Sat, Oct 16, 2010 at 15:40:46 +0200: > On Fri, Oct 15, 2010 at 10:13:48PM +0200, Paul Maier wrote: > > svn cp should always make the target file read-write in the > > working copy. > > No. A plain copy should carry file permissions of its source along, > just like a normal

Re: Bug report against SVN 1.6.13

2010-10-16 Thread Daniel Shahaf
Daniel Shahaf wrote on Sun, Oct 17, 2010 at 05:09:37 +0200: > Index: subversion/libsvn_wc/copy.c > === > --- subversion/libsvn_wc/copy.c (revision 1023400) > +++ subversion/libsvn_wc/copy.c (working copy) > @@ -238,6 +238,1

Re: Bug report against SVN 1.6.13

2010-10-17 Thread Stefan Sperling
On Sun, Oct 17, 2010 at 05:24:49AM +0200, Daniel Shahaf wrote: > Daniel Shahaf wrote on Sun, Oct 17, 2010 at 05:09:37 +0200: > > Index: subversion/libsvn_wc/copy.c > > === > > --- subversion/libsvn_wc/copy.c (revision 1023400) > >

Re: Bug report against SVN 1.6.13

2010-10-17 Thread Daniel Shahaf
Stefan Sperling wrote on Sun, Oct 17, 2010 at 14:43:57 +0200: > Your patch seems to handle copies only. What about locally added files? Does this part of the regression patch cover the scenario you have in mind? Index: subversion/tests/cmdline/lock_tests.py ===

Re: Bug report against SVN 1.6.13

2010-10-17 Thread Stefan Sperling
On Sun, Oct 17, 2010 at 04:30:41PM +0200, Daniel Shahaf wrote: > Stefan Sperling wrote on Sun, Oct 17, 2010 at 14:43:57 +0200: > > Your patch seems to handle copies only. What about locally added files? > > Does this part of the regression patch cover the scenario you have in mind? Yup. It does c

Re: Bug report against SVN 1.6.13

2010-10-17 Thread Daniel Shahaf
Stefan Sperling wrote on Sun, Oct 17, 2010 at 20:54:41 +0200: > On Sun, Oct 17, 2010 at 04:30:41PM +0200, Daniel Shahaf wrote: > > Stefan Sperling wrote on Sun, Oct 17, 2010 at 14:43:57 +0200: > > > Your patch seems to handle copies only. What about locally added files? > > > > Does this part of t

Re: Bug report against SVN 1.6.13

2010-10-17 Thread 'Daniel Shahaf'
Paul Maier wrote on Sun, Oct 17, 2010 at 22:30:23 +0200: > Hi Daniel, > > thanks for having taken over this idea. > No problem. > One question: > Does your solution code and testing code also cover the case when the copy > source is a URL? > > svn cp svn://./a b > should also leave file

Re: Bug report against SVN 1.6.13

2010-10-17 Thread 'Daniel Shahaf'
'Daniel Shahaf' wrote on Mon, Oct 18, 2010 at 00:24:13 +0200: > Paul Maier wrote on Sun, Oct 17, 2010 at 22:30:23 +0200: > > svn cp svn://./a b > > should also leave file b as read-write, doesn't it? > > > > Should, but doesn't. > Fixed in r1023647, using the very same approach I originally

Re: Bug report against SVN 1.6.13

2010-10-19 Thread 'Daniel Shahaf'
Paul Maier wrote on Wed, Oct 20, 2010 at 01:55:30 +0200: > [Sorry, in my previous posting I forgot to mention the svn lock command. > Here the corrected version of my posting.] > > Hi Daniel, > > I just ran into something, that might already be fixed with your r1023571, > but I think it is worth