Re: Can SVN pull request same as GIT?

2018-12-04 Thread Branko Čibej
On 04.12.2018 12:12, Branko Čibej wrote: > On 04.12.2018 10:11, 钱海远(Nathan) wrote: >> Will you make any plan on SVN pull request? > No. > > Subversion is a version control tool, not a code review tool. There are > plenty of those available, both open-source and commercial, and some of > them suppor

Re: Can SVN pull request same as GIT?

2018-12-04 Thread Branko Čibej
On 04.12.2018 10:11, 钱海远(Nathan) wrote: > Will you make any plan on SVN pull request? No. Subversion is a version control tool, not a code review tool. There are plenty of those available, both open-source and commercial, and some of them support Subversion for version control. Now if someone w

答复: 答复: Can SVN pull request same as GIT?

2018-12-04 Thread Nathan
e it! -邮件原件- 发件人: Julian Foad [mailto:julianf...@apache.org] 发送时间: 2018年12月3日 16:48 收件人: 钱海远(Nathan); Nico Kadel-Garcia 抄送: Johan Corveleyn; Subversion 主题: Re: 答复: Can SVN pull request same as GIT? 钱海远(Nathan) wrote: > [...] > So we'd like to make a pre-commit CI system, if any

Re: 答复: Can SVN pull request same as GIT?

2018-12-03 Thread Julian Foad
钱海远(Nathan) wrote: > [...] > So we'd like to make a pre-commit CI system, if anyone who want to > commit his code, we will build and test it first , if the CI passed the > build and test , then it can merge to branches. > > We have 2 plan: > > Plan A ( 2015 we had make a linux svn issue plugin

答复: Can SVN pull request same as GIT?

2018-12-02 Thread Nathan
l in error, please notify the sender by phone or email immediately and delete it! -邮件原件- 发件人: Daniel Shahaf [mailto:danie...@apache.org] 发送时间: 2018年12月2日 0:07 收件人: users@subversion.apache.org 抄送: 钱海远(Nathan) 主题: Re: Can SVN pull request same as GIT? Nico Kadel-Garcia wrote on Sat, 01

答复: Can SVN pull request same as GIT?

2018-12-02 Thread Nathan
ohan Corveleyn; Subversion 主题: Re: Can SVN pull request same as GIT? Nico Kadel-Garcia wrote: > On Thu, Nov 29, 2018 at 10:31 PM 钱海远(Nathan) > wrote: >> We want to develop a feature like git pull request . >> [...] > > This seems infeasible. The working copy in which the m

Re: Can SVN pull request same as GIT?

2018-12-01 Thread Daniel Shahaf
Nico Kadel-Garcia wrote on Sat, 01 Dec 2018 09:25 -0500: > On Sat, Dec 1, 2018 at 4:00 AM Stefan Sperling wrote: > > Note that we use such a workflow in SVN itself: When we backport changes > > to stable branches and a merge conflict occurs, we prepare a branch. > > Voting happens in a file called

Re: Can SVN pull request same as GIT?

2018-12-01 Thread Nico Kadel-Garcia
On Sat, Dec 1, 2018 at 4:00 AM Stefan Sperling wrote: > > On Fri, Nov 30, 2018 at 07:19:06PM -0500, Nico Kadel-Garcia wrote: > > git pull requests perform a merge in the local repository. What you'd > > need to create for this is a local repository, not a working copy, and > > the working reposito

Re: Can SVN pull request same as GIT?

2018-12-01 Thread Julian Foad
Stefan Sperling wrote: >Sorry Nico, I don't see your point at all. […] >So regarding what Nathan is actually asking about: […] I guess that Nico understands Subversion but maybe confused "pull request" with the "git pull" command. As for the rest, until Nathan clarifies his needs, we're all specu

Re: Can SVN pull request same as GIT?

2018-12-01 Thread Branko Čibej
On 01.12.2018 10:00, Stefan Sperling wrote: > So I fully agree with Brane; SVN provides all the tooling required, and > people building code review tools just have to make clever use of it. Just to be clear: my issue is not whether SVN provides the tooling, but with this conflation of "feature" an

Re: Can SVN pull request same as GIT?

2018-12-01 Thread Stefan Sperling
On Fri, Nov 30, 2018 at 07:19:06PM -0500, Nico Kadel-Garcia wrote: > git pull requests perform a merge in the local repository. What you'd > need to create for this is a local repository, not a working copy, and > the working repository becomes part of a distributed source control > system. Those a

Re: Can SVN pull request same as GIT?

2018-12-01 Thread Branko Čibej
On 01.12.2018 01:19, Nico Kadel-Garcia wrote: > On Fri, Nov 30, 2018 at 8:20 AM Julian Foad wrote: >> Nico Kadel-Garcia wrote: >>> On Thu, Nov 29, 2018 at 10:31 PM 钱海远(Nathan) >>> wrote: We want to develop a feature like git pull request . [...] >>> This seems infeasible. The working

Re: Can SVN pull request same as GIT?

2018-12-01 Thread Branko Čibej
On 30.11.2018 21:39, Nathan Hartman wrote: > On Fri, Nov 30, 2018 at 4:56 AM Julian Foad wrote: > >> 钱海远(Nathan) wrote: >>> We want to develop a feature like git pull request . >> Some other companies are also interested in developing the same. >> >> There are a few different possible directions.

Re: Can SVN pull request same as GIT?

2018-11-30 Thread Nico Kadel-Garcia
On Fri, Nov 30, 2018 at 8:20 AM Julian Foad wrote: > > Nico Kadel-Garcia wrote: > > On Thu, Nov 29, 2018 at 10:31 PM 钱海远(Nathan) > > wrote: > >> We want to develop a feature like git pull request . > >> [...] > > > > This seems infeasible. The working copy in which the merges would occur > > d

Re: Can SVN pull request same as GIT?

2018-11-30 Thread Nathan Hartman
On Fri, Nov 30, 2018 at 4:56 AM Julian Foad wrote: > 钱海远(Nathan) wrote: > > We want to develop a feature like git pull request . > > Some other companies are also interested in developing the same. > > There are a few different possible directions. > > You could implement pull requests (PR) using

Re: Can SVN pull request same as GIT?

2018-11-30 Thread Julian Foad
Nico Kadel-Garcia wrote: > On Thu, Nov 29, 2018 at 10:31 PM 钱海远(Nathan) > wrote: >> We want to develop a feature like git pull request . >> [...] > >  This seems infeasible. The working copy in which the merges would occur does > not exist in the Subversion workflow. Hello Nico! What do you m

Re: Can SVN pull request same as GIT?

2018-11-30 Thread Nico Kadel-Garcia
On Thu, Nov 29, 2018 at 10:31 PM 钱海远(Nathan) wrote: > Dear Sir, > > > > We want to develop a feature like git pull request . > > > > But it is not easy to develop. Svn has only one server , how to store the > patches? If build failed , how to revert working copy. How to resolve the > conflict. >

Re: Can SVN pull request same as GIT?

2018-11-30 Thread Julian Foad
钱海远(Nathan) wrote: > We want to develop a feature like git pull request . > > But it is not easy to develop. Svn has only one server , how to store the > patches? > If build failed , how to revert working copy. How to resolve the conflict. > > Git is a better , it can support pre-commit code rev

Can SVN pull request same as GIT?

2018-11-29 Thread Nathan
Dear Sir, We want to develop a feature like git pull request . But it is not easy to develop. Svn has only one server , how to store the patches? If build failed , how to revert working copy. How to resolve the conflict. Git is a better , it can support pre-commit code review, pull request by