Re: best way to patch tapestry?

2012-02-22 Thread Thiago H. de Paula Figueiredo
On Tue, 21 Feb 2012 20:15:52 -0200, Chris Mylonas ch...@opencsta.org wrote: Hi Thiago Hi! __With respect__, and I don't know the innards of Tapestry-IoC so well or the problems some of you have - Do you do this and it works, or is it more this-is-how-it-should-be-done-but-YMMV? It

Re: best way to patch tapestry?

2012-02-22 Thread Thiago H. de Paula Figueiredo
On Tue, 21 Feb 2012 22:55:30 -0200, Paul Stanton p...@mapshed.com.au wrote: Hi Thiago, Hi, Paul! I'd love to not have to patch but how can I override the DateField component (java js) via tapestry-ioc? Decorate or advise or override ComponentClassResolver so its

Re: best way to patch tapestry?

2012-02-22 Thread Paul Stanton
Thanks Thiago, I managed it by decorating ComponentInstantiatorSource and overriding DateFieldStack. No patched jar required now! On 22/02/2012 8:50 PM, Thiago H. de Paula Figueiredo wrote: On Tue, 21 Feb 2012 22:55:30 -0200, Paul Stanton p...@mapshed.com.au wrote: Hi Thiago, Hi, Paul!

Re: best way to patch tapestry?

2012-02-22 Thread Steve Eynon
Cool, I'll try this myself - for I'm also source patching the same DateField bug (TAP5-841) in multiple projects. It just hadn't annoyed me enough to look for a solution! I also like the idea of a 302 for mis-versioned assets - nice thinking! Steve. --- If at first

Re: best way to patch tapestry?

2012-02-21 Thread Thiago H. de Paula Figueiredo
On Mon, 20 Feb 2012 20:47:15 -0200, Paul Stanton p...@mapshed.com.au wrote: Hi All, Hi! Don't patch: find the service that contains the logic you want to change and override it through Tapestry-IoC. -- Thiago H. de Paula Figueiredo Independent Java, Apache Tapestry 5 and Hibernate

Re: best way to patch tapestry?

2012-02-21 Thread Chris Mylonas
Hi Thiago __With respect__, and I don't know the innards of Tapestry-IoC so well or the problems some of you have - Do you do this and it works, or is it more this-is-how-it-should-be-done-but-YMMV? It sounds like the way to go. here's the page for anyone to follow up

Re: best way to patch tapestry?

2012-02-21 Thread Paul Stanton
Hi Thiago, I'd love to not have to patch but how can I override the DateField component (java js) via tapestry-ioc? I am aware that I could write a new component, DateField2 for example, however this would require more code to change in many sub-projects. If I cannot replace the

Re: best way to patch tapestry?

2012-02-21 Thread Jonathan Barker
Perhaps the tapestry5-jquery project can give you some ideas. It overrides the DateField component. On Tue, Feb 21, 2012 at 7:55 PM, Paul Stanton p...@mapshed.com.au wrote: Hi Thiago, I'd love to not have to patch but how can I override the DateField component (java js) via tapestry-ioc?

Re: best way to patch tapestry?

2012-02-21 Thread Paul Stanton
From what I can tell, it overrides the DateFieldStack, and the javascript used - not the component class its self... am i wrong? On 22/02/2012 3:03 PM, Jonathan Barker wrote: Perhaps the tapestry5-jquery project can give you some ideas. It overrides the DateField component. On Tue, Feb 21,

best way to patch tapestry?

2012-02-20 Thread Paul Stanton
Hi All, Like many of you, I've had to create a couple of local patches to get certain things in tapestry working correctly. For example, a fix for the DateField component (https://issues.apache.org/jira/browse/TAP5-841) and a custom AssetDispatcher to perform a 302 redirect instead of

Re: best way to patch tapestry?

2012-02-20 Thread Chris Mylonas
Hi Paul, I have multiple tapestry projects which all need to have the patches applied, and so far the only reliable method I can find is to include them in each projects source tree. I am finding it difficult to ensure that the patch is applied when it is contained in its own jar since

Re: best way to patch tapestry?

2012-02-20 Thread Kalle Korhonen
On Mon, Feb 20, 2012 at 2:47 PM, Paul Stanton p...@mapshed.com.au wrote: I have multiple tapestry projects which all need to have the patches applied, and so far the only reliable method I can find is to include them in each projects source tree. I am finding it difficult to ensure that the

Re: best way to patch tapestry?

2012-02-20 Thread Paul Stanton
Kalle, I hadn't thought of the version bit .. I think that sounds good. I will try to get that working. One problem is that (while I know I should) I haven't had the time to create our own internal maven repository yet. We currently include a bunch of jars via scopesystem ... ugly, I know