Re: [External] Re: Supporting Proxy Protocol in Tomcat

2023-11-27 Thread Jonathan S. Fisher
n 28/08/2023 18:44, Amit Pande wrote: > > >>> Oh, sure. So, what would be the best way to get some conclusion on this > > >> thread? > > >> > > >> Provide a patch for review based on the feedback provided here and in > > >> the BZ issue. &

Re: [External] Re: Supporting Proxy Protocol in Tomcat

2023-11-21 Thread Adwait Kumar Singh
; Subject: Re: [External] Re: Supporting Proxy Protocol in Tomcat > >>> > >>> > >>> CAUTION: This email originated from outside the organization. Do not > >> click links or open attachments unless you recognize the sender and know > >> the content is safe. If you believe

Re: [External] Re: Supporting Proxy Protocol in Tomcat

2023-09-05 Thread Mark Thomas
11:20 AM To: Tomcat Users List Subject: Re: [External] Re: Supporting Proxy Protocol in Tomcat CAUTION: This email originated from outside the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe. If you believe this is a phishing e

Re: [External] Re: Supporting Proxy Protocol in Tomcat

2023-09-05 Thread Christopher Schultz
ark Thomas Sent: Monday, August 28, 2023 11:20 AM To: Tomcat Users List Subject: Re: [External] Re: Supporting Proxy Protocol in Tomcat CAUTION: This email originated from outside the organization. Do not click links or open attachments unless you recognize the sender and know the content is

RE: [External] Re: Supporting Proxy Protocol in Tomcat

2023-09-05 Thread Amit Pande
To: Tomcat Users List Subject: Re: [External] Re: Supporting Proxy Protocol in Tomcat CAUTION: This email originated from outside the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe. If you believe this is a phishing email, use

Re: [External] Re: Supporting Proxy Protocol in Tomcat

2023-09-04 Thread Jonathan S. Fisher
to help > you progress your patch. > > Mark > > > > > > Thanks, > > Amit > > > > -Original Message- > > From: Mark Thomas > > Sent: Monday, August 28, 2023 11:20 AM > > To: Tomcat Users List > > Subject: Re: [External] Re:

Re: [External] Re: Supporting Proxy Protocol in Tomcat

2023-08-29 Thread Mark Thomas
List Subject: Re: [External] Re: Supporting Proxy Protocol in Tomcat CAUTION: This email originated from outside the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe. If you believe this is a phishing email, use the Report

RE: [External] Re: Supporting Proxy Protocol in Tomcat

2023-08-28 Thread Amit Pande
Thomas Sent: Monday, August 28, 2023 11:20 AM To: Tomcat Users List Subject: Re: [External] Re: Supporting Proxy Protocol in Tomcat CAUTION: This email originated from outside the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe

Re: [External] Re: Supporting Proxy Protocol in Tomcat

2023-08-28 Thread Mark Thomas
:29 AM To: Tomcat Users List Subject: RE: [External] Re: Supporting Proxy Protocol in Tomcat Yes, understood. Thank you for clarifying. Even I was referring to initial consensus without any timeline or approach conclusion. Thanks, Amit -Original Message- From: Mark Thomas Sent: Friday

RE: [External] Re: Supporting Proxy Protocol in Tomcat

2023-08-28 Thread Amit Pande
Mark, Just checking - Did this issue get discussed in any of the core members' meeting? Thanks, Amit -Original Message- From: Amit Pande Sent: Monday, July 31, 2023 9:29 AM To: Tomcat Users List Subject: RE: [External] Re: Supporting Proxy Protocol in Tomcat Yes, understood. Thank

RE: [External] Re: Supporting Proxy Protocol in Tomcat

2023-07-31 Thread Amit Pande
gt; Thanks, > Amit > > -Original Message- > From: Christopher Schultz > Sent: Thursday, July 27, 2023 4:13 PM > To: users@tomcat.apache.org > Subject: Re: [External] Re: Supporting Proxy Protocol in Tomcat > > All, > > On 7/27/23 12:39, Mark Thomas wrote: >> On 27/

Re: [External] Re: Supporting Proxy Protocol in Tomcat

2023-07-28 Thread Mark Thomas
: Christopher Schultz Sent: Thursday, July 27, 2023 4:13 PM To: users@tomcat.apache.org Subject: Re: [External] Re: Supporting Proxy Protocol in Tomcat All, On 7/27/23 12:39, Mark Thomas wrote: On 27/07/2023 16:27, Jonathan S. Fisher wrote: On the topic of security, may we consider a trustedProxies

RE: [External] Re: Supporting Proxy Protocol in Tomcat

2023-07-28 Thread Amit Pande
st before the TLS handshake >>> >>> If we want to support the TLS information then a little additional >>> refactoring will be required (probably to cache the result of >>> SocketWrapperBase.getSslSupport) so the new utility classes can >>> insert a PRO

Re: [External] Re: Supporting Proxy Protocol in Tomcat

2023-07-27 Thread Christopher Schultz
al Message----- From: Jonathan S. Fisher Sent: Monday, July 24, 2023 12:41 PM To: Tomcat Users List Subject: Re: [External] Re: Supporting Proxy Protocol in Tomcat Just a side note, because we're also very interested in this patch! Awhile back, I was successfully able to apply this patch and termi

Re: [External] Re: Supporting Proxy Protocol in Tomcat

2023-07-27 Thread Mark Thomas
ring if it would be possible to refactor this patch and/or allow Tomcat core code to extend and plug-in the proxy protocol support? Thanks, Amit -Original Message- From: Amit Pande Sent: Wednesday, July 26, 2023 11:43 AM To: Tomcat Users List Subject: RE: [External] Re: Supporting Proxy P

Re: [External] Re: Supporting Proxy Protocol in Tomcat

2023-07-27 Thread Jonathan S. Fisher
oxy" > > > >> On 26/07/2023 17:44, Amit Pande wrote: > >>> Missed to ask this: > >>> > >>> Looking the patch, it involves modifying Tomcat code. > >>> Was wondering if it would be possible to refactor this patch and/or >

Re: [External] Re: Supporting Proxy Protocol in Tomcat

2023-07-27 Thread Mark Thomas
Original Message- From: Amit Pande Sent: Wednesday, July 26, 2023 11:43 AM To: Tomcat Users List Subject: RE: [External] Re: Supporting Proxy Protocol in Tomcat Chris, Mark, Any thoughts on this? Mark, if we clean up the patch and re-submit, do you will have any concerns (specially securi

Re: [External] Re: Supporting Proxy Protocol in Tomcat

2023-07-26 Thread Christopher Schultz
age- From: Amit Pande Sent: Wednesday, July 26, 2023 11:43 AM To: Tomcat Users List Subject: RE: [External] Re: Supporting Proxy Protocol in Tomcat Chris, Mark, Any thoughts on this? Mark, if we clean up the patch and re-submit, do you will have any concerns (specially security wise)? Tha

Re: [External] Re: Supporting Proxy Protocol in Tomcat

2023-07-26 Thread Jonathan S. Fisher
and re-submit, do you will have any > concerns (specially security wise)? > > > > Thanks, > > Amit > > > > -Original Message- > > From: Jonathan S. Fisher > > Sent: Monday, July 24, 2023 12:41 PM > > To: Tomcat Users List > > Subject:

Re: [External] Re: Supporting Proxy Protocol in Tomcat

2023-07-26 Thread Mark Thomas
: Amit Pande Sent: Wednesday, July 26, 2023 11:43 AM To: Tomcat Users List Subject: RE: [External] Re: Supporting Proxy Protocol in Tomcat Chris, Mark, Any thoughts on this? Mark, if we clean up the patch and re-submit, do you will have any concerns (specially security wise)? Thanks, Amit

RE: [External] Re: Supporting Proxy Protocol in Tomcat

2023-07-26 Thread Amit Pande
26, 2023 11:43 AM To: Tomcat Users List Subject: RE: [External] Re: Supporting Proxy Protocol in Tomcat Chris, Mark, Any thoughts on this? Mark, if we clean up the patch and re-submit, do you will have any concerns (specially security wise)? Thanks, Amit -Original Message- From

RE: [External] Re: Supporting Proxy Protocol in Tomcat

2023-07-26 Thread Amit Pande
Amit > > -Original Message- > From: Christopher Schultz > Sent: Wednesday, May 10, 2023 4:21 PM > To: users@tomcat.apache.org > Subject: Re: [External] Re: Supporting Proxy Protocol in Tomcat > > Amit, > > On 5/10/23 12:59, Amit Pande wrote: > > Yes, we inten

Re: [External] Re: Supporting Proxy Protocol in Tomcat

2023-07-24 Thread Jonathan S. Fisher
: Christopher Schultz > Sent: Wednesday, May 10, 2023 4:21 PM > To: users@tomcat.apache.org > Subject: Re: [External] Re: Supporting Proxy Protocol in Tomcat > > Amit, > > On 5/10/23 12:59, Amit Pande wrote: > > Yes, we intended to have Tomcat run behind a (transpar

RE: [External] Re: Supporting Proxy Protocol in Tomcat

2023-07-24 Thread Amit Pande
ces behind my reverse-proxy which run in different places. It's not just s dumb pass-through. Hope that helps, -chris > -Original Message- > From: Christopher Schultz > Sent: Monday, May 8, 2023 3:40 PM > To: users@tomcat.apache.org > Subject: [External] Re: Supporting Pro

Re: [External] Re: Supporting Proxy Protocol in Tomcat

2023-05-10 Thread Christopher Schultz
pass-through. Hope that helps, -chris -Original Message- From: Christopher Schultz Sent: Monday, May 8, 2023 3:40 PM To: users@tomcat.apache.org Subject: [External] Re: Supporting Proxy Protocol in Tomcat Amit, On 5/4/23 16:07, Amit Pande wrote: We have a similar requirement

RE: [External] Re: Supporting Proxy Protocol in Tomcat

2023-05-10 Thread Amit Pande
: Christopher Schultz Sent: Monday, May 8, 2023 3:40 PM To: users@tomcat.apache.org Subject: [External] Re: Supporting Proxy Protocol in Tomcat Amit, On 5/4/23 16:07, Amit Pande wrote: > We have a similar requirement as mentioned in the below enhancement request. > > https://bz.a/ &g