Re: [External] Re: Supporting Proxy Protocol in Tomcat

2023-11-27 Thread Jonathan S. Fisher
t 3:13 PM Mark Thomas wrote: > > > > > >> On 28/08/2023 18:44, Amit Pande wrote: > > >>> Oh, sure. So, what would be the best way to get some conclusion on this > > >> thread? > > >> > > >> Provide a patch for review based on the

Re: [External] Re: Supporting Proxy Protocol in Tomcat

2023-11-21 Thread Adwait Kumar Singh
AM > >>> To: Tomcat Users List > >>> Subject: Re: [External] Re: Supporting Proxy Protocol in Tomcat > >>> > >>> > >>> CAUTION: This email originated from outside the organization. Do not > >> click links or open attachments unless you recognize the sende

Re: [External] Re: Supporting Proxy Protocol in Tomcat

2023-09-05 Thread Mark Thomas
essage- From: Mark Thomas Sent: Monday, August 28, 2023 11:20 AM To: Tomcat Users List Subject: Re: [External] Re: Supporting Proxy Protocol in Tomcat CAUTION: This email originated from outside the organization. Do not click links or open attachments unless you recognize the sender and k

Re: [External] Re: Supporting Proxy Protocol in Tomcat

2023-09-05 Thread Christopher Schultz
r patch. Mark Thanks, Amit -----Original Message- From: Mark Thomas Sent: Monday, August 28, 2023 11:20 AM To: Tomcat Users List Subject: Re: [External] Re: Supporting Proxy Protocol in Tomcat CAUTION: This email originated from outside the organization. Do not click links or open at

RE: [External] Re: Supporting Proxy Protocol in Tomcat

2023-09-05 Thread Amit Pande
AM To: Tomcat Users List Subject: Re: [External] Re: Supporting Proxy Protocol in Tomcat CAUTION: This email originated from outside the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe. If you believe this is a phishing email, us

Re: [External] Re: Supporting Proxy Protocol in Tomcat

2023-09-04 Thread Jonathan S. Fisher
re likely to irritate folks rather than encourage them to help > you progress your patch. > > Mark > > > > > > Thanks, > > Amit > > > > -Original Message- > > From: Mark Thomas > > Sent: Monday, August 28, 2023 11:20 AM > > To: Tomc

Re: [External] Re: Supporting Proxy Protocol in Tomcat

2023-08-29 Thread Mark Thomas
Users List Subject: Re: [External] Re: Supporting Proxy Protocol in Tomcat CAUTION: This email originated from outside the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe. If you believe this is a phishing email, use the Repo

RE: [External] Re: Supporting Proxy Protocol in Tomcat

2023-08-28 Thread Amit Pande
Mark Thomas Sent: Monday, August 28, 2023 11:20 AM To: Tomcat Users List Subject: Re: [External] Re: Supporting Proxy Protocol in Tomcat CAUTION: This email originated from outside the organization. Do not click links or open attachments unless you recognize the sender and know the content is saf

Re: [External] Re: Supporting Proxy Protocol in Tomcat

2023-08-28 Thread Mark Thomas
023 9:29 AM To: Tomcat Users List Subject: RE: [External] Re: Supporting Proxy Protocol in Tomcat Yes, understood. Thank you for clarifying. Even I was referring to initial consensus without any timeline or approach conclusion. Thanks, Amit -Original Message- From: Mark Thomas Sent: F

RE: [External] Re: Supporting Proxy Protocol in Tomcat

2023-08-28 Thread Amit Pande
Mark, Just checking - Did this issue get discussed in any of the core members' meeting? Thanks, Amit -Original Message- From: Amit Pande Sent: Monday, July 31, 2023 9:29 AM To: Tomcat Users List Subject: RE: [External] Re: Supporting Proxy Protocol in Tomcat Yes, understood.

RE: [External] Re: Supporting Proxy Protocol in Tomcat

2023-07-31 Thread Amit Pande
gt; > Thanks, > Amit > > -Original Message- > From: Christopher Schultz > Sent: Thursday, July 27, 2023 4:13 PM > To: users@tomcat.apache.org > Subject: Re: [External] Re: Supporting Proxy Protocol in Tomcat > > All, > > On 7/27/23 12:39, Mark Thomas wrote: >> O

Re: [External] Re: Supporting Proxy Protocol in Tomcat

2023-07-28 Thread Mark Thomas
From: Christopher Schultz Sent: Thursday, July 27, 2023 4:13 PM To: users@tomcat.apache.org Subject: Re: [External] Re: Supporting Proxy Protocol in Tomcat All, On 7/27/23 12:39, Mark Thomas wrote: On 27/07/2023 16:27, Jonathan S. Fisher wrote: On the topic of security, may we consider a trustedPr

RE: [External] Re: Supporting Proxy Protocol in Tomcat

2023-07-28 Thread Amit Pande
Mark... just go do it!" >>>> :) >>> >>> :) >>> >>> Actually with the patch that has already been provided and the >>> suggested implementation outline above I don't think there is too much work >>> to do. >>>

Re: [External] Re: Supporting Proxy Protocol in Tomcat

2023-07-27 Thread Christopher Schultz
you will have any concerns (specially security wise)? Thanks, Amit -Original Message- From: Jonathan S. Fisher Sent: Monday, July 24, 2023 12:41 PM To: Tomcat Users List Subject: Re: [External] Re: Supporting Proxy Protocol in Tomcat Just a side note, because we're also very interest

Re: [External] Re: Supporting Proxy Protocol in Tomcat

2023-07-27 Thread Mark Thomas
to ask this: Looking the patch, it involves modifying Tomcat code. Was wondering if it would be possible to refactor this patch and/or allow Tomcat core code to extend and plug-in the proxy protocol support? Thanks, Amit -Original Message- From: Amit Pande Sent: Wednesday, July 26, 202

Re: [External] Re: Supporting Proxy Protocol in Tomcat

2023-07-27 Thread Jonathan S. Fisher
/httpd.apache.org/docs/2.4/mod/mod_remoteip.html search for > > "haproxy" > > > >> On 26/07/2023 17:44, Amit Pande wrote: > >>> Missed to ask this: > >>> > >>> Looking the patch, it involves modifying Tomcat code. > >>&g

Re: [External] Re: Supporting Proxy Protocol in Tomcat

2023-07-27 Thread Mark Thomas
ode to extend and plug-in the proxy protocol support? Thanks, Amit -Original Message- From: Amit Pande Sent: Wednesday, July 26, 2023 11:43 AM To: Tomcat Users List Subject: RE: [External] Re: Supporting Proxy Protocol in Tomcat Chris, Mark, Any thoughts on this? Mark, if we clean u

Re: [External] Re: Supporting Proxy Protocol in Tomcat

2023-07-26 Thread Christopher Schultz
in the proxy protocol support? Thanks, Amit -Original Message- From: Amit Pande Sent: Wednesday, July 26, 2023 11:43 AM To: Tomcat Users List Subject: RE: [External] Re: Supporting Proxy Protocol in Tomcat Chris, Mark, Any thoughts on this? Mark, if we clean up the patch and re-submit, d

Re: [External] Re: Supporting Proxy Protocol in Tomcat

2023-07-26 Thread Jonathan S. Fisher
if we clean up the patch and re-submit, do you will have any > concerns (specially security wise)? > > > > Thanks, > > Amit > > > > -Original Message- > > From: Jonathan S. Fisher > > Sent: Monday, July 24, 2023 12:41 PM > > To: Tomcat Users

Re: [External] Re: Supporting Proxy Protocol in Tomcat

2023-07-26 Thread Mark Thomas
ssage- From: Amit Pande Sent: Wednesday, July 26, 2023 11:43 AM To: Tomcat Users List Subject: RE: [External] Re: Supporting Proxy Protocol in Tomcat Chris, Mark, Any thoughts on this? Mark, if we clean up the patch and re-submit, do you will have any concerns (specially security wise)

RE: [External] Re: Supporting Proxy Protocol in Tomcat

2023-07-26 Thread Amit Pande
26, 2023 11:43 AM To: Tomcat Users List Subject: RE: [External] Re: Supporting Proxy Protocol in Tomcat Chris, Mark, Any thoughts on this? Mark, if we clean up the patch and re-submit, do you will have any concerns (specially security wise)? Thanks, Amit -Original Message- From

RE: [External] Re: Supporting Proxy Protocol in Tomcat

2023-07-26 Thread Amit Pande
nks, > Amit > > -Original Message- > From: Christopher Schultz > Sent: Wednesday, May 10, 2023 4:21 PM > To: users@tomcat.apache.org > Subject: Re: [External] Re: Supporting Proxy Protocol in Tomcat > > Amit, > > On 5/10/23 12:59, Amit Pande wrote: > > Yes

Re: [External] Re: Supporting Proxy Protocol in Tomcat

2023-07-24 Thread Jonathan S. Fisher
> From: Christopher Schultz > Sent: Wednesday, May 10, 2023 4:21 PM > To: users@tomcat.apache.org > Subject: Re: [External] Re: Supporting Proxy Protocol in Tomcat > > Amit, > > On 5/10/23 12:59, Amit Pande wrote: > > Yes, we intended to have Tomcat run behind a

RE: [External] Re: Supporting Proxy Protocol in Tomcat

2023-07-24 Thread Amit Pande
] Re: Supporting Proxy Protocol in Tomcat Amit, On 5/10/23 12:59, Amit Pande wrote: > Yes, we intended to have Tomcat run behind a (transparent) TCP proxy e.g. > https://www.envoyproxy.io/docs/envoy/latest/intro/arch_overview/other_features/ip_transparency > which supports the proxy

Re: [External] Re: Supporting Proxy Protocol in Tomcat

2023-05-10 Thread Christopher Schultz
Amit, On 5/10/23 12:59, Amit Pande wrote: Yes, we intended to have Tomcat run behind a (transparent) TCP proxy e.g. https://www.envoyproxy.io/docs/envoy/latest/intro/arch_overview/other_features/ip_transparency which supports the proxy protocol. Since there is not much action on this https://

RE: [External] Re: Supporting Proxy Protocol in Tomcat

2023-05-10 Thread Amit Pande
Thank you, Chris, for the inputs. Yes, we intended to have Tomcat run behind a (transparent) TCP proxy e.g. https://www.envoyproxy.io/docs/envoy/latest/intro/arch_overview/other_features/ip_transparency which supports the proxy protocol. Since there is not much action on this https://bz.apache.