Re: Supported callbacks in Tomcat JASPIC implementation

2017-11-21 Thread Lazar Kirchev
Thanks Chris, Mark, I opened an enhancement request about a configurable callback handler - https://bz.apache.org/bugzilla/show_bug.cgi?id=61795 I have included in it a pull request with patch proposal. Regards, Lazar On Mon, Nov 20, 2017 at 4:24 PM, Christopher Schultz < ch...@christopherschult

Re: Supported callbacks in Tomcat JASPIC implementation

2017-11-20 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark and Lazar, On 11/18/17 10:05 AM, Mark Thomas wrote: > On 18/11/17 14:20, Lazar Kirchev wrote: >> Hello Marc, >> >> Do you think it makes sense to make the CallbackHandler >> implementation class configurable, e.g. to be able to specify its >>

Re: Supported callbacks in Tomcat JASPIC implementation

2017-11-20 Thread Lazar Kirchev
> Do you think it makes sense to make the CallbackHandler implementation > > class configurable, e.g. to be able to specify its name via a property? > > As a property on the authenticator? I don't see why not. Yes, something like that: https://github.com/apache/tomcat/pull/93 > > In > > this w

Re: Supported callbacks in Tomcat JASPIC implementation

2017-11-18 Thread Mark Thomas
On 18/11/17 14:20, Lazar Kirchev wrote: > Hello Marc, > > Do you think it makes sense to make the CallbackHandler implementation > class configurable, e.g. to be able to specify its name via a property? As a property on the authenticator? I don't see why not. > In > this way if support for addit

Re: Supported callbacks in Tomcat JASPIC implementation

2017-11-18 Thread Lazar Kirchev
Hello Marc, Do you think it makes sense to make the CallbackHandler implementation class configurable, e.g. to be able to specify its name via a property? In this way if support for additional callbacks is necessary someone could plug a custom CallbackHandler providing such a support. The current

Re: Supported callbacks in Tomcat JASPIC implementation

2017-11-08 Thread Lazar Kirchev
Yes, my mistake - 3.5, not 4.5. But the content is the same. Thanks Mark! On Wed, Nov 8, 2017 at 5:38 PM, Mark Thomas wrote: > On 08/11/2017 12:00, Lazar Kirchev wrote: > > Hello, > > > > According to the JASSPIC spec version 1.1, chapter 4.5, The > CallbackHandler > > should support CallerPrin

Re: Supported callbacks in Tomcat JASPIC implementation

2017-11-08 Thread Mark Thomas
On 08/11/2017 12:00, Lazar Kirchev wrote: > Hello, > > According to the JASSPIC spec version 1.1, chapter 4.5, The CallbackHandler > should support CallerPrincipalCallback, GroupPrincipalCallback, > PasswordValidationCallback, as well as CertStoreCallback, > PrivateKeyCallback, SecretKeyCallback a

Supported callbacks in Tomcat JASPIC implementation

2017-11-08 Thread Lazar Kirchev
Hello, According to the JASSPIC spec version 1.1, chapter 4.5, The CallbackHandler should support CallerPrincipalCallback, GroupPrincipalCallback, PasswordValidationCallback, as well as CertStoreCallback, PrivateKeyCallback, SecretKeyCallback and TrustStoreCallback. However, in Tomcat 8.5.* org.a