Maven plugin overwriting tomee.xml when using custom zip artifact

2015-05-05 Thread Adam Cornett
We use TomEE in several applications, and to speed up builds and standardize our deployments, we use the Maven plugin to create a TomEE zip already configured with our libraries and configuration files and publish it to our internal maven repo. We then use the TomEE maven plugin in each project

Re: Maven plugin overwriting tomee.xml when using custom zip artifact

2015-05-05 Thread Romain Manni-Bucau
https://issues.apache.org/jira/browse/TOMEE-1578 used a mix between your idea and mine, basically i load jaxb tree, check i need to add the Deployments then do a replace if I need to add it (avoid to break the whole formatting) happy to get a review/test from you if possible Romain Manni-Bucau

Re: Maven plugin overwriting tomee.xml when using custom zip artifact

2015-05-05 Thread Adam Cornett
Sorry, by original I mean the one packaged in the original tomee zip file. On Tue, May 5, 2015 at 11:04 AM, Adam Cornett adam.corn...@gmail.com wrote: That won't work since the original file contains the tag but it is commented out, so a simple string matching catches the value in the comment

Re: Maven plugin overwriting tomee.xml when using custom zip artifact

2015-05-05 Thread Adam Cornett
That won't work since the original file contains the tag but it is commented out, so a simple string matching catches the value in the comment and thinks its really there, that's why I opted for the 40-ton beast of dom parsing. On Tue, May 5, 2015 at 11:00 AM, Romain Manni-Bucau

Re: Maven plugin overwriting tomee.xml when using custom zip artifact

2015-05-05 Thread Romain Manni-Bucau
Ah ok, thought you were using tomee:build. Yes makes sense for tomee:run. About the patch we can also be brutal and use: String content = IO.slurp(tomeeXml); if (content.contains(Deployments)) return; // user handles it content = content.replace(/tomee, Deployments + System.lineSeparator()

Re: Maven plugin overwriting tomee.xml when using custom zip artifact

2015-05-05 Thread Adam Cornett
Perhaps I have not done a good job explaining how I'm using (abusing?) the tomee plugin: I have a pom only project that uses the tomee maven plugin to generate a tomee zip, adding in the conf, replacing openjpa with hibernate adding several other libraries, adding the setenv.(bat|sh) files with

Re: Maven plugin overwriting tomee.xml when using custom zip artifact

2015-05-05 Thread Romain Manni-Bucau
Hi 2015-05-05 15:47 GMT+02:00 Adam Cornett adam.corn...@gmail.com: We use TomEE in several applications, and to speed up builds and standardize our deployments, we use the Maven plugin to create a TomEE zip already configured with our libraries and configuration files and publish it to our

Re: Maven plugin overwriting tomee.xml when using custom zip artifact

2015-05-05 Thread Adam Cornett
Since the conf is loaded into the zip file when we build it we are not re-supplying the conf each time we use the plugin. Since all of our apps use a common conf we wanted it in one place instead of having copies attached to each project. On Tue, May 5, 2015 at 9:57 AM, Romain Manni-Bucau

Re: Maven plugin overwriting tomee.xml when using custom zip artifact

2015-05-05 Thread Romain Manni-Bucau
I see, why not executing maven dependency plugin before tomee-maven-plugin and referencing the unpacked folder for the conf? Romain Manni-Bucau @rmannibucau https://twitter.com/rmannibucau | Blog http://rmannibucau.wordpress.com | Github https://github.com/rmannibucau | LinkedIn

Re: Maven plugin overwriting tomee.xml when using custom zip artifact

2015-05-05 Thread Adam Cornett
Like I said, there are many ways to work around this issue :-) I was just offering a change to the plugin to be more selective in how it changes the built in file to keep our build process as simple as possible. I found it odd that the plugin was careful to honor custom changes to the server.xml

Re: Maven plugin overwriting tomee.xml when using custom zip artifact

2015-05-05 Thread Romain Manni-Bucau
2015-05-05 16:19 GMT+02:00 Adam Cornett adam.corn...@gmail.com: Like I said, there are many ways to work around this issue :-) I was just offering a change to the plugin to be more selective in how it changes the built in file to keep our build process as simple as possible. I found it odd