Re: Using converters properly in Wicket?

2009-02-08 Thread Igor Vaynberg
why dont you create your own converter for now and see how that improves things. we are talking about something that took 1.4 seconds out of at least a 100+ second test... -igor On Sun, Feb 8, 2009 at 11:31 PM, Martin Makundi wrote: >> im not sure how necessary the threadlocal is. yes, it took u

Re: Using converters properly in Wicket?

2009-02-08 Thread Martin Makundi
> im not sure how necessary the threadlocal is. yes, it took up 6mb of > memory, but those instances are not being held on to, so if you run GC > all that memory will be reclaimed. I am more concerned with the cpu hog than the memory hog associated with the converter. ** Martin > > On Sun, Feb 8

Re: Using converters properly in Wicket?

2009-02-08 Thread Martin Makundi
> no, but it should take out that Task$1 which is the biggest cpu hog. Well, that is just the server pool thread... it is not relevant. ** Martin > > -igor > > On Sun, Feb 8, 2009 at 9:25 PM, Martin Makundi > wrote: >>> are you load testing wicket in development mode? >> >> Ofcourse ;) >> >> I

Re: Using converters properly in Wicket?

2009-02-08 Thread Igor Vaynberg
im not sure how necessary the threadlocal is. yes, it took up 6mb of memory, but those instances are not being held on to, so if you run GC all that memory will be reclaimed. -igor On Sun, Feb 8, 2009 at 8:55 PM, Martin Makundi wrote: > Cool. What is your take on using a ThreaLocal instead of al

Re: Using converters properly in Wicket?

2009-02-08 Thread Igor Vaynberg
no, but it should take out that Task$1 which is the biggest cpu hog. -igor On Sun, Feb 8, 2009 at 9:25 PM, Martin Makundi wrote: >> are you load testing wicket in development mode? > > Ofcourse ;) > > I run the tests again in deployment mode, does not affect the > BigDecimalConverter results. >

Re: Proper hook for conversational state that also works with tests

2009-02-08 Thread Timo Rantalaiho
> On Fri, Feb 6, 2009 at 9:06 AM, cpopetz wrote: > > This works great when running in-container, but isn't playing well with > > tests that use ajax. When an ajax link is clicked in-container, the full > > request cycle is step()ed through. But BaseWicketTester.clickLink(), which > > I presume i

Re: Using converters properly in Wicket?

2009-02-08 Thread Martin Makundi
> are you load testing wicket in development mode? Ofcourse ;) I run the tests again in deployment mode, does not affect the BigDecimalConverter results. ** Martin > > On Sun, Feb 8, 2009 at 8:32 PM, Martin Makundi > wrote: >>> that means you can create about 3500/second...how many users do yo

Re: Using converters properly in Wicket?

2009-02-08 Thread Martin Makundi
Cool. What is your take on using a ThreaLocal instead of always cloning return (NumberFormat)numberFormat.clone(); in org.apache.wicket.util.convert.converters.AbstractDecimalConverter#getNumberFormat(java.util.Locale) ** Martin 2009/2/9 Igor Vaynberg : > On Sun, Feb 8, 2009 at 7:46 PM, Martin Ma

Re: Proper hook for conversational state that also works with tests

2009-02-08 Thread Igor Vaynberg
the problem is wicket tester doesnt run wicket through the entire web-request workflow and you are hooking into a part that is not being hit. i have a good idea of where to add an extension point, please open a jira issue so i can attach a patch there and you can see if it will work for you. -igor

Re: Using converters properly in Wicket?

2009-02-08 Thread Igor Vaynberg
are you load testing wicket in development mode? -igor On Sun, Feb 8, 2009 at 8:32 PM, Martin Makundi wrote: >> that means you can create about 3500/second...how many users do you >> have on that server? > > It's just a load test. It's a heavyish page on itself and I am hitting > it with about 2

Re: Using converters properly in Wicket?

2009-02-08 Thread Martin Makundi
> that means you can create about 3500/second...how many users do you > have on that server? It's just a load test. It's a heavyish page on itself and I am hitting it with about 20 concurrent users. > btw, your memory profile attachment didnt make it through, > maybe you can upload your images so

Re: Using converters properly in Wicket?

2009-02-08 Thread Igor Vaynberg
On Sun, Feb 8, 2009 at 7:46 PM, Martin Makundi wrote: > Another thing that came into my mind is, that there is > newNumberFormat(Locale locale) -method in AbstractDecimalConverter, > but the method is never used [instead, there is a direct "numberFormat > = NumberFormat.getInstance(locale);" -invo

Re: Using converters properly in Wicket?

2009-02-08 Thread Igor Vaynberg
that means you can create about 3500/second...how many users do you have on that server? can you show us the timing screenshot, i am very curious. btw, your memory profile attachment didnt make it through, maybe you can upload your images somewhere else. -igor On Sun, Feb 8, 2009 at 8:09 PM, Mart

Re: Using converters properly in Wicket?

2009-02-08 Thread Martin Makundi
Micro -> multiplied under load so the cost accumulates. And here attached is a picture of the memory profile, I am not sure if I read this right, but it says 6-8 Mb. ** Martin 2009/2/9 Igor Vaynberg : > is that 291 milliseconds or 291 microseconds? > > -igor > > On Sun, Feb 8, 2009 at 7:46 PM, Ma

Re: Using converters properly in Wicket?

2009-02-08 Thread Igor Vaynberg
is that 291 milliseconds or 291 microseconds? -igor On Sun, Feb 8, 2009 at 7:46 PM, Martin Makundi wrote: > I remembered it was a hotspot. Checking again, it is not a memory > bottleneck but a performance bottleneck. I apologise for my > imprecision. > > I have several BigDecimalLabels each with

Re: Testing DataView

2009-02-08 Thread Timo Rantalaiho
On Sun, 08 Feb 2009, Erick Fleming wrote: > private final org.apache.wicket.markup.repeater.data.IDataProvider > org.apache.wicket.markup.repeater.data.DataViewBase.dataProvider > [class=$Proxy5] > protected java.lang.reflect.InvocationHandler > java.lang.reflect.Proxy.h [class=or

Re: Using converters properly in Wicket?

2009-02-08 Thread Martin Makundi
I remembered it was a hotspot. Checking again, it is not a memory bottleneck but a performance bottleneck. I apologise for my imprecision. I have several BigDecimalLabels each with its own converter. Each instance creation takes 291 us on the reference computer. Furthermore, each of the getNumberF

Re: AutoCompleteTextField buggy?

2009-02-08 Thread Phil Grimm
I tried it in my app (running 1.4-rc1) and was not able to reproduce this. Phil On Sat, Feb 7, 2009 at 1:05 PM, Arthur Leigh Allen < arthurleigh.al...@yahoo.de> wrote: > hi igor, it's 1.3.5 > > > > > > Von: Igor Vaynberg > An: users@wicket.apache.org > Gesendet:

Re: How to add a component in a behavior ?

2009-02-08 Thread ZedroS
hi Just a question, about this suggestion : normal html or wicket componentsnormal html or wicket components Is it completely far off or could it be interesting ? What do you think of it ? thanks in advance ++ -- View this message in context: http://www.nabble.com/How-to-add-a-component-in

Re: Testing DataView

2009-02-08 Thread Erick Fleming
Timo, Thanks alot for the feedback. I'm getting close, but am running into a serialization problem with the mocked IDataProvider (JMock and Mockito). 2 [class=org.apache.wicket.util.tester.DummyPanelPage, path=2] private java.lang.Object org.apache.wicket.MarkupContainer.children [class=or

Re: Using converters properly in Wicket?

2009-02-08 Thread Jeremy Thomerson
What in particular was hogging that 200MB of memory? Was your converter holding something? If it were just a simple converter class like most, it would take thousands upon thousands of them to take that much memory. Most likely, you have another issue. Run a profiler and let us know what's usin

Re: Using converters properly in Wicket?

2009-02-08 Thread Timo Rantalaiho
On Sun, 08 Feb 2009, Martin Makundi wrote: > Exactly. I had a component with its own converter and my memory > profiler showed that it ended up hogging 200 MB. Wow, that's interesting. Did you file a Jira issue and/or would you be able to do a quickstart to produce that? Did your converter have

Re: Using converters properly in Wicket?

2009-02-08 Thread Martin Makundi
Exactly. I had a component with its own converter and my memory profiler showed that it ended up hogging 200 MB. Ofcourse I can organize my own singleton library of converters.. but Wicket has its own ConverterLocator. I would like to hear if someone has made such an implementation of ConverterLoc

Re: Using converters properly in Wicket?

2009-02-08 Thread Thomas Mäder
You can override getConverter() on a component to return any converter you want. Thomas On Sun, Feb 8, 2009 at 6:53 PM, Martin Makundi < martin.maku...@koodaripalvelut.com> wrote: > Hi! > > I am a bit confused with the converters in Wicket. I have some numbers > which I want to display with two

Re: Behaviors and Strategy pattern

2009-02-08 Thread dtoffe
I agree, in general you can have many Behaviors added toghether, and with a Strategy you would have to choose one from the available options. Daniel Thomas Mäder-2 wrote: > > It's probably closer to a decorator. > > Thomas > > On Sun, Feb 8, 2009 at 11:19 AM, HHB wrote: > >> >> Hey, >>

Re: Bug in wicket-stuff phonebook

2009-02-08 Thread Igor Vaynberg
fixed -igor On Fri, Feb 6, 2009 at 2:17 AM, cmoulliard wrote: > > Hi, > > I would like to mention that there is a bug in the maven pom.xml file of the > project phonebook because the properties files located here > "wicketstuff-core\phonebook\src\main\java\wicket\contrib\phonebook\web\page" > ar

More Wicket Related Resources ...

2009-02-08 Thread jWeekend
We have started tidying up our http://code.google.com/p/londonwicket/downloads/list London Wicket Google Code Project Downloads area . There will also be new material occasionally posted on http://www.jWeekend.com/dev/ArticlesPage/ jWeekend's resources page (like our UML class diagram that show

Re: Using converters properly in Wicket?

2009-02-08 Thread Igor Vaynberg
you can override getconverter() on component level -igor On Sun, Feb 8, 2009 at 9:53 AM, Martin Makundi wrote: > Hi! > > I am a bit confused with the converters in Wicket. I have some numbers > which I want to display with two decimals and some other numbers with > another amout of decimals. > >

Using converters properly in Wicket?

2009-02-08 Thread Martin Makundi
Hi! I am a bit confused with the converters in Wicket. I have some numbers which I want to display with two decimals and some other numbers with another amout of decimals. It appears like Wicket has only one instance of BigDecimalConverter, which is used everywhere. So if I adjust its NumberForma

Re: Why Wicket application contains maven-jetty-plugin?

2009-02-08 Thread Timo Rantalaiho
On Sun, 08 Feb 2009, HHB wrote: > Does maven-jetty-plugin getting used when we run Wicket tests (WicketTester), > you know, integration tests? No, WicketTester is for testing the component code in a more unit-test like fashion [1], without running it in a container. But if you do some whitebox /

Re: Why Wicket application contains maven-jetty-plugin?

2009-02-08 Thread HHB
Does maven-jetty-plugin getting used when we run Wicket tests (WicketTester), you know, integration tests? Timo Rantalaiho wrote: > > On Sun, 08 Feb 2009, HHB wrote: >> Why POM of a Wicket skeleton application contains maven-jetty-plugin? > > To be able to run your application from the command

Re: Why Wicket application contains maven-jetty-plugin?

2009-02-08 Thread Timo Rantalaiho
On Sun, 08 Feb 2009, HHB wrote: > Why POM of a Wicket skeleton application contains maven-jetty-plugin? To be able to run your application from the command line with mvn jetty:run in the cases when that makes more sense than running a Jetty.java or something such from the IDE. Best wishes,

Re: Wicket BDD with JDave training at ApacheCon EU 2009 on Tue 24 March in Amsterdam

2009-02-08 Thread Timo Rantalaiho
On Sun, 08 Feb 2009, Johan Compagner wrote: > Talking about apache con eu 2009 > Shouldnt we organize a get to gether? > I think we can now use the conference rooms of apache con them selfs. Yes! Being busy family men and consultants, we're planning to get there on Monday evening and leave on Wed

Why Wicket application contains maven-jetty-plugin?

2009-02-08 Thread HHB
Hey, Why POM of a Wicket skeleton application contains maven-jetty-plugin? Thanks. -- View this message in context: http://www.nabble.com/Why-Wicket-application-contains-maven-jetty-plugin--tp21899056p21899056.html Sent from the Wicket - User mailing list archive at Nabble.com. ---

Re: Behaviors and Strategy pattern

2009-02-08 Thread Thomas Mäder
It's probably closer to a decorator. Thomas On Sun, Feb 8, 2009 at 11:19 AM, HHB wrote: > > Hey, > Is Behaviors in Wicket are implementation of the Strategy Pattern? > Thanks. > -- > View this message in context: > http://www.nabble.com/Behaviors-and-Strategy-pattern-tp21897409p21897409.html >

Re: Wicket BDD with JDave training at ApacheCon EU 2009 on Tue 24 March in Amsterdam

2009-02-08 Thread Johan Compagner
Talking about apache con eu 2009 Shouldnt we organize a get to gether? I think we can now use the conference rooms of apache con them selfs. On 06/02/2009, Timo Rantalaiho wrote: > Hello all, > > My colleagues Markus Hjort and Marko Sibakov and I are > holding a full-day training session on apply

Behaviors and Strategy pattern

2009-02-08 Thread HHB
Hey, Is Behaviors in Wicket are implementation of the Strategy Pattern? Thanks. -- View this message in context: http://www.nabble.com/Behaviors-and-Strategy-pattern-tp21897409p21897409.html Sent from the Wicket - User mailing list archive at Nabble.com. --

Re: Wicket BDD with JDave training at ApacheCon EU 2009 on Tue 24 March in Amsterdam

2009-02-08 Thread Timo Rantalaiho
Hello again, We have now put the current version of the training material online at http://www.jdave.org/bdd-wicket/ It can be interesting even if you cannot make it to the session. We'll be updating the material every now and then. Best wishes, Timo -- Timo Rantalaiho Reaktor

Re: Testing DataView

2009-02-08 Thread Timo Rantalaiho
On Thu, 05 Feb 2009, Erick Fleming wrote: > I'm new to unit testing and just trying to get my feet wet. The actual code > under test would be a panel that should display some data. I guess I don't > really care to test wicket's dataview but whether or not my panel is > actually displaying the dat