Re: DropDownChoiceWithStylingOptionsT

2010-01-11 Thread aditsu
There's a small bug - endOptGroup(tmp) for OptGroup changed actually closes the optgroup after the current option, not before. I replaced it with buffer.append(/optgroup), but I wonder if there can be some other markup after the previous /option and whether that matters. -- View this message in

Re: DropDownChoiceWithStylingOptionsT

2010-01-11 Thread Martin Makundi
There's a small bug - endOptGroup(tmp) for OptGroup changed actually closes the optgroup after the current option, not before. Note: It is supposed to close the previous optgroup. Not the current optgroup. If there is a bug, can you give me your testcase? ** Martin I replaced it with

Re: DropDownChoiceWithStylingOptionsT

2010-01-11 Thread aditsu
Hi, thanks for the quick reply. MartinM wrote: There's a small bug - endOptGroup(tmp) for OptGroup changed actually closes the optgroup after the current option, not before. Note: It is supposed to close the previous optgroup. Not the current optgroup. Yep, that's why it's a bug. It

Re: DropDownChoiceWithStylingOptionsT

2010-01-11 Thread Martin Makundi
Hi! Hmm.. mine seems to work fine with some other test cases, is this the same code you have or is it different: /** * @see org.apache.wicket.markup.html.form.AbstractChoice#appendOptionHtml(org.apache.wicket.util.string.AppendingStringBuffer, java.lang.Object, int, java.lang.String) */

Re: DropDownChoiceWithStylingOptionsT

2010-01-11 Thread aditsu
MartinM wrote: Hmm.. mine seems to work fine with some other test cases, is this the same code you have or is it different: It's the same, except for Utils.equalsOrNull which must be from your unpublished code, and I replaced it with one of my own utility methods. Just try my test case.

Re: DropDownChoiceWithStylingOptionsT

2010-01-11 Thread Martin Makundi
Hi! Thanks for pointing that out.. must have been drunk when I coded that 8-) Here is an improved version: /** * @see org.apache.wicket.markup.html.form.AbstractChoice#appendOptionHtml(org.apache.wicket.util.string.AppendingStringBuffer, java.lang.Object, int, java.lang.String) */

DropDownChoiceWithStylingOptionsT

2009-12-04 Thread Martin Makundi
Free4U public class DropDownChoiceWithStylingOptionsT extends DropDownChoiceT { private String previouslyAppendedOptGroupLabel; private int choices; /** * @param id * @param choices * @param renderer */ public DropDownChoiceWithStylingOptions(String id, IModel? extends

Re: DropDownChoiceWithStylingOptionsT

2009-12-04 Thread nino martinez wael
Martin, why not put something like this in minis? 2009/12/4 Martin Makundi martin.maku...@koodaripalvelut.com Free4U public class DropDownChoiceWithStylingOptionsT extends DropDownChoiceT { private String previouslyAppendedOptGroupLabel; private int choices; /** * @param id

Re: DropDownChoiceWithStylingOptionsT

2009-12-04 Thread Martin Makundi
Busy... sorry. Feel free to put it. 2009/12/4 nino martinez wael nino.martinez.w...@gmail.com: Martin, why not put something like this in minis? 2009/12/4 Martin Makundi martin.maku...@koodaripalvelut.com Free4U public class DropDownChoiceWithStylingOptionsT extends DropDownChoiceT

Re: DropDownChoiceWithStylingOptionsT

2009-12-04 Thread nino martinez wael
Makundi martin.maku...@koodaripalvelut.com Free4U public class DropDownChoiceWithStylingOptionsT extends DropDownChoiceT { private String previouslyAppendedOptGroupLabel; private int choices; /** * @param id * @param choices * @param renderer */ public

Re: DropDownChoiceWithStylingOptionsT

2009-12-04 Thread Igor Vaynberg
nino.martinez.w...@gmail.com: Martin, why not put something like this in minis? 2009/12/4 Martin Makundi martin.maku...@koodaripalvelut.com Free4U public class DropDownChoiceWithStylingOptionsT extends DropDownChoiceT {  private String previouslyAppendedOptGroupLabel;  private int

Re: DropDownChoiceWithStylingOptionsT

2009-12-04 Thread Marat Radchenko
Definitely, lol :) - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org