Wicket 6.2.0 and MultipartServletWebRequestImpl

2012-10-31 Thread heapifyman
Hello, Just updated from 6.1.1 to 6.2.0 and now I'm having a problem with file uploads. I have a public class FileUploadRequestHandler implements IRequestHandler that handles jquery fileupload requests. In its respond() method I call Request request = requestCycle.getRequest(); which in wicke

Re: Wicket 6.2.0 and MultipartServletWebRequestImpl

2012-10-31 Thread Martin Grigorov
https://git-wip-us.apache.org/repos/asf/wicket/repo?p=wicket.git;a=commitdiff;h=3355b5af68a238855a602f5161980d65024a1e92 On Wed, Oct 31, 2012 at 12:49 PM, heapifyman wrote: > Hello, > > Just updated from 6.1.1 to 6.2.0 and now I'm having a problem with file > uploads. > I have a > public class

Re: Wicket 6.2.0 and MultipartServletWebRequestImpl

2012-10-31 Thread heapifyman
Sorry, could you elaborate a bit on that? I don't see the connection... :( 2012/10/31 Martin Grigorov > > https://git-wip-us.apache.org/repos/asf/wicket/repo?p=wicket.git;a=commitdiff;h=3355b5af68a238855a602f5161980d65024a1e92 > > On Wed, Oct 31, 2012 at 12:49 PM, heapifyman wrote: > > Hello,

Re: Wicket 6.2.0 and MultipartServletWebRequestImpl

2012-10-31 Thread Andrea Del Bene
Hi, the change introduced by WICKET-4752 caused some other problems so it was reverted in 6.2.0. If you want to obtain the old behavior you should use in our application class the code that has been removed from WebApplication class (see the diff indicated by Martin) Sorry, could you elabora

Re: Wicket 6.2.0 and MultipartServletWebRequestImpl

2012-10-31 Thread heapifyman
Hello, after a second closer look I figured I should override newWebRequest in my WicketApplication extends WebApplication, right? So now I have: @Override public WebRequest newWebRequest(HttpServletRequest servletRequest, String filterPath) { WebRequest webRequest = super.newWebRequest(servletRequ

Re: Wicket 6.2.0 and MultipartServletWebRequestImpl

2012-10-31 Thread Andrea Del Bene
Yes it should be enough. Hello, after a second closer look I figured I should override newWebRequest in my WicketApplication extends WebApplication, right? So now I have: @Override public WebRequest newWebRequest(HttpServletRequest servletRequest, String filterPath) { WebRequest webRequest = supe

Re: Wicket 6.2.0 and MultipartServletWebRequestImpl

2012-10-31 Thread Martin Grigorov
Hi, As Andrea explained (and the ticket you mentioned yourself) the change in MyApp#newWebRequest caused several problems, so better do not do it there. Move the code that creates the MultipartWebRequest in your own IResource impl. On Wed, Oct 31, 2012 at 1:55 PM, heapifyman wrote: > Hello, > af

Re: Wicket 6.2.0 and MultipartServletWebRequestImpl

2012-10-31 Thread heapifyman
Ok, now I am kind of lost again. Sorry for the stupid question: Before I had - in WicketApplication: mount(new FileUploader("/fileupload")); - where FileUploader extends AbstractMapper and calls "return new FileUploadRequestHandler();" in mapRequest(Request request) - FileUploadRequestHandler imple

Re: Wicket 6.2.0 and MultipartServletWebRequestImpl

2012-11-01 Thread Martin Grigorov
Hi, The idea is to create MultipartWebRequest before trying to read multi-part data from the servlet input stream. So in your case you have to do this in your own FileUploadRequestHandler. On Wed, Oct 31, 2012 at 6:14 PM, heapifyman wrote: > Ok, now I am kind of lost again. Sorry for the stupid

Re: Wicket 6.2.0 and MultipartServletWebRequestImpl

2012-11-01 Thread heapifyman
Ok, got it. Thanks a lot. 2012/11/1 Martin Grigorov > Hi, > > The idea is to create MultipartWebRequest before trying to read > multi-part data from the servlet input stream. > So in your case you have to do this in your own FileUploadRequestHandler. > > On Wed, Oct 31, 2012 at 6:14 PM, heapify