Roland McGrath wrote:
> I've finished the updates I've been talking about. Please take a fresh
> look at the 'make htmldocs' book. I updated crash-suspend.c for the
changes.
Took the whole look at the new utrace patch, also performed some tests.
It works fine and looks really good. Just several trivial problems:
1. typo "contrained" in utrace_engine_ops
* most contrained among the choices made by all attached engines.
2. duplicated "is" in get_utrace_lock
* attached. If the attached is flag is false (utrace_barrier() only),
3. typo "deeath" in utrace_control
* with -%ESRCH. If the @report_deeath callback may already have
4. the 2nd "is" --> "if" in utrace_finish_examine
* should be discarded. The error is -%EINVAL is @engine is not
BTW:
Does it need to check task->utrace==NULL in function utrace_unsafe_exec.
I know it depends on utrace_flags.
Regards,
Wenji
