[PATCH] Fix spin_unlock order in utrace_stop

2008-09-02 Thread Ananth N Mavinakayanahalli
From: Ananth N Mavinakayanahalli [EMAIL PROTECTED] utrace_stop() seems to get the spin_unlock sequence inverted in one of the unlikely branches. Fix it. Signed-off-by: Ananth N Mavinakayanahalli [EMAIL PROTECTED] --- kernel/utrace.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

utrace_set_events in quiesce handler?

2008-09-02 Thread David Smith
In systemtap, we've changed to stopping a thread before setting up the events we're interested in (besides quiesce/death). So, basically, it looks like this (without much error handling): // initial attach logic // ... find an interesting thread ... ops.report_quiesce = quiesce_handler;

Re: [PATCH] Fix spin_unlock order in utrace_stop

2008-09-02 Thread Roland McGrath
Thanks! I don't think that ever hurts anything, but it's definitely right to fix it. I've put the change in and updated the patches. Thanks, Roland