Re: [PATCH -mm] introduce tracehook_finish_jctl() helper

2009-08-01 Thread Roland McGrath
Confused. This patch has no effect. Indeed, the three patches changing do_signal_stop() have no immediate material effect. They all just clean up the code and prepare the hooks that utrace (or something like it) needs to make tracing stops mesh well with job control stops. I'd thought it

Re: [PATCH 5/6] finish_utrace_stop: check -stopped lockless

2009-08-01 Thread Roland McGrath
finish_utrace_stop() can check -stopped lockless. It was set by us, we can't miss it. We enter utrace_stop() for some stop. Either then or later, a group jctl stop finishes and sets SIGNAL_STOP_STOPPED. Later, utrace_wakeup() sees that and we switch to TASK_STOPPED after clearing -stopped.

Re: [PATCH 6/6] get_utrace_lock: do not check EXIT_DEAD

2009-08-01 Thread Roland McGrath
get_utrace_lock() checks -state != EXIT_DEAD to make sure it safe to use -utrace. This is unneeded since -utrace was embedded into task_struct. If we can read -state, we can read -utrace as well. I see. My immediate reaction to this was that it should have more comments that make clear it's