I merged it all. But I tend to think the function pointer is overkill.
It's probably simpler and cleaner in the end to just store PTRACE_EVENT_*
and have a switch, or something like that.
Thanks,
Roland
I think we can do this optimization, but see below.
Nice work! I've merged it all.
Thanks,
Roland
1. Can't we set -reporting _after_ checking engine-flags ?
(unlikely)
I'm not sure...it is early the morning again. ;-)
2. Is utrace_barrier() correct Note the example above,
it assumes that utrace_barrier() itself is the barrier
wrt reporting.
Can't resist, I am sending this as a separate patch. Because I spent
3 hours debugging, and because the number and the ordering of these
changes doesn't matter.
As I said, I know that these initial changes of stop/resume model need
fixes, but I don't understand some failures. Will test/debug
On 09/09, Roland McGrath wrote:
But I tend to think the function pointer is overkill.
Yes, agreed. As I said, this code will be re-factored anyway.
I added this pointer just because it is a bit easier to me to
start the changes this way, currently I do not have the precise
plan.
Oleg.