[PATCH] utrace: utrace_get_signal() must check -pending_attach

2009-11-15 Thread Oleg Nesterov
On 11/15, Oleg Nesterov wrote: On 11/13, Oleg Nesterov wrote: Roland, I pulled the last changes in your tree (utrace-cleanup merged in utrace-ptrace) and did some testing. In short: utrace-ptrace does not work at all. It fails a lot (if not most) of tests, in particular

Re: [PATCH] utrace: finish_report() must never set -resume = UTRACE_STOP

2009-11-15 Thread Oleg Nesterov
On 11/15, Oleg Nesterov wrote: With this patch the kernel passes all tests except single-step ones, as expected. Forgot to mention, your tree lacks these patches we sent upstream: ptrace-introduce-user_single_step_siginfo-helper.patch

[PATCH] utrace: utrace_attach_task() forgets to return when -utrace == NULL

2009-11-15 Thread Oleg Nesterov
I forgot about make xcheck, it crashes the kernel. Fortunately the kernel dumps the stack trace. Trust me, it wasn't easy to notice the missing return ;) I am wondering why the compiler doesn't complain. Roland, this all needs more fixes. Look at the fixed code, utrace = target-utrace;

Re: [PATCH] utrace: utrace_attach_task() forgets to return when -utrace == NULL

2009-11-15 Thread Oleg Nesterov
On 11/16, Oleg Nesterov wrote: UPD: tested the kernel with this patch, now late-ptrace-may-attach-check crashes the kernel silently (no output under kvm). Repeated this test. Got several oopses, bad spinlock magic in utrace-lock. The stack trace varies, often from utrace_get_signal(). Oh,