GDB Testsuite Results with CONFIG_UTRACE

2009-11-24 Thread caiqian
Hello! The test was conducted on linux-2.6-utrace utrace-ptrace branch with and without CONFIG_UTRACE. The machine was an Intel x86_64 system. Biarch and other testing are under way. Here is the diff, and the results look similar. Detailed logs can be found at,

Re: [PATCH 1-13] utrace-ptrace V1, for internal review

2009-11-24 Thread Srikar Dronamraju
Hi Oleg, Roland, Ananth When I get the latest set of ptrace-tests by using. cvs -d :pserver:anoncvs:anon...@sources.redhat.com:/cvs/systemtap co ptrace-tests I get errors when I run make syscall-from-clone.c: In function ‘main’: syscall-from-clone.c:127: error: storage size of

[RFC,PATCH 0/14] utrace/ptrace

2009-11-24 Thread Oleg Nesterov
Hello. This is the new iteration of Roland's utrace patch, this time with rewrite-ptrace-via-utrace + cleanups in utrace core. 1-7 are already in -mm tree, I am sending them to simplify the review. 8-12 don not change the behaviour, simple preparations. 13-14 add utrace-ptrace and utrace

[RFC,PATCH 01/14] ptrace: cleanup ptrace_init_task()-ptrace_link() path

2009-11-24 Thread Oleg Nesterov
(already in mm: ptrace-cleanup-ptrace_init_task-ptrace_link-path.patch) No functional changes. ptrace_init_task() looks confusing, as if we always auto-attach when bool ptrace argument is true, while in fact we attach only if current is traced. Make the code more explicit and kill now unused

[RFC,PATCH 03/14] ptrace: introduce user_single_step_siginfo() helper

2009-11-24 Thread Oleg Nesterov
(already in mm: ptrace-introduce-user_single_step_siginfo-helper.patch) Suggested by Roland. Currently there is no way to synthesize a single-stepping trap in the arch-independent manner. This patch adds the default helper which fills siginfo_t, arch/ can can override it. Architetures which

[RFC,PATCH 04/14] ptrace: implement user_single_step_siginfo()

2009-11-24 Thread Oleg Nesterov
(already in mm: ptrace-powerpc-implement-user_single_step_siginfo.patch) Suggested by Roland. Implement user_single_step_siginfo() for powerpc. Signed-off-by: Oleg Nesterov o...@redhat.com Acked-by: Roland McGrath rol...@redhat.com --- arch/powerpc/include/asm/ptrace.h |2 ++

[RFC,PATCH 05/14] ptrace: change tracehook_report_syscall_exit() to handle stepping

2009-11-24 Thread Oleg Nesterov
(already in mm: ptrace-change-tracehook_report_syscall_exit-to-handle-stepping.patch) Suggested by Roland. Change tracehook_report_syscall_exit() to look at step flag and send the trap signal if needed. This change affects ia64, microblaze, parisc, powerpc, sh. They pass nonzero step argument

[RFC, PATCH 06/14] ptrace: x86: implement user_single_step_siginfo()

2009-11-24 Thread Oleg Nesterov
(already in mm: ptrace-x86-implement-user_single_step_siginfo.patch) Suggested by Roland. Implement user_single_step_siginfo() for x86. Extract this code from send_sigtrap(). Since x86 calls tracehook_report_syscall_exit(step = 0) the new helper is not used yet. Signed-off-by: Oleg Nesterov

[RFC,PATCH 07/14] ptrace: x86: change syscall_trace_leave() to rely on tracehook when stepping

2009-11-24 Thread Oleg Nesterov
(already in mm: ptrace-x86-change-syscall_trace_leave-to-rely-on-tracehook-when-stepping.patch) Suggested by Roland. Unlike powepc, x86 always calls tracehook_report_syscall_exit(step) with step = 0, and sends the trap by hand. This results in unnecessary SIGTRAP when PTRACE_SINGLESTEP follows

[RFC,PATCH 08/14] tracehooks: kill some PT_PTRACED checks

2009-11-24 Thread Oleg Nesterov
No functional changes, preparation for utrace-ptrace. task_ptrace() != 0 if and only if PT_PTRACED bit is set, kill some PT_PTRACED checks in tracehook.h to ensure the result is the same with or without utrace which doesn't set PT_PTRACED. Signed-off-by: Roland McGrath rol...@redhat.com

[RFC,PATCH 09/14] tracehooks: check PT_PTRACED before reporting the single-step

2009-11-24 Thread Oleg Nesterov
No functional changes, preparation for utrace-ptrace. tracehook_report_syscall_exit() and tracehook_signal_handler() assume that only ptrace can set TIF_SINGLESTEP. Currently this is true but we are going to change this, the stepping logic will be moved into utrace layer. Change this code to

[RFC,PATCH 11/14] export __ptrace_detach() and do_notify_parent_cldstop()

2009-11-24 Thread Oleg Nesterov
Export __ptrace_detach() and do_notify_parent_cldstop() for ptrace-utrace. Signed-off-by: Roland McGrath rol...@redhat.com Signed-off-by: Oleg Nesterov o...@redhat.com --- include/linux/ptrace.h |1 + include/linux/sched.h |1 + kernel/ptrace.c|2 +- kernel/signal.c

[RFC,PATCH 12/14] reorder the code in kernel/ptrace.c

2009-11-24 Thread Oleg Nesterov
No functional changes, preparation for the next patch. Move the code which can be shared with ptrace-utrace up, before __ptrace_link(). This way ptrace-utrace needs a single #ifdef in ptrace.c. Signed-off-by: Roland McGrath rol...@redhat.com Signed-off-by: Oleg Nesterov o...@redhat.com ---

Re: [RFC,PATCH 14/14] utrace core

2009-11-24 Thread Andi Kleen
Oleg Nesterov o...@redhat.com writes: From: Roland McGrath rol...@redhat.com This adds the utrace facility, a new modular interface in the kernel for implementing user thread tracing and debugging. This fits on top of the tracehook_* layer, so the new code is well-isolated. Could we just

Re: [RFC,PATCH 14/14] utrace core

2009-11-24 Thread Oleg Nesterov
On 11/24, Andi Kleen wrote: Oleg Nesterov o...@redhat.com writes: From: Roland McGrath rol...@redhat.com This adds the utrace facility, a new modular interface in the kernel for implementing user thread tracing and debugging. This fits on top of the tracehook_* layer, so the new code

Re: [RFC,PATCH 14/14] utrace core

2009-11-24 Thread Andi Kleen
On Tue, Nov 24, 2009 at 09:41:52PM +0100, Oleg Nesterov wrote: On 11/24, Andi Kleen wrote: Oleg Nesterov o...@redhat.com writes: From: Roland McGrath rol...@redhat.com This adds the utrace facility, a new modular interface in the kernel for implementing user thread tracing and

Re: [RFC,PATCH 14/14] utrace core

2009-11-24 Thread Frank Ch. Eigler
Hi - On Tue, Nov 24, 2009 at 10:26:19PM +0100, Andi Kleen wrote: [...] For example. tracehook_report_syscall_entry() has a lot of callers in arch/, each callsite should be changed to do if ((task_utrace_flags(current) UTRACE_EVENT(SYSCALL_ENTRY))

Re: [PATCH 1-13] utrace-ptrace V1, for internal review

2009-11-24 Thread Ananth N Mavinakayanahalli
On Tue, Nov 24, 2009 at 04:26:57PM +0100, Oleg Nesterov wrote: On 11/24, Ananth N Mavinakayanahalli wrote: ... step-jump-cont: step-jump-cont.c:140: pokeuser: Assertion `l == 0' failed. /bin/sh: line 4: 9070 Aborted ${dir}$tst FAIL: step-jump-cont errno 14 (Bad