[PATCH 1/4] utrace: kill mb() in tracehook_report_death()

2009-12-12 Thread Oleg Nesterov
As Peter pointed out, this barrier is not needed. utrace_set_events() and tracehook_report_death() can rely on tasklist_lock. utrace_set_events() checks -exit_state == 0 and adds DEATH_EVENTS under tasklist_lock. After exit_notify() sets -exit_state under write_lock(tasklist) we must see the

[PATCH 2/4] utrace: fix the -cloning check in utrace_attach_delay()

2009-12-12 Thread Oleg Nesterov
Due to typo, utrace_attach_delay() always succeeds if the caller is not traced. The creator must have the valid -utrace != NULL and utrace-cloning should be target. Signed-off-by: Oleg Nesterov o...@redhat.com --- kernel/utrace.c | 20 1 file changed, 12 insertions(+), 8

[PATCH 3/4] utrace: improve the comment in tracehook_notify_resume()

2009-12-12 Thread Oleg Nesterov
My attempt to make the comment more explicit. Signed-off-by: Oleg Nesterov o...@redhat.com --- include/linux/tracehook.h |7 --- 1 file changed, 4 insertions(+), 3 deletions(-) --- UTRACE-PTRACE/include/linux/tracehook.h~3_NOTIFY_RESUME_MB_COMMENT 2009-12-12 16:32:39.0 +0100

[PATCH 4/4] utrace: fix the comments about rmb() in task_utrace_struct()

2009-12-12 Thread Oleg Nesterov
Move the comment from utrace_task_alloc() to utrace_add_engine() and try to make it a bit more clear. Signed-off-by: Oleg Nesterov o...@redhat.com --- include/linux/utrace.h |4 ++-- kernel/utrace.c| 11 +-- 2 files changed, 7 insertions(+), 8 deletions(-) ---

(no subject)

2009-12-12 Thread Didomenico
inline: polygamize.jpg