Re: Tests Failures on PPC64

2009-12-13 Thread Roland McGrath
Yes. I straced gdb to be sure it really does PTRACE_SET_DEBUGREF to use the hardware watchpoint. There is something strange though. gdb does PTRACE_SINGLESTEP and only then PTRACE_CONT after watch xxx. powerpc's data breakpoints are before-access, whereas x86's are after-access. In

Re: [RFC,PATCH 14/14] utrace core

2009-12-13 Thread Roland McGrath
All that seems to do is call -release() and kmem_cache_free()s the utrace_engine thing, why can't that be done with utrace-lock held? Calling -release with a lock held is clearly insane, sorry. It is true that any engine-writer who does anything like utrace_* calls inside their release

Re: [RFC,PATCH 14/14] utrace core

2009-12-13 Thread Roland McGrath
I'm sorry for the delay. I'm picking up with responding to the parts of your review that I did not include in my first reply. I appreciate very much the discussion you've had with Oleg about the issues that I did not address myself. I look forward to your replies to my comments in that first

Re: step-into-handler.c compilation failure on ppc64

2009-12-13 Thread Jan Kratochvil
On Sat, 05 Dec 2009 18:19:20 +0100, Roland McGrath wrote: How about this? --- step-into-handler.c 10 Dec 2008 04:42:43 -0800 1.8 +++ step-into-handler.c 05 Dec 2009 09:18:54 -0800 [...] @@ -113,11 +114,11 @@ handler_alrm_get (void) { #if defined __powerpc64__