Trash Sessions - Sexta 18 Dezembro @ Bar O Seculo

2009-12-17 Thread VOID CREATIONS
Se não visualizares esta página correctamente, clica aqui http://www.divulgacaodigital.com/void-creations/newsletters/trash-sessions/2/email.html Adiciona-nos à tua safe-list, para garantir que recebes sempre a info dos nossos eventos. **

[PATCH 1/2] utrace: s/rmb/mb/ in tracehook_notify_resume()

2009-12-17 Thread Oleg Nesterov
It was always supposed to be mb(), not rmb(). Signed-off-by: Oleg Nesterov o...@redhat.com --- include/linux/tracehook.h | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) --- UTRACE_PTRACE/include/linux/tracehook.h~1_NOTIFY_RESUME_MB 2009-12-17 17:00:31.0 +0100 +++

[PATCH 2/2] utrace: move CONFIG_UTRACE after AUDITSYSCALL in init/Kconfig

2009-12-17 Thread Oleg Nesterov
Somehow I placed CONFIG_UTRACE between AUDIT and AUDITSYSCALL, move it down after AUDITSYSCALL. Signed-off-by: Oleg Nesterov o...@redhat.com --- init/Kconfig | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) --- UTRACE_PTRACE/init/Kconfig~2_CONFIG_UTRACE_AUDIT

x86: do_debug PTRACE_SINGLESTEP broken by 08d68323d1f0c34452e614263b212ca556dae47f

2009-12-17 Thread Oleg Nesterov
Hi. do_debug() is obviously wrong wrt PTRACE_SINGLESTEP/TIF_SINGLESTEP, no? Afaics this was broken by hw-breakpoints: modifying generic debug exception to use thread-specific debug registers commit 08d68323d1f0c34452e614263b212ca556dae47f To verify, the patch below fixes the

[PATCH 3/7] ptrace_signal: check PT_PTRACED before reporting a signal

2009-12-17 Thread Oleg Nesterov
No functional changes, preparation for utrace-ptrace. Change ptrace_signal() to check PT_PTRACED instead of task_ptrace() != 0. Currently this is the same, PT_PTRACED must be always set if the task is ptraced. This change is needed to make sure ptrace_signal() does nothing if ptrace is

[PATCH 4/7] export __ptrace_detach() and do_notify_parent_cldstop()

2009-12-17 Thread Oleg Nesterov
Export __ptrace_detach() and do_notify_parent_cldstop() for ptrace-utrace. Signed-off-by: Roland McGrath rol...@redhat.com Signed-off-by: Oleg Nesterov o...@redhat.com --- include/linux/ptrace.h |1 + include/linux/sched.h |1 + kernel/ptrace.c|2 +- kernel/signal.c

[PATCH 5/7] reorder the code in kernel/ptrace.c

2009-12-17 Thread Oleg Nesterov
No functional changes, preparation for the next patch. Move the code which can be shared with ptrace-utrace up, before __ptrace_link(). This way ptrace-utrace needs a single #ifdef in ptrace.c. Signed-off-by: Roland McGrath rol...@redhat.com Signed-off-by: Oleg Nesterov o...@redhat.com ---

[PATCH 6/7] implement utrace-ptrace

2009-12-17 Thread Oleg Nesterov
The patch adds the new file, kernel/ptrace-utrace.c, which contains the new implementation of ptrace over utrace. This file is not compiled until we have CONFIG_UTRACE option, will be added by the next utrace core patch. It's supposed to be an invisible implementation change, nothing should

Re: x86: do_debug PTRACE_SINGLESTEP broken by 08d68323d1f0c34452e614263b212ca556dae47f

2009-12-17 Thread Roland McGrath
Comparing to the old (2.6.32) logic, I think it might be this (untested). I also note this is the sole use of get_si_code, seems like it should just be rolled in here. Thanks, Roland diff --git a/arch/x86/kernel/traps.c b/arch/x86/kernel/traps.c index 3339917..16a88f5 100644 ---

Re: x86: do_debug PTRACE_SINGLESTEP broken by 08d68323d1f0c34452e614263b212ca556dae47f

2009-12-17 Thread Oleg Nesterov
On 12/17, Roland McGrath wrote: Comparing to the old (2.6.32) logic, I think it might be this (untested). I also note this is the sole use of get_si_code, seems like it should just be rolled in here. Well, it is too late for me to even try to read this patch ;) but... @@ -569,14 +568,15 @@

Re: x86: do_debug PTRACE_SINGLESTEP broken by 08d68323d1f0c34452e614263b212ca556dae47f

2009-12-17 Thread Frederic Weisbecker
On Fri, Dec 18, 2009 at 03:10:42AM +0100, Oleg Nesterov wrote: On 12/17, Roland McGrath wrote: Comparing to the old (2.6.32) logic, I think it might be this (untested). I also note this is the sole use of get_si_code, seems like it should just be rolled in here. Well, it is too late

Re: x86: do_debug PTRACE_SINGLESTEP broken by 08d68323d1f0c34452e614263b212ca556dae47f

2009-12-17 Thread Roland McGrath
+ dr6 = tsk-thread.debugreg6; why? we have tsk-thread.debugreg6 = dr6 above Yeah, it's a little superfluous. Except that the existing code uses tsk-thread.debugreg6 and dr6 inconsistently. It only matters either way if some notifier function might change thread.debugreg6, which I wasn't