I don't know this area well, but considering that ser-unix.c is just
chock full of tty-related goo, I think it is probably important for
something. My impression is that this API is not just used for target
communication but also for manipulating gdb's own terminal.
Ah, I see.
I've
Roland However, I think the test you probably want is !S_ISCHR.
Thanks. I wasn't sure.
Roland Actually, better yet, just make it !isatty (fd).
Ok.
I made a new branch, 'archer-ugdb'.
This patch is there. (Actually 2 patches due to me not reading
carefully enough the first time -- but
On 08/13, Tom Tromey wrote:
Roland However, I think the test you probably want is !S_ISCHR.
Thanks. I wasn't sure.
Roland Actually, better yet, just make it !isatty (fd).
Ok.
Good. IIUC, this also allows to remove the ugly return 0
to pretend TCGETS/TCSETS/TCFLSH works from -ioctl().
I
I seem to understand the problem(s). I am a bit surprized. Basically
I have the questions about almost every utrace_ function. I'll try
to recheck and summarize my concerns tomorrow with a fresh head, I
hope I missed something.
Ok. That stuff about pure kernel implementation issues doesn't
No changes in the compiled code. Just make the code parsable by humans.
Signed-off-by: Oleg Nesterov o...@redhat.com
---
kernel/utrace.c | 16 +---
1 file changed, 9 insertions(+), 7 deletions(-)
--- kstub/kernel/utrace.c~1_use_cleanup_exit_state_checks 2010-08-14
I am not sure this fix is really needed, up to you.
But please note that this code
if ((utrace-death (cleared _UTRACE_DEATH_EVENTS)) ||
(utrace-reap (cleared UTRACE_EVENT(REAP {
spin_unlock(utrace-lock);
