Re: [PATCH] Embed struct utrace in task_struct - V2

2009-01-20 Thread Ananth N Mavinakayanahalli
On Mon, Jan 19, 2009 at 03:20:31PM -0800, Roland McGrath wrote: > Thanks for working on this, Ananth. (Btw, it's "embed.") > > I think it would be less disruptive (and materially no different) > to leave utrace_flags as it is. That field is the one (and only) > that is used in hot paths (or used

Re: [PATCH] Embed struct utrace in task_struct - V2

2009-02-22 Thread Ananth N Mavinakayanahalli
On Wed, Jan 21, 2009 at 11:58:25AM +0530, Ananth N Mavinakayanahalli wrote: > On Mon, Jan 19, 2009 at 03:20:31PM -0800, Roland McGrath wrote: > > Thanks for working on this, Ananth. (Btw, it's "embed.") > > > > I think it would be less disruptive (and materially no different) > > to leave utrace_

Re: [PATCH] Embed struct utrace in task_struct - V2

2009-03-02 Thread Roland McGrath
Hi, Ananth. Sorry everything has slid so long (again). (I have far too many hats and the past month not so many brains!) Here is my immediate agenda for utrace hacking: * I have incorporated the "embed struct utrace" changes. I did various small bits of reorganization and cosmetic cleanup f

Re: [PATCH] Embed struct utrace in task_struct - V2

2009-03-02 Thread Chris Moller
Roland, Is this going to make into F11? Or is it too early to tell that yet? Roland McGrath wrote: > Hi, Ananth. Sorry everything has slid so long (again). > (I have far too many hats and the past month not so many brains!) > > Here is my immediate agenda for utrace hacking: > > -- Chris M

Re: [PATCH] Embed struct utrace in task_struct - V2

2009-03-02 Thread Roland McGrath
> Is this going to make into F11? Or is it too early to tell that yet? F11 will have the latest utrace code at the time F11 freezes, certainly. Thanks, Roland

Re: [PATCH] Embed struct utrace in task_struct - V2

2009-03-02 Thread Ananth N Mavinakayanahalli
On Mon, Mar 02, 2009 at 04:07:54AM -0800, Roland McGrath wrote: > Hi, Ananth. Sorry everything has slid so long (again). > (I have far too many hats and the past month not so many brains!) I understand. Thanks for the work, Roland. > Here is my immediate agenda for utrace hacking: > > * I have

Re: [PATCH] Embed struct utrace in task_struct - V2

2009-03-03 Thread Frank Ch. Eigler
roland wrote: > After this change, we now need some fresh testing of things like Frank's > ftrace widget and stap's utrace-using modes. (Nothing should have > changed from the utrace API perspective.) Righto. > * I've renamed "struct utrace_attached_engine" to "struct utrace_engine". >

Re: [PATCH] Embed struct utrace in task_struct - V2

2009-03-03 Thread Roland McGrath
> > * When we on the team think the utrace patch is ready to post, we need to > > do a coordinated post of Frank's ftrace widget. [...] > > Would you consider simply merging it into your git tree / patch suite? Sure. The way to do that is for you to publish a git repository that I can pull fr

Re: [PATCH] Embed struct utrace in task_struct - V2

2009-03-05 Thread Roland McGrath
> There is at least one change from the earlier behaviour -- rather than > utrace_attach_task() retrying by itself on a !parent attach, -EAGAIN is > returned to the user. That may need changes to the utrace client side. Oops, that was not intentional. I've restored the old behavior. > I've just

Re: [PATCH] Embed struct utrace in task_struct - V2

2009-03-05 Thread Jason Baron
Roland McGrath redhat.com> writes: > > Hi, Ananth. Sorry everything has slid so long (again). > (I have far too many hats and the past month not so many brains!) > > Here is my immediate agenda for utrace hacking: > > * I have incorporated the "embed struct utrace" changes. > > I did vario

Re: [PATCH] Embed struct utrace in task_struct - V2

2009-03-05 Thread Roland McGrath
> i've been looking at the patch at the utrace.patch at: > > http://people.redhat.com/roland/utrace/2.6-current/ > > hopefully, that's the latest one. Yes, it's updated frequently. The .id files tell you what git commit the patch corresponds to, so we can be mutually clear in making references

Re: [PATCH] Embed struct utrace in task_struct - V2

2009-03-06 Thread Frank Ch. Eigler
Hi - On Tue, Mar 03, 2009 at 03:14:01PM -0800, Roland McGrath wrote: > > > * When we on the team think the utrace patch is ready to post, we need to > > > do a coordinated post of Frank's ftrace widget. [...] > > > > Would you consider simply merging it into your git tree / patch suite? > > S

Re: [PATCH] Embed struct utrace in task_struct - V2

2009-03-06 Thread Roland McGrath
> http://web.elastic.org/~fche/git/linux-2.6-utrace.git utrace-ftrace > > Frank Ch. Eigler (1): > utrace-based ftrace "process" engine, v2 Thanks, Frank. Your branch is now in my repo and its patch generated in 2.6-current/. I'll pull periodically, or let me know if my repo lags behind