Re: [PATCH 0/4] utrace-resume fixes

2009-11-20 Thread Oleg Nesterov
On 11/18, Roland McGrath wrote: So maybe you will look at this and merge them before I do. Whatever we do, perhaps it makes sense to apply your patch in https://www.redhat.com/archives/utrace-devel/2009-November/msg00109.html first and then do further changes? This way we will have the working

Re: [PATCH 0/4] utrace-resume fixes

2009-11-20 Thread Roland McGrath
Whatever we do, perhaps it makes sense to apply your patch in https://www.redhat.com/archives/utrace-devel/2009-November/msg00109.html first and then do further changes? Ok. v2.6.32-rc8-245-g3d4f9cf has that. I'll shelve this 4-patch series while we keep discussing (one more reply to come

Re: [PATCH 0/4] utrace-resume fixes

2009-11-20 Thread Roland McGrath
Somehow I can't really understand this patch. I hope more or less I can see what it does, but the resulting code looks even more subtle to me. Well, it was an untested draft and probably needed more comments. With this patch, apply_resume_action() is always called after utrace_stop(). Well,

[PATCH 0/4] utrace-resume fixes

2009-11-18 Thread Oleg Nesterov
On top of your patch in https://www.redhat.com/archives/utrace-devel/2009-November/msg00109.html I attached this patch below just in case. As expected, it fixes the problem with the lost TIF_SINGLESTEP. Oleg. --- UTRACE-PTRACE/kernel/utrace.c~__ROLAND_RESUME_FIX 2009-11-18 21:16:23.0