Re: [PATCH 100-103] ptrace_resume cleanup/simplification

2009-10-20 Thread Roland McGrath
What about PTRACE_SYSEMU_SINGLESTEP ? I will read the code tomorrow, but it is easy to miss some detail and we don't have any test-cases. These exist purely for UML. So the real test cases are to use UML. To start with, make sure that check_sysemu() gets the same results as on the vanilla

Re: [PATCH 100-103] ptrace_resume cleanup/simplification

2009-10-19 Thread Oleg Nesterov
On 10/18, Oleg Nesterov wrote: The semantics is that the entry report always does like UTRACE_SYSCALL_ABORT to skip the actual call, and then there is no exit report. Thanks! this is easy. Hmm. This is not what I see in upstream kernel... Afaics, PTRACE_SYSEMU means: - cancel

Re: [PATCH 100-103] ptrace_resume cleanup/simplification

2009-10-19 Thread Oleg Nesterov
On 10/19, Oleg Nesterov wrote: On 10/18, Oleg Nesterov wrote: The semantics is that the entry report always does like UTRACE_SYSCALL_ABORT to skip the actual call, and then there is no exit report. Thanks! this is easy. Hmm. This is not what I see in upstream kernel... Afaics,

Re: [PATCH 100-103] ptrace_resume cleanup/simplification

2009-10-19 Thread Oleg Nesterov
On 10/19, Oleg Nesterov wrote: On 10/19, Oleg Nesterov wrote: On 10/18, Oleg Nesterov wrote: The semantics is that the entry report always does like UTRACE_SYSCALL_ABORT to skip the actual call, and then there is no exit report. Thanks! this is easy. Hmm. This is not

[PATCH 100-103] ptrace_resume cleanup/simplification

2009-10-18 Thread Oleg Nesterov
Cleanups. Tomorrow: PTRACE_SYSEMU/PTRACE_SYSEMU_SINGLESTEP The semantics is that the entry report always does like UTRACE_SYSCALL_ABORT to skip the actual call, and then there is no exit report. Thanks! this is easy. What about PTRACE_SYSEMU_SINGLESTEP ? I will read the code tomorrow, but