On 08/16, Roland McGrath wrote:
>
> > In short: this double check allows to avoid tasklist when utrace_flags
> > already has these bits while engine->flags doesn't.
> >
> > But multitracing is unlikely case, in the likely case if we add
> > _UTRACE_DEATH_EVENTS to engine->flags we set these bits in
> utrace_set_events() checks the "setting _UTRACE_DEATH_EVENTS" case twice,
> and it is not immediately obvious why the first check is needed, and why
> it is not racy (we are checking exit_state without tasklist). The code is
> correct, but looks confusing.
More comments are always good.
> In sh
> Hmm. For unknown reason I do not see this 2/4 patch on utrace-devel,
> strange.
>
> So I am attaching it in case my email was really lost and you didn't
> get it.
Indeed, it did not come through to me or the list.
Thanks,
Roland
Hmm. For unknown reason I do not see this 2/4 patch on utrace-devel,
strange.
So I am attaching it in case my email was really lost and you didn't
get it.
Oleg.
[PATCH 2/4] utrace_set_events: consolidate "setting _UTRACE_DEATH_EVENTS" checks
utrace_set_events() chec
