Re: [PATCH 56] ptrace_resume_signal() should use context-siginfo under -siglock

2009-09-25 Thread Roland McGrath
- Change ptrace_resume_signal() to use context-siginfo under -siglock, like ptrace_{get,set}siginfo() do. I don't think the log/comments give a clear picture of why this is the thing to do. To wit, I'm not even sure at the moment it is necessary. It probably is, but I have to convince myself

Re: [PATCH 56] ptrace_resume_signal() should use context-siginfo under -siglock

2009-09-25 Thread Oleg Nesterov
On 09/25, Roland McGrath wrote: - Change ptrace_resume_signal() to use context-siginfo under -siglock, like ptrace_{get,set}siginfo() do. I don't think the log/comments give a clear picture of why this is the thing to do. To wit, I'm not even sure at the moment it is necessary. It

[PATCH 56] ptrace_resume_signal() should use context-siginfo under -siglock

2009-09-23 Thread Oleg Nesterov
- Change ptrace_resume_signal() to use context-siginfo under -siglock, like ptrace_{get,set}siginfo() do. - Document why this is safe. - Also, use ACCESS_ONCE() which implies the compiler barrier. This is only theoretical issue, but still. --- kernel/ptrace.c | 27