Re: Q: ->attaching && REPORT_CALLBACKS()

2009-03-12 Thread Oleg Nesterov
On 03/11, Roland McGrath wrote: > > > But not vise versa. I misunderstood the comment as if the new engine > > should not be notified if it is attached by another task while target > > is inside callback. > > That is indeed what happens in that case. But that one is not a > specific "should not",

Re: Q: ->attaching && REPORT_CALLBACKS()

2009-03-11 Thread Roland McGrath
> But not vise versa. I misunderstood the comment as if the new engine > should not be notified if it is attached by another task while target > is inside callback. That is indeed what happens in that case. But that one is not a specific "should not", it's just what happens to be true given what

Re: Q: ->attaching && REPORT_CALLBACKS()

2009-03-11 Thread Oleg Nesterov
On 03/10, Roland McGrath wrote: > > > The comment: > > > > * When target == current, it would be safe just to call > > * splice_attaching() right here. But if we're inside a > > * callback, > > > > just to clarify, "inside a callback" means inside utrace_report_xxx(), > > not only insi

Re: Q: ->attaching && REPORT_CALLBACKS()

2009-03-10 Thread Roland McGrath
> The comment: > > * When target == current, it would be safe just to call > * splice_attaching() right here. But if we're inside a > * callback, > > just to clarify, "inside a callback" means inside utrace_report_xxx(), > not only inside utrace_engine_ops->report_xxx(), right?

Q: ->attaching && REPORT_CALLBACKS()

2009-03-10 Thread Oleg Nesterov
Despite the fat comment in utrace_add_engine() I can't really understand the meaning of ->attaching list. The comment: * When target == current, it would be safe just to call * splice_attaching() right here. But if we're inside a * callback, just to clarify, "inside a ca