LGTM.
On Tue, Sep 16, 2008 at 4:30 PM, <[EMAIL PROTECTED]> wrote:
> Reviewers: Kasper Lund, christian.plesner.hansen,
>
> Message:
> Kasper, I renamed the flags.defs file as we discussed and excluded it in
> the presubmit tool.
>
> Christian, can you please review if I did update the presubmit.p
Issue 24: Javascript error from V8 inside of Chrome
http://code.google.com/p/v8/issues/detail?id=24
Comment #13 by [EMAIL PROTECTED]:
More information will be available in about:version in later versions. If
you are
interested, you could change to the dev channel to get access to fixes
earli
On Tue, Sep 16, 2008 at 9:17 PM, Kasper Lund <[EMAIL PROTECTED]> wrote:
> My main concern with this approach is that the test case you're
> proposing is likely to pass even without fixing the bug -- as long as
> you're running a version that doesn't include the stack balance
> checking code in Vis
My main concern with this approach is that the test case you're
proposing is likely to pass even without fixing the bug -- as long as
you're running a version that doesn't include the stack balance
checking code in VisitSwitch everything will look just fine. This is
not a good way to write a regre
Issue 78: String objects vs string literals -- Value::IsString()
http://code.google.com/p/v8/issues/detail?id=78
Comment #1 by joelnordell:
Here is a workaround:
using namespace v8;
static Handle printString(const Arguments &args) {
Local val = args[0];
if (val->IsString()) {
printf("
Issue 77: Value::IsDate() and Date::Value()
http://code.google.com/p/v8/issues/detail?id=77
Comment #1 by joelnordell:
Here is a workaround until this functionality is added to the API:
using namespace v8;
static Handle printDateValue(const Arguments &args) {
Local val = args[0];
if (val->
Issue 76: Check balanced stack for each statement.
http://code.google.com/p/v8/issues/detail?id=76
Comment #1 by [EMAIL PROTECTED]:
I have a nearly completed change list that does exactly that (for
expressions as
well). It will be a week and a half before I get back to it, but you can
feel f
Issue 78: String objects vs string literals -- Value::IsString()
http://code.google.com/p/v8/issues/detail?id=78
New issue report by joelnordell:
When a value is passed in to a FunctionTemplate, if the value was a string
literal then Value::IsString() returns true. But, if the value was a
String
Issue 77: Value::IsDate() and Date::Value()
http://code.google.com/p/v8/issues/detail?id=77
New issue report by joelnordell:
The public API has a way to construct a Date object, but as far as I can
tell no way to extract its value. Also, there is no way to tell if you
have a Date object when giv
Issue 24: Javascript error from V8 inside of Chrome
http://code.google.com/p/v8/issues/detail?id=24
Comment #12 by getify:
This is what I see:
0.2.149.29 (1798)
Official Build
Google Inc.
Copyright © 2006-2008 Google Inc. All Rights Reserved.
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US) AppleW
As Ivan and I discussed offline, it is better to have stack balance
checking code in VisitSwitch and make the test case only have switch
with break statement. The current test relies on TryCatch to catch the
error, and this may happen far away from the real cause of the
problem.
We discussed to
Issue 76: Check balanced stack for each statement.
http://code.google.com/p/v8/issues/detail?id=76
New issue report by [EMAIL PROTECTED]:
This is a spin-off idea of issue 69. It can help catch errors if we check
stack balance for each
statement (except some special cases).
Issue attributes:
Issue 75: Try/Finally corrupts line number
http://code.google.com/p/v8/issues/detail?id=75
New issue report by [EMAIL PROTECTED]:
When using a finally statement, the native Message object that will be
passed to code contains the line number of the last line of the finally
statement, not the line
Issue 69: Crash on http://www.steev.net
http://code.google.com/p/v8/issues/detail?id=69
Comment #11 by [EMAIL PROTECTED]:
Thanks.
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notificat
Author: [EMAIL PROTECTED]
Date: Tue Sep 16 07:37:24 2008
New Revision: 319
Modified:
branches/bleeding_edge/tools/v8.xcodeproj/project.pbxproj
Log:
Added presubmit.py to the tools tab for easier access.
TBR=mark
Review URL: http://codereview.chromium.org/2892
Modified: branches/bleeding_ed
Reviewers: Kasper Lund, christian.plesner.hansen,
Message:
Kasper, I renamed the flags.defs file as we discussed and excluded it in
the presubmit tool.
Christian, can you please review if I did update the presubmit.py tool
correctly?
Thanks,
-Ivan
Description:
- Rename flags.defs to flag-def
Issue 24: Javascript error from V8 inside of Chrome
http://code.google.com/p/v8/issues/detail?id=24
Comment #11 by mads.ager:
One easy way to tell is to go to about:version in Google Chrome. When the
V8 version
says 0.3.2 or above you should have this fix.
-- Mads
--
You received this mes
17 matches
Mail list logo
