LGTM
http://codereview.chromium.org/3181
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
-~--~~~~--~~--~--~---
Reviewers: Søren Gjesse,
Description:
Add compilation flags for optimizing samples built in release
mode. Remove /Ob2 /Oi /Oy from VS build because they are
already enabled by /Ox.
Please review this at http://codereview.chromium.org/4012
Affected files:
M SConstruct
Index: SConstruct
=
Author: [EMAIL PROTECTED]
Date: Mon Sep 22 01:06:25 2008
New Revision: 351
Added:
data/site/lZnaaUoHPhs-embed.jpg (contents, props changed)
Log:
Added image for the site
Added: data/site/lZnaaUoHPhs-embed.jpg
==
B
LGTM. If you want to save even more space you could have a specialized
version of V8_Fatal -- called V8_Unimplemented or something -- that
doesn't take any parameters. We should also fix the naming of V8_Fatal
-- why is there an underscore in it? Weird...
On Sat, Sep 20, 2008 at 7:24 PM, <[EMAIL
On 2008/09/22 08:00:41, Kasper Lund wrote:
>
LGTM
Dose it make a difference to have the (sample) shell compiled with
optimizations?
http://codereview.chromium.org/4012
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/gro
Author: [EMAIL PROTECTED]
Date: Mon Sep 22 01:27:54 2008
New Revision: 352
Modified:
branches/bleeding_edge/SConstruct
Log:
Add compilation flags for optimizing samples built in release
mode. Remove /Ob2 /Oi /Oy from VS build because they are
already enabled by /Ox.
Review URL: http://codere
Issue 78: String objects vs string literals -- Value::IsString()
http://code.google.com/p/v8/issues/detail?id=78
Comment #2 by kodandersson:
The distinction is between string values and String (wrapper) objects. The
documentation for Value::IsString refers to section 8.4 of ECMA-262, which
desc
Author: [EMAIL PROTECTED]
Date: Mon Sep 22 02:22:18 2008
New Revision: 353
Modified:
branches/bleeding_edge/src/checks.h
Log:
In release, disable UNREACHABLE and make UNIMPLEMENTED and FATAL simpler,
removing the file name and line numbers, so we carry around less data and
can share more
Issue 80: r350 SConstruct fails with SCons 1.0.1
http://code.google.com/p/v8/issues/detail?id=80
Comment #1 by [EMAIL PROTECTED]:
Could you provide more information about which version of V8 you're trying
to build
and on which platform?
Another thing that would really be helpful is the values
http://codereview.chromium.org/2926
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
-~--~~~~--~~--~--~---
Issue 80: r350 SConstruct fails with SCons 1.0.1
http://code.google.com/p/v8/issues/detail?id=80
Comment #2 by patterner:
--- SConstruct (revision 353)
+++ SConstruct (working copy)
@@ -379,6 +379,7 @@
if not key in options:
options[key] = value
else:
+print "K
Issue 80: r350 SConstruct fails with SCons 1.0.1
http://code.google.com/p/v8/issues/detail?id=80
Comment #3 by patterner:
1> unset CXXFLAGS; scons
scons: Reading SConscript files ...
Key=CCFLAGS; value=['-O2'];
Key=CCFLAGS; value=['-m32'];
Key=CXXFLAGS; value=[];
Key=CPPDEFINES; value=['SUPPORT_
Issue 80: r350 SConstruct fails with SCons 1.0.1
http://code.google.com/p/v8/issues/detail?id=80
Comment #4 by [EMAIL PROTECTED]:
Thanks a lot for the extra information and sorry for not noticing the
revision number
in the title. I'll take a look at this.
Issue attribute updates:
Stat
Issue 80: r350 SConstruct fails with SCons 1.0.1
http://code.google.com/p/v8/issues/detail?id=80
Comment #5 by patterner:
The platform is a x86_64 Gentoo Linux.
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You
Reviewers: christian.plesner.hansen,
Description:
Work around issue 80 by splitting strings from the environment
variables into lists before appending to them.
Please review this at http://codereview.chromium.org/3185
Affected files:
M SConstruct
Index: SConstruct
=
The V8 API is a C++ interface which on Windows is exported to the DLL
using __declspec(dllexport). When an application is build the C++ interface
is imported using __declspec(dllimport). This woks fine when Microsoft C++
is used for compiling both the DLL and the application using the DLL as the
sa
Reviewers: bak,
Description:
Refactor the enum RelocMode changing the naming scheme from lower case
to
upper case. Moved it into the RelocInfo class together with the
associated
is_xxx functions. Renames is_xxx to IsXxx in the process.
Removed the exit_js_frame mode as it was no longer used.
Pl
I do like the UNREACHABLE because it signals that something went really
wrong. But I am not sure if it is more useful than an ASSERT.
I do like Kasper's suggestion to simplifying the UNIMPLEMENTED call's
implementation.
http://codereview.chromium.org/4008
--~--~-~--~~~--
LGTM,
Lars
http://codereview.chromium.org/3186
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
-~--~~~~--~~--~--~---
Issue 81: V8 Garbage collector removes referenced(still used) items.
http://code.google.com/p/v8/issues/detail?id=81
New issue report by sjoerdmulder:
When using XML documents, and certain elements are referenced. It seems
that Google Chrome is cleaning up the XML document top greedy, e.g.
parent
Author: [EMAIL PROTECTED]
Date: Mon Sep 22 07:49:37 2008
New Revision: 355
Added:
wiki/DebuggerProtocol.wiki
Log:
Created wiki page through web user interface.
Added: wiki/DebuggerProtocol.wiki
==
--- (empty file)
+
As we try to keep the SCons and VS builds in sync I think we should add /GF
to the linking of the V8 library in SConstructs - but not to the linking of
the samples I guess.
/Søren
On Sun, Sep 21, 2008 at 4:38 PM, Kasper Lund <[EMAIL PROTECTED]> wrote:
>
> Should we use the same flag in the SConst
Sorry about the delay. Lgtm.
There's a bunch of whitespace changes in there. Maybe we should lint
out python files for trailing whitespace in the presubmit script.
On Mon, Sep 22, 2008 at 1:14 PM, <[EMAIL PROTECTED]> wrote:
> Reviewers: christian.plesner.hansen,
>
> Description:
> Work around
Author: [EMAIL PROTECTED]
Date: Mon Sep 22 08:50:30 2008
New Revision: 356
Modified:
branches/bleeding_edge/SConstruct
Log:
Work around issue 80 by splitting strings from the environment
variables into lists before appending to them.
Review URL: http://codereview.chromium.org/3185
Modified:
On Mon, Sep 22, 2008 at 5:48 PM, Christian Plesner Hansen
<[EMAIL PROTECTED]> wrote:
> There's a bunch of whitespace changes in there. Maybe we should lint
> out python files for trailing whitespace in the presubmit script.
I think that's a good idea. I just removed the trailing white space I
st
Reviewers: Erik Corry, Kasper Lund,
Description:
Remove debugging code that snuck in with the ARM calling convention
changes.
Thanks to Erik Corry for spotting this.
Please review this at http://codereview.chromium.org/4015
Affected files:
M src/builtins-arm.cc
Index: src/builtins-arm
Issue 80: r350 SConstruct fails with SCons 1.0.1
http://code.google.com/p/v8/issues/detail?id=80
Comment #6 by [EMAIL PROTECTED]:
I have submitted a workaround in revision 356. Right now, the flags
specified in the
SConstruct file are appended to any flags defined in environment variables
whi
LGTM. Sorry for not spotting this earlier.
On Mon, Sep 22, 2008 at 5:54 PM, <[EMAIL PROTECTED]> wrote:
> Reviewers: Erik Corry, Kasper Lund,
>
> Description:
> Remove debugging code that snuck in with the ARM calling convention
> changes.
> Thanks to Erik Corry for spotting this.
>
>
> Please re
Issue 82: Check for trailing whitespace in Python files
http://code.google.com/p/v8/issues/detail?id=82
New issue report by christian.plesner.hansen:
Have the presubmit check lint Python (and scons) files for trailing
whitespace.
Issue attributes:
Status: Accepted
Owner: chris
Author: [EMAIL PROTECTED]
Date: Mon Sep 22 09:00:56 2008
New Revision: 357
Modified:
branches/bleeding_edge/src/builtins-arm.cc
Log:
Remove debugging code that snuck in with the ARM calling convention changes.
Thanks to Erik Corry for spotting this.
Review URL: http://codereview.chromium.or
Issue 80: r350 SConstruct fails with SCons 1.0.1
http://code.google.com/p/v8/issues/detail?id=80
Comment #7 by patterner:
r357 works for me.
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your is
Issue 80: r350 SConstruct fails with SCons 1.0.1
http://code.google.com/p/v8/issues/detail?id=80
Comment #8 by patterner:
r357 works for me.
[00:23|% 100|+ 517|- 0]: Done (tools/test.py)
--
You received this message because you are listed in the owner
or CC fields of this issue, or beca
Issue 80: r350 SConstruct fails with SCons 1.0.1
http://code.google.com/p/v8/issues/detail?id=80
Comment #9 by [EMAIL PROTECTED]:
Thanks for the super quick feedback.
Issue attribute updates:
Status: Fixed
--
You received this message because you are listed in the owner
or CC fields o
Issue 83: [documentation] Need documentation for profiler
http://code.google.com/p/v8/issues/detail?id=83
New issue report by [EMAIL PROTECTED]:
The V8 profiler needs to be documented on a Wiki page.
Issue attributes:
Status: New
Owner:
Labels: Type-FeatureRequest P
Issue 78: String objects vs string literals -- Value::IsString()
http://code.google.com/p/v8/issues/detail?id=78
Comment #3 by joelnordell:
May I suggest that for the C++ API, the distinction between string values
and String
objects is not so important? I think that String objects should behav
Soren,
Thank you for your fast answer! :-)
First, let me say that you guys are starting a Revolution! Web 3.0 is
coming powered by v8 and Chrome!... :-D
Back to the dll...
Before trying to compile the v8 dll I built a wrapper dll with just
one function but the Delphi app that uses the dll thro
I want to join this group, please do the needful.
Regards,
Loya
9000977071
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
-~--~~~~--~~--~--~---
Issue 81: V8 Garbage collector removes referenced(still used) items.
http://code.google.com/p/v8/issues/detail?id=81
Comment #1 by [EMAIL PROTECTED]:
(No comment was entered for this change.)
Issue attribute updates:
Owner: [EMAIL PROTECTED]
--
You received this message because you ar
Reviewers: bak,
Description:
Change the logging information for generated stubs to be
consistent with the other log events for generated code.
Please review this at http://codereview.chromium.org/4033
Affected files:
M src/code-stubs.cc
Index: src/code-stubs.cc
39 matches
Mail list logo
