Reviewers: Christian Plesner Hansen,
Description:
Implement $ for non-multiline.
Please review this at http://codereview.chromium.org/10992
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M src/assembler-irregexp.h
M src/assembler-irregexp.cc
M
Author: [EMAIL PROTECTED]
Date: Fri Nov 28 00:41:54 2008
New Revision: 861
Added:
branches/experimental/toiger/src/register-allocator-ia32.cc
branches/experimental/toiger/src/register-allocator-ia32.h
branches/experimental/toiger/src/register-allocator.h
Modified:
branches/experim
Stv!
http://codereview.chromium.org/10992/diff/1/16
File src/jsregexp.cc (right):
http://codereview.chromium.org/10992/diff/1/16#newcode2342
Line 2342: // TODO(erikcorry): A back reference has to have two
successors (by default
I wonder if maybe we always have to propagate to the on-failure
con
Author: [EMAIL PROTECTED]
Date: Fri Nov 28 00:53:53 2008
New Revision: 862
Modified:
branches/bleeding_edge/src/assembler-irregexp.cc
branches/bleeding_edge/src/assembler-irregexp.h
branches/bleeding_edge/src/bytecodes-irregexp.h
branches/bleeding_edge/src/flag-definitions.h
b
Reviewers: William Hesse, iposva,
Message:
Without allocating locals to registers, we are not yet doing better than
the peephole optimizer.
Ivan, I'd still appreciate your comments but I will probably submit this
before the end of the day.
Description:
Begin using the virtual frame for assignme
Author: [EMAIL PROTECTED]
Date: Fri Nov 28 01:08:13 2008
New Revision: 863
Modified:
branches/bleeding_edge/src/regexp-macro-assembler.h
Log:
Lint lint lint.
Modified: branches/bleeding_edge/src/regexp-macro-assembler.h
===
Author: [EMAIL PROTECTED]
Date: Fri Nov 28 01:51:26 2008
New Revision: 864
Modified:
branches/bleeding_edge/src/jsregexp.cc
Log:
Calling native irregexp now returns captures correctly.
Reduces failing tests in native mode to 2(!)
Modified: branches/bleeding_edge/src/jsregexp.cc
===
Author: [EMAIL PROTECTED]
Date: Fri Nov 28 02:37:06 2008
New Revision: 865
Added:
branches/bleeding_edge/src/regexp-macro-assembler-irregexp-inl.h
(contents, props changed)
- copied, changed from r862,
/branches/bleeding_edge/src/assembler-irregexp-inl.h
Removed:
branches/ble
Aside from my comments, it looks good. But Ivan should look at it, I
think.
http://codereview.chromium.org/10993/diff/1/5
File src/codegen-ia32.cc (right):
http://codereview.chromium.org/10993/diff/1/5#newcode2600
Line 2600: // Smis are loaded in two steps via a temporary register.
Is now the
Author: [EMAIL PROTECTED]
Date: Fri Nov 28 03:48:22 2008
New Revision: 866
Modified:
branches/bleeding_edge/src/bytecodes-irregexp.h
branches/bleeding_edge/src/interpreter-irregexp.cc
branches/bleeding_edge/src/regexp-macro-assembler-ia32.cc
branches/bleeding_edge/src/regexp-macro
Reviewers: Mads Ager,
Description:
Fix build error in debug mode by making sure the tracer has the
new method too.
Fix spacing in tracer.
Please review this at http://codereview.chromium.org/12806
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M src/regex
Author: [EMAIL PROTECTED]
Date: Fri Nov 28 04:11:36 2008
New Revision: 867
Modified:
branches/bleeding_edge/src/regexp-macro-assembler-tracer.cc
branches/bleeding_edge/src/regexp-macro-assembler-tracer.h
Log:
Fix build error in debug mode by making sure the tracer has the
new method too.
http://codereview.chromium.org/10993/diff/1/5
File src/codegen-ia32.cc (right):
http://codereview.chromium.org/10993/diff/1/5#newcode2600
Line 2600: // Smis are loaded in two steps via a temporary register.
On 2008/11/28 10:32:45, William Hesse wrote:
> Is now the time for special-casing small l
Author: [EMAIL PROTECTED]
Date: Fri Nov 28 05:19:57 2008
New Revision: 868
Modified:
branches/experimental/toiger/src/codegen-ia32.cc
branches/experimental/toiger/src/codegen-ia32.h
branches/experimental/toiger/src/virtual-frame-ia32.cc
branches/experimental/toiger/src/virtual-fra
Reviewers: Christian Plesner Hansen,
Description:
* Remove an unused layer of abstraction by not having both a macro
assembler and
an assembler when compiling to bytecode. This fixes
http://code.google.com/p/v8/issues/detail?id=165
* Preload the 'current character' register when starting a
Reviewers: Christian Plesner Hansen,
Description:
Add an operation that checks whether we are at the start of the string.
Please review this at http://codereview.chromium.org/10998
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M src/bytecodes-irregexp.h
LGTM
http://codereview.chromium.org/12806
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
-~--~~~~--~~--~--~---
Lgtm
http://codereview.chromium.org/10998
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
-~--~~~~--~~--~--~---
Yawn. Lgtm.
http://codereview.chromium.org/10995/diff/1/13
File src/jsregexp.cc (right):
http://codereview.chromium.org/10995/diff/1/13#newcode2732
Line 2732: byte codes[1024];
You can use EmbeddedVector instead.
http://codereview.chromium.org/10995
--~--~-~--~~~-
Reviewers: Mads Ager,
Message:
Periodic SVN merge.
Description:
Periodic merge of bleeding_edge to experimental code generator branch.
Merge bleeding_edge to code generator branch to pick up regular
expression changes. All unmerged changes to bleeding_edge up to r868
are included.
Please revi
I've just submitted this, so consider it TBR.
On Fri, Nov 28, 2008 at 2:55 PM, <[EMAIL PROTECTED]> wrote:
> Reviewers: Mads Ager,
>
> Message:
> Periodic SVN merge.
>
> Description:
> Periodic merge of bleeding_edge to experimental code generator branch.
>
> Merge bleeding_edge to code generator
Reviewers: William Hesse, olehougaard,
Description:
Fix eval, which was broken by merging from bleeding_edge.
Please review this at http://codereview.chromium.org/13001
SVN Base: http://v8.googlecode.com/svn/branches/experimental/toiger/
Affected files:
M src/codegen-ia32.cc
Index: sr
Reviewers: Erik Corry,
Message:
Small code review.
Description:
Fixes (last?) bugs in regexp-ia32 core functionality. All tests run!
Please review this at http://codereview.chromium.org/12807
Affected files:
M src/assembler-ia32.h
M src/assembler-ia32.cc
M src/jsregexp.cc
M src/reg
Reviewers: Erik Corry, Christian Plesner Hansen,
Message:
Rietveld has broken side-by-side view again, for objects.cc.
Description:
Use direct copy and templates to speed up flattening of strings.
Please review this at http://codereview.chromium.org/8010
SVN Base: http://v8.googlecode.com/svn
I wonder WTF this old change list is being revived now?
On Fri, Nov 28, 2008 at 5:22 PM, <[EMAIL PROTECTED]> wrote:
> Reviewers: Erik Corry, Christian Plesner Hansen,
>
> Message:
> Rietveld has broken side-by-side view again, for objects.cc.
>
>
> Description:
> Use direct copy and templates to
Status: New
Owner:
New issue 166 by patterner: r869 jsrexep.cc needs qsort() declaration
http://code.google.com/p/v8/issues/detail?id=166
% g++ -o obj/release/jsregexp.o -c -m32 src/jsregexp.cc
src/utils.h: In member function 'void v8::internal::Vector::Sort(int
(*)(const T*, const T*)) [w
Updates:
Status: Accepted
Owner: christian.plesner.hansen
Comment #1 on issue 166 by christian.plesner.hansen: r869 jsrexep.cc needs
qsort() declaration
http://code.google.com/p/v8/issues/detail?id=166
(No comment was entered for this change.)
--
You received this message bec
Sorry about that Kevin, didn't notice this one. LGTM.
On 11/28/08, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote:
>
> Reviewers: Mads Ager,
>
> Message:
> Periodic SVN merge.
>
> Description:
> Periodic merge of bleeding_edge to experimental code generator branch.
>
> Merge bleeding_edge to code ge
28 matches
Mail list logo
