Reviewers: Lasse Reichstein,
Description:
- Added some expansion of assertions.
- Splitting of character classes into word and non-word parts.
- A bunch of refactorings.
- Made dispatch table construction lazy.
Please review this at http://codereview.chromium.org/13014
Affected files:
M src/
Attached is the graph for \b\w after assertion expansion.
On Mon, Dec 1, 2008 at 9:51 AM, <[EMAIL PROTECTED]> wrote:
> Reviewers: Lasse Reichstein,
>
> Description:
> - Added some expansion of assertions.
> - Splitting of character classes into word and non-word parts.
> - A bunch of refactorings
Author: [EMAIL PROTECTED]
Date: Mon Dec 1 01:57:14 2008
New Revision: 873
Modified:
branches/bleeding_edge/src/assembler-ia32.cc
branches/bleeding_edge/src/assembler-ia32.h
branches/bleeding_edge/src/jsregexp.cc
branches/bleeding_edge/src/regexp-macro-assembler-ia32.cc
branch
Reviewers: Mads Ager,
Message:
Quick review
Description:
Fixes stray IA32-reference in ARM builds
Please review this at http://codereview.chromium.org/12822
Affected files:
M src/jsregexp.cc
Index: src/jsregexp.cc
diff --git a/src/jsregexp.cc b/src/jsregexp.cc
index
be767bff71f03acec1bb
Author: [EMAIL PROTECTED]
Date: Mon Dec 1 02:17:24 2008
New Revision: 874
Modified:
branches/bleeding_edge/src/jsregexp.cc
Log:
Fixes stray IA32-reference in ARM builds
Modified: branches/bleeding_edge/src/jsregexp.cc
===
LGTM
http://codereview.chromium.org/12822
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
-~--~~~~--~~--~--~---
Reviewers: Christian Plesner Hansen,
Message:
Tiny review, pleae.
Description:
Added assignment to variable after UNIMPLEMENTED macro, to keep compiler
happy.
Please review this at http://codereview.chromium.org/13015
Affected files:
M src/jsregexp.cc
Index: src/jsregexp.cc
diff --git a/s
Lgtm
http://codereview.chromium.org/13015
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
-~--~~~~--~~--~--~---
Author: [EMAIL PROTECTED]
Date: Mon Dec 1 03:46:08 2008
New Revision: 875
Modified:
branches/bleeding_edge/src/jsregexp.cc
Log:
Added assignment to variable after UNIMPLEMENTED macro, to keep compiler
happy.
Modified: branches/bleeding_edge/src/jsregexp.cc
==
LGTM.
http://codereview.chromium.org/13014/diff/1/5
File src/jsregexp.h (right):
http://codereview.chromium.org/13014/diff/1/5#newcode447
Line 447: enum TriBool {
Not really a better name. Not that I can think of one that is, but
TriBool is simply wrong (either it's three or it's a bool).
htt
Reviewers: Christian Plesner Hansen,
Message:
Small review, please.
Description:
Allow the non-spec [a-\d] (i.e., ending a range with a character class)
in RegExps.
Please review this at http://codereview.chromium.org/13016
Affected files:
M src/parser.cc
M test/cctest/test-regexp.cc
Reviewers: Mike Belshe, Mads Ager,
Message:
Here is the change in the daylight saving time lookup
code. I also have a browser test for it, which I will email you. I
would like someone in the US to test it on a US Windows system, to check
US DST calculations.
It is much faster on Windows XP SP
OK, looks good.
http://codereview.chromium.org/13001
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
-~--~~~~--~~--~--~---
Just an fyi, beware of:
http://securityvulns.com/advisories/year3000.asp
-- dean
On Mon, Dec 1, 2008 at 5:50 AM, <[EMAIL PROTECTED]> wrote:
>
> Reviewers: Mike Belshe, Mads Ager,
>
> Message:
> Here is the change in the daylight saving time lookup
> code. I also have a browser test for it, wh
Author: [EMAIL PROTECTED]
Date: Mon Dec 1 06:10:46 2008
New Revision: 876
Modified:
branches/experimental/toiger/src/codegen-ia32.cc
Log:
Fix eval, which was broken by merging from bleeding_edge.
Review URL: http://codereview.chromium.org/13001
Modified: branches/experimental/toiger/src/co
LGTM.
Too bad that the more correct system call became that slow in SP3. :-(
http://codereview.chromium.org/12824/diff/201/202
File src/platform-win32.cc (right):
http://codereview.chromium.org/12824/diff/201/202#newcode453
Line 453: if (posix_time >= 32535244800i64) return 0; // Jan 1, 3001
Thanks Dean. Bill put in explicit checks for that and we make sure to
convert to a reasonable date in the caller.
-- Mads
On Mon, Dec 1, 2008 at 3:11 PM, Dean McNamee <[EMAIL PROTECTED]> wrote:
> Just an fyi, beware of:
>
> http://securityvulns.com/advisories/year3000.asp
>
> -- dean
>
> On Mon
lgtm
http://codereview.chromium.org/13016
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
-~--~~~~--~~--~--~---
Reviewers: William Hesse,
Description:
Experimental: lazier spilling when visiting declarations. We still
just always spill on declarations, but no longer in the case that we
don't emit any (other) code.
Please review this at http://codereview.chromium.org/12825
SVN Base: http://v8.googlecode.
Author: [EMAIL PROTECTED]
Date: Mon Dec 1 06:29:28 2008
New Revision: 877
Modified:
branches/bleeding_edge/src/parser.cc
branches/bleeding_edge/test/cctest/test-regexp.cc
Log:
Allow the non-spec [a-\d] (i.e., ending a range with a character class) in
RegExps.
Modified: branches/blee
We already use _USE_32BIT_TIME_T in both SCons and Visual Studio builds.
/Søren
On Mon, Dec 1, 2008 at 3:19 PM, Mads Ager <[EMAIL PROTECTED]> wrote:
>
> Thanks Dean. Bill put in explicit checks for that and we make sure to
> convert to a reasonable date in the caller.
>
> -- Mads
>
> On Mon, Dec
LGTM
http://codereview.chromium.org/12825
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
-~--~~~~--~~--~--~---
Author: [EMAIL PROTECTED]
Date: Mon Dec 1 07:06:44 2008
New Revision: 878
Modified:
branches/experimental/toiger/src/codegen-ia32.cc
Log:
Experimental: lazier spilling when visiting declarations. We still
just always spill on declarations, but no longer in the case that we
don't emit any (
Reviewers: Mads Ager,
Description:
Added checking in the regular expression parser that we're below the
stack limit and that the zone allocation limit hasn't been met.
Please review this at http://codereview.chromium.org/12826
Affected files:
M src/parser.cc
M src/top.h
M src/top.cc
LGTM
http://codereview.chromium.org/12826/diff/1/2
File src/parser.cc (right):
http://codereview.chromium.org/12826/diff/1/2#newcode1033
Line 1033: ((void)0
Maybe we should add a dummy parenthesis as above so editor indentation
does not break?
http://codereview.chromium.org/12826
--~--~--
Author: [EMAIL PROTECTED]
Date: Mon Dec 1 07:32:20 2008
New Revision: 879
Modified:
branches/bleeding_edge/src/parser.cc
branches/bleeding_edge/src/top.cc
branches/bleeding_edge/src/top.h
branches/bleeding_edge/src/zone-inl.h
branches/bleeding_edge/src/zone.cc
branches/bl
OK, will fix. All callers use JS function EquivalentTime to put the
argument in
the 32-bit range. EquivalentTime needs to be changed, so it starts after
1970.
Runtime checks are corrected.
On Mon, Dec 1, 2008 at 3:49 PM, Søren Gjesse <[EMAIL PROTECTED]> wrote:
> We already use _USE_32BIT_TIME_
Author: [EMAIL PROTECTED]
Date: Mon Dec 1 07:42:35 2008
New Revision: 880
Modified:
branches/bleeding_edge/src/char-predicates-inl.h
branches/bleeding_edge/src/char-predicates.h
branches/bleeding_edge/src/jsregexp.cc
branches/bleeding_edge/src/jsregexp.h
branches/bleeding_edg
http://codereview.chromium.org/12826/diff/1/2
File src/parser.cc (right):
http://codereview.chromium.org/12826/diff/1/2#newcode1033
Line 1033: ((void)0
Aah, so that's what DUMMY was for.
http://codereview.chromium.org/12826
--~--~-~--~~~---~--~~
v8-dev mailing l
Status: New
Owner:
New issue 169 by perrinmeyer: error building d8 console=readline on OS X
http://code.google.com/p/v8/issues/detail?id=169
(on OS X (10.5, latest xcode)
$ scons d8 console=readline
gives
scons: Reading SConscript files ...
scons: done reading SConscript files.
scons: Bu
lgtm
I assume you ran this through the mozilla tests? I know we had trouble
finding the right sequence of win32 apis when we did this the first
time.
I think the bug the ensure against is that computing the offset for a
time which was in DST when we're no longer in DST still works.
For instanc
Updates:
Owner: erik.corry
Cc: [EMAIL PROTECTED]
Comment #2 on issue 143 by [EMAIL PROTECTED]: Context::New can't handle
preemption
http://code.google.com/p/v8/issues/detail?id=143
(No comment was entered for this change.)
--
You received this message because you are listed i
Status: New
Owner:
New issue 170 by perrinmeyer: error building d8 console=readline on linux
http://code.google.com/p/v8/issues/detail?id=170
$ scons d8 console=realline
fails on gentoo linux (g++ 4.2.1) with
scons: Reading SConscript files ...
scons: done reading SConscript files.
scons:
Thanks! When this makes it over to the v8 trunk, we need the
associated Chrome change.
I have that Chrome change ready to go:
http://codereview.chromium.org/12818/show
and I am happy to update the Chrome DEPS file as well, but that won't
happen until v8 bleeding_edge migrates to trunk. If anyo
Reviewers: Mark Mentovai,
Message:
Mark,
Here are some of the changes that will be needed for the V8 Xcode
project in the Chromium sources once the new regular expression code has
been pushed to trunk. We can take a deeper look once that is the case.
-Ivan
TBR=mark
Description:
Update Xcode p
Author: [EMAIL PROTECTED]
Date: Mon Dec 1 15:06:09 2008
New Revision: 881
Modified:
branches/bleeding_edge/tools/v8.xcodeproj/project.pbxproj
Log:
Update Xcode project to contain the files for Irregexp.
Review URL: http://codereview.chromium.org/13025
Modified: branches/bleeding_edge/tool
LGTM
http://codereview.chromium.org/13025
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
-~--~~~~--~~--~--~---
Author: [EMAIL PROTECTED]
Date: Mon Dec 1 22:35:11 2008
New Revision: 882
Removed:
changes/
Log:
Removed changes directory left over from when we used gvn.
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-
38 matches
Mail list logo
