Reviewers: Lasse Reichstein,
Description:
Fix http://code.google.com/p/chromium/issues/detail?id=7258 crash in
IsFlat.
You can't keep a StringShape across things that can cause GC.
Please review this at http://codereview.chromium.org/19749
SVN Base: http://v8.googlecode.com/svn/branches/bleedin
LGTM
On Mon, Feb 2, 2009 at 9:14 AM, wrote:
> Reviewers: Lasse Reichstein,
>
> Description:
> Fix http://code.google.com/p/chromium/issues/detail?id=7258 crash in
> IsFlat.
> You can't keep a StringShape across things that can cause GC.
>
> Please review this at http://codereview.chromium.org/1
Author: a...@chromium.org
Date: Mon Feb 2 00:37:13 2009
New Revision: 1201
Modified:
trunk/src/api.cc
Log:
Forgot to update version number.
Modified: trunk/src/api.cc
==
--- trunk/src/api.cc(original)
+++ trunk
Author: erik.co...@gmail.com
Date: Mon Feb 2 00:23:42 2009
New Revision: 1199
Modified:
branches/bleeding_edge/src/jsregexp.cc
Log:
Fix http://code.google.com/p/chromium/issues/detail?id=7258 crash in IsFlat.
You can't keep a StringShape across things that can cause GC.
Review URL: http://c
Author: a...@chromium.org
Date: Mon Feb 2 00:33:31 2009
New Revision: 1200
Modified:
trunk/src/jsregexp.cc
Log:
Push bleeding_edge revision 1199 to trunk. Fixes chromium issue 7258.
Modified: trunk/src/jsregexp.cc
===
Mostly nits.
http://codereview.chromium.org/19537/diff/1/8
File src/factory.cc (right):
http://codereview.chromium.org/19537/diff/1/8#newcode163
Line 163: script->set_line_ends(*(Factory::NewFixedArray(0)));
Use Heap::undefined_value() to mark not initialized.
http://codereview.chromium.org/19
Lgtm
http://codereview.chromium.org/19752
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
-~--~~~~--~~--~--~---
Updates:
Status: Fixed
Comment #2 on issue 220 by kmilli...@chromium.org: CHECK(target.is_slot())
failed
http://code.google.com/p/v8/issues/detail?id=220
Fixed in bleeding_edge r1203. See http://codereview.chromium.org/19745
--
You received this message because you are listed in the
Lgtm.
Have you tried to run the Big(TM) test with optimizations disabled?
http://codereview.chromium.org/19538
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
-~--~~~~--~~--~-
Reviewers: William Hesse, Kasper Lund,
Message:
Kasper & Bill, can you take a look at this?
Two caveats:
(1) Much of the complication is involved in correctly implementing
VirtualFrame::MakeMergable, which is all going away shortly. It will be
replaced with a function to calculate a target fra
LGTM as well, especially once a clarifying comment is put in.
-Ivan
http://codereview.chromium.org/19745
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
-~--~~~~--~~--~--~---
Author: erik.co...@gmail.com
Date: Mon Feb 2 08:27:31 2009
New Revision: 1210
Modified:
branches/bleeding_edge/src/flag-definitions.h
branches/bleeding_edge/src/jsregexp.cc
Log:
The optimizations performed by Irregexp could possible hide bugs or
could themselves be a source of bugs. Ad
The Big(TM) test is not in the repository.
On Mon, Feb 2, 2009 at 5:47 PM, Erik Corry wrote:
> On Mon, Feb 2, 2009 at 4:45 PM, wrote:
>> Lgtm.
>>
>> Have you tried to run the Big(TM) test with optimizations disabled?
>
> I've run all the tests in the repository.
>
> --
> Erik Corry, Software E
Author: mikhail.naga...@gmail.com
Date: Mon Feb 2 04:54:56 2009
New Revision: 1205
Added:
changes/mnaganov/
changes/mnaganov/line-numbers/
changes/mnaganov/line-numbers/bleeding_edge/
- copied from r1204, /branches/bleeding_edge/
Modified:
changes/mnaganov/line-numbers/ble
If you add a comment about what we're popping (as requested by Ivan),
it still LGTM.
On Mon, Feb 2, 2009 at 11:12 AM, wrote:
> Added regression test. Take a quick look, please.
>
> http://codereview.chromium.org/19745
>
--~--~-~--~~~---~--~~
v8-dev mailing list
Updates:
Status: Fixed
Comment #2 on issue 221 by a...@chromium.org: what(): St9bad_alloc
http://code.google.com/p/v8/issues/detail?id=221
Thanks for reporting this problem!
This was caused by an infinite loop when resolving 'eval'. This has been
fixed in V8
bleeding_edge revision 1
Author: erik.co...@gmail.com
Date: Mon Feb 2 08:27:08 2009
New Revision: 1209
Modified:
branches/bleeding_edge/tools/presubmit.py
Log:
Tell presubmit.py that regexp-pcre.js doesn't need a standard copyright
message since it has a special one.
Review URL: http://codereview.chromium.org/19752
On Mon, Feb 2, 2009 at 5:31 PM, wrote:
> Reviewers: Erik Corry,
>
> Description:
> Turned down the amount of work done by array-splice to ensure that it
> doesn't time out on our slowest platforms. It turns out that almost
> all the time was spent in Array.prototype.unshift on a non-array with
75% of the time was taken up by the 3-4 unshift calls on the
4-large non-array and looking at the implementation it's obvious
why that is.
On Mon, Feb 2, 2009 at 8:06 PM, Erik Corry wrote:
> On Mon, Feb 2, 2009 at 5:31 PM, wrote:
>> Reviewers: Erik Corry,
>>
>> Description:
>> Turned down
On Mon, Feb 2, 2009 at 8:19 PM, Christian Plesner Hansen
wrote:
>
> 75% of the time was taken up by the 3-4 unshift calls on the
> 4-large non-array and looking at the implementation it's obvious
> why that is.
Ah yes, I'd forgotten that the largest size doesn't get run on
non-arrays because
This code review is broken; file is too large.
http://codereview.chromium.org/19751
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
-~--~~~~--~~--~--~---
Reviewers: Mads Ager,
Description:
Changed the debugger API to allow only one debug event listener to be
registered. The public API now only has SetDebugEventListener instead of
AddDebugEventListener and RemoveDebugEventListener.
Moved the registrered debug event listener from the context to a g
Excellent stuff. I assume there are no regressions of performance or
correctness and that it lints.
Does the not at start flag need to be on all RegExpNodes or could we
just put it on the ChoiceNodes and their children?
http://codereview.chromium.org/19539/diff/1/2
File src/ast.cc (right):
ht
LGTM.
http://codereview.chromium.org/19536
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
-~--~~~~--~~--~--~---
Author: christian.plesner.han...@gmail.com
Date: Mon Feb 2 04:19:23 2009
New Revision: 1204
Modified:
data/benchmarks/current/run.html
Log:
Added title to the benchmark redirect page
Modified: data/benchmarks/current/run.html
Author: kmilli...@chromium.org
Date: Mon Feb 2 04:05:13 2009
New Revision: 1203
Added:
branches/bleeding_edge/test/mjsunit/regress/regress-220.js
Modified:
branches/bleeding_edge/src/codegen-arm.cc
branches/bleeding_edge/src/codegen-ia32.cc
Log:
Fix for off-by-one when initializing
On Mon, Feb 2, 2009 at 4:45 PM, wrote:
> Lgtm.
>
> Have you tried to run the Big(TM) test with optimizations disabled?
I've run all the tests in the repository.
--
Erik Corry, Software Engineer
Google Denmark ApS. CVR nr. 28 86 69 84
c/o Philip & Partners, 7 Vognmagergade, P.O. Box 2227, DK-
Reviewers: Kevin Millikin,
Description:
Fix issue 221:
http://code.google.com/p/v8/issues/detail?id=221
The attempt to resolve 'eval' went into an infinite loop. Also, we
need to throw a reference error in case 'eval' cannot be resolved.
Please review this at http://codereview.chromium.o
Reviewers: Christian Plesner Hansen,
Description:
Added regexp tests from PCRE.
Please review this at http://codereview.chromium.org/19751
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M test/mjsunit/regexp-capture.js
test/mjsunit/regexp-pcre.js
--
Author: christian.plesner.han...@gmail.com
Date: Mon Feb 2 03:29:12 2009
New Revision: 1202
Modified:
data/benchmarks/current/revisions.html
data/benchmarks/current/run.html
Log:
Updated benchmark redirect to v3
Modified: data/benchmarks/current/revisions.html
=
Reviewers: Christian Plesner Hansen,
Description:
The optimizations performed by Irregexp could possible hide bugs or
could themselves be a source of bugs. Add a flag to switch off
optimizations (--noirregexp-optimization) to aid testing.
Please review this at http://codereview.chromium.org/195
Reviewers: Erik Corry,
Description:
Turned down the amount of work done by array-splice to ensure that it
doesn't time out on our slowest platforms. It turns out that almost
all the time was spent in Array.prototype.unshift on a non-array with
a length-field holding 4. We may want to look i
Reviewers: Erik Corry,
Message:
Semi-tricky review.
Description:
Trace contains information about whether we know that we are at the
start of input.
Choice nodes may know that they are never not at the start of input.
This can remove start_of_input assertions in cases where they are
statically k
Author: a...@chromium.org
Date: Mon Feb 2 06:43:26 2009
New Revision: 1208
Modified:
wiki/Contributing.wiki
Log:
Edited wiki page through web user interface.
Modified: wiki/Contributing.wiki
==
--- wiki/Contributin
Added regression test. Take a quick look, please.
http://codereview.chromium.org/19745
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
-~--~~~~--~~--~--~---
Reviewers: Christian Plesner Hansen,
Description:
Tell presubmit.py that regexp-pcre.js doesn't need a standard copyright
message since it has a special one.
Please review this at http://codereview.chromium.org/19752
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files
Updates:
Status: Assigned
Owner: a...@chromium.org
Comment #1 on issue 221 by a...@chromium.org: what(): St9bad_alloc
http://code.google.com/p/v8/issues/detail?id=221
(No comment was entered for this change.)
--
You received this message because you are listed in the owner
or C
Lgtm. I would add a comment that explains that the fact that we have
tests including stuff like \p{SomeObscureCharacter} doesn't mean that we
support it.
http://codereview.chromium.org/19751
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http:/
Author: a...@chromium.org
Date: Mon Feb 2 05:18:20 2009
New Revision: 1206
Added:
branches/bleeding_edge/test/mjsunit/regress/regress-221.js
Modified:
branches/bleeding_edge/src/runtime.cc
Log:
Fix issue 221:
http://code.google.com/p/v8/issues/detail?id=221
The attempt to resolve
http://codereview.chromium.org/19751
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
-~--~~~~--~~--~--~---
LGTM.
This change probably needs a Chromium change as well. Could you prepare
that and make sure that it passes the debugger tests? That will make it
much easier when we push the next V8 version to Chromium.
http://codereview.chromium.org/19753/diff/1/28
File include/v8.h (right):
http://cod
I will prepare a Chromium patch.
http://codereview.chromium.org/19753/diff/1/28
File include/v8.h (right):
http://codereview.chromium.org/19753/diff/1/28#newcode2127
Line 2127: /**
On 2009/02/03 07:24:40, Mads Ager wrote:
> Accidental edit? This file can be left out of the changelist.
Done.
On Mon, Feb 2, 2009 at 10:22 PM, wrote:
> Excellent stuff. I assume there are no regressions of performance or
> correctness and that it lints.
>
> Does the not at start flag need to be on all RegExpNodes or could we
> just put it on the ChoiceNodes and their children?
>
>
> http://codereview.c
43 matches
Mail list logo
